浏览代码

serial: samsung: wait for transfer completion before clock disable

This patch adds waiting until transmit buffer and shifter will be empty
before clock disabling.

Without this fix it's possible to have clock disabled while data was
not transmited yet, which causes unproper state of TX line and problems
in following data transfers.

Cc: <stable@vger.kernel.org> # v2.6.26+
Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Robert Baldyga 11 年之前
父节点
当前提交
1ff383a4c3
共有 1 个文件被更改,包括 4 次插入0 次删除
  1. 4 0
      drivers/tty/serial/samsung.c

+ 4 - 0
drivers/tty/serial/samsung.c

@@ -559,11 +559,15 @@ static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level,
 			      unsigned int old)
 			      unsigned int old)
 {
 {
 	struct s3c24xx_uart_port *ourport = to_ourport(port);
 	struct s3c24xx_uart_port *ourport = to_ourport(port);
+	int timeout = 10000;
 
 
 	ourport->pm_level = level;
 	ourport->pm_level = level;
 
 
 	switch (level) {
 	switch (level) {
 	case 3:
 	case 3:
+		while (--timeout && !s3c24xx_serial_txempty_nofifo(port))
+			udelay(100);
+
 		if (!IS_ERR(ourport->baudclk))
 		if (!IS_ERR(ourport->baudclk))
 			clk_disable_unprepare(ourport->baudclk);
 			clk_disable_unprepare(ourport->baudclk);