浏览代码

kernfs: Replace strncpy with memcpy

gcc 8.1.0 complains:

fs/kernfs/symlink.c:91:3: warning:
	'strncpy' output truncated before terminating nul copying
	as many bytes from a string as its length
fs/kernfs/symlink.c: In function 'kernfs_iop_get_link':
fs/kernfs/symlink.c:88:14: note: length computed here

Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Guenter Roeck 7 年之前
父节点
当前提交
166126c1e5
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      fs/kernfs/symlink.c

+ 1 - 1
fs/kernfs/symlink.c

@@ -88,7 +88,7 @@ static int kernfs_get_target_path(struct kernfs_node *parent,
 		int slen = strlen(kn->name);
 		int slen = strlen(kn->name);
 
 
 		len -= slen;
 		len -= slen;
-		strncpy(s + len, kn->name, slen);
+		memcpy(s + len, kn->name, slen);
 		if (len)
 		if (len)
 			s[--len] = '/';
 			s[--len] = '/';