Просмотр исходного кода

be2net: Remove code that stops further access to BE NIC based on UE bits

On certain platforms, BE hardware could  falsely indicate UE.
For BE family of NICs, do not set hw_error based on the UE bits.
If there was a real fatal error, the corresponding h/w block will
automatically go offline and stop traffic.

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Ajit Khaparde 13 лет назад
Родитель
Сommit
1451ae6ef8
1 измененных файлов с 5 добавлено и 2 удалено
  1. 5 2
      drivers/net/ethernet/emulex/benet/be_main.c

+ 5 - 2
drivers/net/ethernet/emulex/benet/be_main.c

@@ -2129,8 +2129,11 @@ void be_detect_error(struct be_adapter *adapter)
 		ue_hi = (ue_hi & ~ue_hi_mask);
 		ue_hi = (ue_hi & ~ue_hi_mask);
 	}
 	}
 
 
-	if (ue_lo || ue_hi ||
-		sliport_status & SLIPORT_STATUS_ERR_MASK) {
+	/* On certain platforms BE hardware can indicate spurious UEs.
+	 * Allow the h/w to stop working completely in case of a real UE.
+	 * Hence not setting the hw_error for UE detection.
+	 */
+	if (sliport_status & SLIPORT_STATUS_ERR_MASK) {
 		adapter->hw_error = true;
 		adapter->hw_error = true;
 		dev_err(&adapter->pdev->dev,
 		dev_err(&adapter->pdev->dev,
 			"Error detected in the card\n");
 			"Error detected in the card\n");