Browse Source

dm raid: cleanup awkward branching in raid_message() option processing

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Mike Snitzer 9 years ago
parent
commit
105db59912
1 changed files with 4 additions and 3 deletions
  1. 4 3
      drivers/md/dm-raid.c

+ 4 - 3
drivers/md/dm-raid.c

@@ -3464,10 +3464,11 @@ static int raid_message(struct dm_target *ti, unsigned int argc, char **argv)
 	else {
 	else {
 		if (!strcasecmp(argv[0], "check"))
 		if (!strcasecmp(argv[0], "check"))
 			set_bit(MD_RECOVERY_CHECK, &mddev->recovery);
 			set_bit(MD_RECOVERY_CHECK, &mddev->recovery);
-		else if (!!strcasecmp(argv[0], "repair"))
+		else if (!strcasecmp(argv[0], "repair")) {
+			set_bit(MD_RECOVERY_REQUESTED, &mddev->recovery);
+			set_bit(MD_RECOVERY_SYNC, &mddev->recovery);
+		} else
 			return -EINVAL;
 			return -EINVAL;
-		set_bit(MD_RECOVERY_REQUESTED, &mddev->recovery);
-		set_bit(MD_RECOVERY_SYNC, &mddev->recovery);
 	}
 	}
 	if (mddev->ro == 2) {
 	if (mddev->ro == 2) {
 		/* A write to sync_action is enough to justify
 		/* A write to sync_action is enough to justify