瀏覽代碼

IB/ipoib: Fix for potential no-carrier state

On reboot SM can program port pkey table before ipoib registered its
event handler, which could result in missing pkey event and leave root
interface with initial pkey value from index 0.

Since OPA port starts with invalid pkey in index 0, root interface will
fail to initialize and stay down with no-carrier flag.

For IB ipoib interface may end up with pkey different from value
opensm put in pkey table idx 0, resulting in connectivity issues
(different mcast groups, for example).

Close the window by calling event handler after registration
to make sure ipoib pkey is in sync with port pkey table.

Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Alex Estrin <alex.estrin@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Alex Estrin 7 年之前
父節點
當前提交
1029361084
共有 1 個文件被更改,包括 3 次插入0 次删除
  1. 3 0
      drivers/infiniband/ulp/ipoib/ipoib_main.c

+ 3 - 0
drivers/infiniband/ulp/ipoib/ipoib_main.c

@@ -2306,6 +2306,9 @@ static struct net_device *ipoib_add_port(const char *format,
 			      priv->ca, ipoib_event);
 			      priv->ca, ipoib_event);
 	ib_register_event_handler(&priv->event_handler);
 	ib_register_event_handler(&priv->event_handler);
 
 
+	/* call event handler to ensure pkey in sync */
+	queue_work(ipoib_workqueue, &priv->flush_heavy);
+
 	result = register_netdev(priv->dev);
 	result = register_netdev(priv->dev);
 	if (result) {
 	if (result) {
 		pr_warn("%s: couldn't register ipoib port %d; error %d\n",
 		pr_warn("%s: couldn't register ipoib port %d; error %d\n",