瀏覽代碼

netfilter: nf_tables: use the right index from flowtable error path

Use the right loop index, not the number of devices in the array that we
need to remove, the following message uncovered the problem:

[ 5437.044119] hook not found, pf 5 num 0
[ 5437.044140] WARNING: CPU: 2 PID: 24983 at net/netfilter/core.c:376 __nf_unregister_net_hook+0x250/0x280

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Pablo Neira Ayuso 7 年之前
父節點
當前提交
0e0d5002f8
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      net/netfilter/nf_tables_api.c

+ 1 - 1
net/netfilter/nf_tables_api.c

@@ -5136,7 +5136,7 @@ err5:
 	i = flowtable->ops_len;
 	i = flowtable->ops_len;
 err4:
 err4:
 	for (k = i - 1; k >= 0; k--)
 	for (k = i - 1; k >= 0; k--)
-		nf_unregister_net_hook(net, &flowtable->ops[i]);
+		nf_unregister_net_hook(net, &flowtable->ops[k]);
 
 
 	kfree(flowtable->ops);
 	kfree(flowtable->ops);
 err3:
 err3: