Explorar o código

xfs: check for underflow in xfs_iformat_fork()

The "di_size" variable comes from the disk and it's a signed 64 bit.
We check the upper limit but we should check for negative numbers as
well.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Dan Carpenter %!s(int64=12) %!d(string=hai) anos
pai
achega
0d0ab120d1
Modificáronse 1 ficheiros con 2 adicións e 1 borrados
  1. 2 1
      fs/xfs/xfs_inode_fork.c

+ 2 - 1
fs/xfs/xfs_inode_fork.c

@@ -167,7 +167,8 @@ xfs_iformat_fork(
 			}
 			}
 
 
 			di_size = be64_to_cpu(dip->di_size);
 			di_size = be64_to_cpu(dip->di_size);
-			if (unlikely(di_size > XFS_DFORK_DSIZE(dip, ip->i_mount))) {
+			if (unlikely(di_size < 0 ||
+				     di_size > XFS_DFORK_DSIZE(dip, ip->i_mount))) {
 				xfs_warn(ip->i_mount,
 				xfs_warn(ip->i_mount,
 			"corrupt inode %Lu (bad size %Ld for local inode).",
 			"corrupt inode %Lu (bad size %Ld for local inode).",
 					(unsigned long long) ip->i_ino,
 					(unsigned long long) ip->i_ino,