瀏覽代碼

blk-mq: fix leak of q->stats

blk_alloc_queue_node() already allocates q->stats, so
blk_mq_init_allocated_queue() is overwriting it with a new allocation.

Fixes: a83b576c9c25 ("block: fix stacked driver stats init and free")
Reviewed-by: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Omar Sandoval 8 年之前
父節點
當前提交
0c9539a431
共有 1 個文件被更改,包括 0 次插入4 次删除
  1. 0 4
      block/blk-mq.c

+ 0 - 4
block/blk-mq.c

@@ -2234,10 +2234,6 @@ struct request_queue *blk_mq_init_allocated_queue(struct blk_mq_tag_set *set,
 	/* mark the queue as mq asap */
 	/* mark the queue as mq asap */
 	q->mq_ops = set->ops;
 	q->mq_ops = set->ops;
 
 
-	q->stats = blk_alloc_queue_stats();
-	if (!q->stats)
-		goto err_exit;
-
 	q->poll_cb = blk_stat_alloc_callback(blk_mq_poll_stats_fn,
 	q->poll_cb = blk_stat_alloc_callback(blk_mq_poll_stats_fn,
 					     blk_stat_rq_ddir, 2, q);
 					     blk_stat_rq_ddir, 2, q);
 	if (!q->poll_cb)
 	if (!q->poll_cb)