Jelajahi Sumber

hwmon: (ams) Fix permissions on 'joystick' module parameter

We should not allow writes to the 'joystick' module parameters since
writing there will not trigger creation of the input device. Disable
writes since we provide alternative way of enabling input device via
AMS device's sysfs attribute.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Dmitry Torokhov 17 tahun lalu
induk
melakukan
0a02002268
1 mengubah file dengan 2 tambahan dan 2 penghapusan
  1. 2 2
      drivers/hwmon/ams/ams-input.c

+ 2 - 2
drivers/hwmon/ams/ams-input.c

@@ -20,11 +20,11 @@
 #include "ams.h"
 
 static unsigned int joystick;
-module_param(joystick, bool, 0644);
+module_param(joystick, bool, S_IRUGO);
 MODULE_PARM_DESC(joystick, "Enable the input class device on module load");
 
 static unsigned int invert;
-module_param(invert, bool, 0644);
+module_param(invert, bool, S_IWUSR | S_IRUGO);
 MODULE_PARM_DESC(invert, "Invert input data on X and Y axis");
 
 static void ams_idev_poll(struct input_polled_dev *dev)