ソースを参照

perf report: Fill in the missing session freeing after an error occurs

When an error occurs an error value is just returned without freeing the
session. So allocating and freeing session have to be matched as a pair
even if an error occurs.

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1435652124-22414-6-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Taeung Song 10 年 前
コミット
07a716fff2
1 ファイル変更4 行追加2 行削除
  1. 4 2
      tools/perf/builtin-report.c

+ 4 - 2
tools/perf/builtin-report.c

@@ -839,8 +839,10 @@ repeat:
 	if (report.header || report.header_only) {
 	if (report.header || report.header_only) {
 		perf_session__fprintf_info(session, stdout,
 		perf_session__fprintf_info(session, stdout,
 					   report.show_full_info);
 					   report.show_full_info);
-		if (report.header_only)
-			return 0;
+		if (report.header_only) {
+			ret = 0;
+			goto error;
+		}
 	} else if (use_browser == 0) {
 	} else if (use_browser == 0) {
 		fputs("# To display the perf.data header info, please use --header/--header-only options.\n#\n",
 		fputs("# To display the perf.data header info, please use --header/--header-only options.\n#\n",
 		      stdout);
 		      stdout);