浏览代码

crypto: omap-sham - remove unnecessary static in omap_sham_remove()

Remove unnecessary static on local variable dd. Such variable
is initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces the
object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a difference in the object file size.
This log is the output of the size command, before and after the code
change:

before:
   text    data     bss     dec     hex filename
  26135   11944     128   38207    953f drivers/crypto/omap-sham.o

after:
   text    data     bss     dec     hex filename
  26084   11856      64   38004    9474 drivers/crypto/omap-sham.o

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Gustavo A. R. Silva 8 年之前
父节点
当前提交
0588d8500b
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/crypto/omap-sham.c

+ 1 - 1
drivers/crypto/omap-sham.c

@@ -2133,7 +2133,7 @@ data_err:
 
 
 static int omap_sham_remove(struct platform_device *pdev)
 static int omap_sham_remove(struct platform_device *pdev)
 {
 {
-	static struct omap_sham_dev *dd;
+	struct omap_sham_dev *dd;
 	int i, j;
 	int i, j;
 
 
 	dd = platform_get_drvdata(pdev);
 	dd = platform_get_drvdata(pdev);