Pārlūkot izejas kodu

drm/msm/dsi: Report PHY errors only when they really occur

DSI PHY errors are falsely reported whenever a dsi error occurs. This is
because DSI_DLN0_PHY_ERR isn't only used as a status register, but also
used to mask PHY errors. Currently, we end up reading the mask bits too
and therefore always report errors.

Ignore the register mask bits and check for only the status/clear bits.

Signed-off-by: Archit Taneja <architt@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Archit Taneja 10 gadi atpakaļ
vecāks
revīzija
01199361c6
1 mainītis faili ar 5 papildinājumiem un 1 dzēšanām
  1. 5 1
      drivers/gpu/drm/msm/dsi/dsi_host.c

+ 5 - 1
drivers/gpu/drm/msm/dsi/dsi_host.c

@@ -1276,7 +1276,11 @@ static void dsi_dln0_phy_err(struct msm_dsi_host *msm_host)
 
 
 	status = dsi_read(msm_host, REG_DSI_DLN0_PHY_ERR);
 	status = dsi_read(msm_host, REG_DSI_DLN0_PHY_ERR);
 
 
-	if (status) {
+	if (status & (DSI_DLN0_PHY_ERR_DLN0_ERR_ESC |
+			DSI_DLN0_PHY_ERR_DLN0_ERR_SYNC_ESC |
+			DSI_DLN0_PHY_ERR_DLN0_ERR_CONTROL |
+			DSI_DLN0_PHY_ERR_DLN0_ERR_CONTENTION_LP0 |
+			DSI_DLN0_PHY_ERR_DLN0_ERR_CONTENTION_LP1)) {
 		dsi_write(msm_host, REG_DSI_DLN0_PHY_ERR, status);
 		dsi_write(msm_host, REG_DSI_DLN0_PHY_ERR, status);
 		msm_host->err_work_state |= DSI_ERR_STATE_DLN0_PHY;
 		msm_host->err_work_state |= DSI_ERR_STATE_DLN0_PHY;
 	}
 	}