浏览代码

media: i2c: mt9t11x: Fix unused return variable

drivers/media/i2c/mt9t11x.c:864:5-8: Unneeded variable: "ret". Return
"0" on line 872

Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

The actual fix though is to properly propagate the return value to the
caller.

Fixes: 0cc74f4fcf2b ("media: i2c: Add Aptina mt9t11x sensor driver")
Signed-off-by: Benoit Parrot <bparrot@ti.com>
Benoit Parrot 7 年之前
父节点
当前提交
010fab93f6
共有 1 个文件被更改,包括 5 次插入3 次删除
  1. 5 3
      drivers/media/i2c/mt9t11x.c

+ 5 - 3
drivers/media/i2c/mt9t11x.c

@@ -861,13 +861,15 @@ static unsigned int mt9t11x_pll_calc_params(struct mt9t11x_priv *priv)
 
 
 static int mt9t11x_sysctl_startup(const struct i2c_client *client)
 static int mt9t11x_sysctl_startup(const struct i2c_client *client)
 {
 {
-	int ret = 0;
+	int ret;
 
 
 	/* reset */
 	/* reset */
-	mt9t11x_reset(client);
+	ret = mt9t11x_reset(client);
+	if (ret < 0)
+		return ret;
 
 
 	/* Setup PLL */
 	/* Setup PLL */
-	mt9t11x_pll_setup_pll(client);
+	ret = mt9t11x_pll_setup_pll(client);
 
 
 	return ret;
 	return ret;
 }
 }