12345678910111213141516171819202122232425262728293031323334353637383940 |
- From 050f09a5e16a935be4a4770f59f2a7ff977fc088 Mon Sep 17 00:00:00 2001
- From: Lidong Chen <lidong.chen@oracle.com>
- Date: Wed, 29 Jan 2025 06:48:38 +0000
- Subject: [PATCH] osdep/unix/getroot: Fix potential underflow
- The entry_len is initialized in grub_find_root_devices_from_mountinfo()
- to 0 before the while loop iterates through /proc/self/mountinfo. If the
- file is empty or contains only invalid entries entry_len remains
- 0 causing entry_len - 1 in the subsequent for loop initialization
- to underflow. To prevent this add a check to ensure entry_len > 0 before
- entering the for loop.
- Fixes: CID 473877
- Signed-off-by: Lidong Chen <lidong.chen@oracle.com>
- Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
- Reviewed-by: Ross Philipson <ross.philipson@oracle.com>
- Upstream: 66733f7c7dae889861ea3ef3ec0710811486019e
- Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
- ---
- grub-core/osdep/linux/getroot.c | 3 +++
- 1 file changed, 3 insertions(+)
- diff --git a/grub-core/osdep/linux/getroot.c b/grub-core/osdep/linux/getroot.c
- index 7dd775d2a..527d4f0c5 100644
- --- a/grub-core/osdep/linux/getroot.c
- +++ b/grub-core/osdep/linux/getroot.c
- @@ -484,6 +484,9 @@ again:
- }
- }
-
- + if (!entry_len)
- + goto out;
- +
- /* Now scan visible mounts for the ones we're interested in. */
- for (i = entry_len - 1; i >= 0; i--)
- {
- --
- 2.50.1
|