devmap.c 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520
  1. /* Copyright (c) 2017 Covalent IO, Inc. http://covalent.io
  2. *
  3. * This program is free software; you can redistribute it and/or
  4. * modify it under the terms of version 2 of the GNU General Public
  5. * License as published by the Free Software Foundation.
  6. *
  7. * This program is distributed in the hope that it will be useful, but
  8. * WITHOUT ANY WARRANTY; without even the implied warranty of
  9. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  10. * General Public License for more details.
  11. */
  12. /* Devmaps primary use is as a backend map for XDP BPF helper call
  13. * bpf_redirect_map(). Because XDP is mostly concerned with performance we
  14. * spent some effort to ensure the datapath with redirect maps does not use
  15. * any locking. This is a quick note on the details.
  16. *
  17. * We have three possible paths to get into the devmap control plane bpf
  18. * syscalls, bpf programs, and driver side xmit/flush operations. A bpf syscall
  19. * will invoke an update, delete, or lookup operation. To ensure updates and
  20. * deletes appear atomic from the datapath side xchg() is used to modify the
  21. * netdev_map array. Then because the datapath does a lookup into the netdev_map
  22. * array (read-only) from an RCU critical section we use call_rcu() to wait for
  23. * an rcu grace period before free'ing the old data structures. This ensures the
  24. * datapath always has a valid copy. However, the datapath does a "flush"
  25. * operation that pushes any pending packets in the driver outside the RCU
  26. * critical section. Each bpf_dtab_netdev tracks these pending operations using
  27. * an atomic per-cpu bitmap. The bpf_dtab_netdev object will not be destroyed
  28. * until all bits are cleared indicating outstanding flush operations have
  29. * completed.
  30. *
  31. * BPF syscalls may race with BPF program calls on any of the update, delete
  32. * or lookup operations. As noted above the xchg() operation also keep the
  33. * netdev_map consistent in this case. From the devmap side BPF programs
  34. * calling into these operations are the same as multiple user space threads
  35. * making system calls.
  36. *
  37. * Finally, any of the above may race with a netdev_unregister notifier. The
  38. * unregister notifier must search for net devices in the map structure that
  39. * contain a reference to the net device and remove them. This is a two step
  40. * process (a) dereference the bpf_dtab_netdev object in netdev_map and (b)
  41. * check to see if the ifindex is the same as the net_device being removed.
  42. * When removing the dev a cmpxchg() is used to ensure the correct dev is
  43. * removed, in the case of a concurrent update or delete operation it is
  44. * possible that the initially referenced dev is no longer in the map. As the
  45. * notifier hook walks the map we know that new dev references can not be
  46. * added by the user because core infrastructure ensures dev_get_by_index()
  47. * calls will fail at this point.
  48. */
  49. #include <linux/bpf.h>
  50. #include <net/xdp.h>
  51. #include <linux/filter.h>
  52. #include <trace/events/xdp.h>
  53. #define DEV_CREATE_FLAG_MASK \
  54. (BPF_F_NUMA_NODE | BPF_F_RDONLY | BPF_F_WRONLY)
  55. #define DEV_MAP_BULK_SIZE 16
  56. struct xdp_bulk_queue {
  57. struct xdp_frame *q[DEV_MAP_BULK_SIZE];
  58. struct net_device *dev_rx;
  59. unsigned int count;
  60. };
  61. struct bpf_dtab_netdev {
  62. struct net_device *dev; /* must be first member, due to tracepoint */
  63. struct bpf_dtab *dtab;
  64. unsigned int bit;
  65. struct xdp_bulk_queue __percpu *bulkq;
  66. struct rcu_head rcu;
  67. };
  68. struct bpf_dtab {
  69. struct bpf_map map;
  70. struct bpf_dtab_netdev **netdev_map;
  71. unsigned long __percpu *flush_needed;
  72. struct list_head list;
  73. };
  74. static DEFINE_SPINLOCK(dev_map_lock);
  75. static LIST_HEAD(dev_map_list);
  76. static u64 dev_map_bitmap_size(const union bpf_attr *attr)
  77. {
  78. return BITS_TO_LONGS((u64) attr->max_entries) * sizeof(unsigned long);
  79. }
  80. static struct bpf_map *dev_map_alloc(union bpf_attr *attr)
  81. {
  82. struct bpf_dtab *dtab;
  83. int err = -EINVAL;
  84. u64 cost;
  85. if (!capable(CAP_NET_ADMIN))
  86. return ERR_PTR(-EPERM);
  87. /* check sanity of attributes */
  88. if (attr->max_entries == 0 || attr->key_size != 4 ||
  89. attr->value_size != 4 || attr->map_flags & ~DEV_CREATE_FLAG_MASK)
  90. return ERR_PTR(-EINVAL);
  91. dtab = kzalloc(sizeof(*dtab), GFP_USER);
  92. if (!dtab)
  93. return ERR_PTR(-ENOMEM);
  94. bpf_map_init_from_attr(&dtab->map, attr);
  95. /* make sure page count doesn't overflow */
  96. cost = (u64) dtab->map.max_entries * sizeof(struct bpf_dtab_netdev *);
  97. cost += dev_map_bitmap_size(attr) * num_possible_cpus();
  98. if (cost >= U32_MAX - PAGE_SIZE)
  99. goto free_dtab;
  100. dtab->map.pages = round_up(cost, PAGE_SIZE) >> PAGE_SHIFT;
  101. /* if map size is larger than memlock limit, reject it early */
  102. err = bpf_map_precharge_memlock(dtab->map.pages);
  103. if (err)
  104. goto free_dtab;
  105. err = -ENOMEM;
  106. /* A per cpu bitfield with a bit per possible net device */
  107. dtab->flush_needed = __alloc_percpu_gfp(dev_map_bitmap_size(attr),
  108. __alignof__(unsigned long),
  109. GFP_KERNEL | __GFP_NOWARN);
  110. if (!dtab->flush_needed)
  111. goto free_dtab;
  112. dtab->netdev_map = bpf_map_area_alloc(dtab->map.max_entries *
  113. sizeof(struct bpf_dtab_netdev *),
  114. dtab->map.numa_node);
  115. if (!dtab->netdev_map)
  116. goto free_dtab;
  117. spin_lock(&dev_map_lock);
  118. list_add_tail_rcu(&dtab->list, &dev_map_list);
  119. spin_unlock(&dev_map_lock);
  120. return &dtab->map;
  121. free_dtab:
  122. free_percpu(dtab->flush_needed);
  123. kfree(dtab);
  124. return ERR_PTR(err);
  125. }
  126. static void dev_map_free(struct bpf_map *map)
  127. {
  128. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  129. int i, cpu;
  130. /* At this point bpf_prog->aux->refcnt == 0 and this map->refcnt == 0,
  131. * so the programs (can be more than one that used this map) were
  132. * disconnected from events. Wait for outstanding critical sections in
  133. * these programs to complete. The rcu critical section only guarantees
  134. * no further reads against netdev_map. It does __not__ ensure pending
  135. * flush operations (if any) are complete.
  136. */
  137. spin_lock(&dev_map_lock);
  138. list_del_rcu(&dtab->list);
  139. spin_unlock(&dev_map_lock);
  140. synchronize_rcu();
  141. /* To ensure all pending flush operations have completed wait for flush
  142. * bitmap to indicate all flush_needed bits to be zero on _all_ cpus.
  143. * Because the above synchronize_rcu() ensures the map is disconnected
  144. * from the program we can assume no new bits will be set.
  145. */
  146. for_each_online_cpu(cpu) {
  147. unsigned long *bitmap = per_cpu_ptr(dtab->flush_needed, cpu);
  148. while (!bitmap_empty(bitmap, dtab->map.max_entries))
  149. cond_resched();
  150. }
  151. for (i = 0; i < dtab->map.max_entries; i++) {
  152. struct bpf_dtab_netdev *dev;
  153. dev = dtab->netdev_map[i];
  154. if (!dev)
  155. continue;
  156. dev_put(dev->dev);
  157. kfree(dev);
  158. }
  159. free_percpu(dtab->flush_needed);
  160. bpf_map_area_free(dtab->netdev_map);
  161. kfree(dtab);
  162. }
  163. static int dev_map_get_next_key(struct bpf_map *map, void *key, void *next_key)
  164. {
  165. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  166. u32 index = key ? *(u32 *)key : U32_MAX;
  167. u32 *next = next_key;
  168. if (index >= dtab->map.max_entries) {
  169. *next = 0;
  170. return 0;
  171. }
  172. if (index == dtab->map.max_entries - 1)
  173. return -ENOENT;
  174. *next = index + 1;
  175. return 0;
  176. }
  177. void __dev_map_insert_ctx(struct bpf_map *map, u32 bit)
  178. {
  179. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  180. unsigned long *bitmap = this_cpu_ptr(dtab->flush_needed);
  181. __set_bit(bit, bitmap);
  182. }
  183. static int bq_xmit_all(struct bpf_dtab_netdev *obj,
  184. struct xdp_bulk_queue *bq, u32 flags)
  185. {
  186. struct net_device *dev = obj->dev;
  187. int sent = 0, drops = 0, err = 0;
  188. int i;
  189. if (unlikely(!bq->count))
  190. return 0;
  191. for (i = 0; i < bq->count; i++) {
  192. struct xdp_frame *xdpf = bq->q[i];
  193. prefetch(xdpf);
  194. }
  195. sent = dev->netdev_ops->ndo_xdp_xmit(dev, bq->count, bq->q, flags);
  196. if (sent < 0) {
  197. err = sent;
  198. sent = 0;
  199. goto error;
  200. }
  201. drops = bq->count - sent;
  202. out:
  203. bq->count = 0;
  204. trace_xdp_devmap_xmit(&obj->dtab->map, obj->bit,
  205. sent, drops, bq->dev_rx, dev, err);
  206. bq->dev_rx = NULL;
  207. return 0;
  208. error:
  209. /* If ndo_xdp_xmit fails with an errno, no frames have been
  210. * xmit'ed and it's our responsibility to them free all.
  211. */
  212. for (i = 0; i < bq->count; i++) {
  213. struct xdp_frame *xdpf = bq->q[i];
  214. /* RX path under NAPI protection, can return frames faster */
  215. xdp_return_frame_rx_napi(xdpf);
  216. drops++;
  217. }
  218. goto out;
  219. }
  220. /* __dev_map_flush is called from xdp_do_flush_map() which _must_ be signaled
  221. * from the driver before returning from its napi->poll() routine. The poll()
  222. * routine is called either from busy_poll context or net_rx_action signaled
  223. * from NET_RX_SOFTIRQ. Either way the poll routine must complete before the
  224. * net device can be torn down. On devmap tear down we ensure the ctx bitmap
  225. * is zeroed before completing to ensure all flush operations have completed.
  226. */
  227. void __dev_map_flush(struct bpf_map *map)
  228. {
  229. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  230. unsigned long *bitmap = this_cpu_ptr(dtab->flush_needed);
  231. u32 bit;
  232. for_each_set_bit(bit, bitmap, map->max_entries) {
  233. struct bpf_dtab_netdev *dev = READ_ONCE(dtab->netdev_map[bit]);
  234. struct xdp_bulk_queue *bq;
  235. /* This is possible if the dev entry is removed by user space
  236. * between xdp redirect and flush op.
  237. */
  238. if (unlikely(!dev))
  239. continue;
  240. __clear_bit(bit, bitmap);
  241. bq = this_cpu_ptr(dev->bulkq);
  242. bq_xmit_all(dev, bq, XDP_XMIT_FLUSH);
  243. }
  244. }
  245. /* rcu_read_lock (from syscall and BPF contexts) ensures that if a delete and/or
  246. * update happens in parallel here a dev_put wont happen until after reading the
  247. * ifindex.
  248. */
  249. struct bpf_dtab_netdev *__dev_map_lookup_elem(struct bpf_map *map, u32 key)
  250. {
  251. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  252. struct bpf_dtab_netdev *obj;
  253. if (key >= map->max_entries)
  254. return NULL;
  255. obj = READ_ONCE(dtab->netdev_map[key]);
  256. return obj;
  257. }
  258. /* Runs under RCU-read-side, plus in softirq under NAPI protection.
  259. * Thus, safe percpu variable access.
  260. */
  261. static int bq_enqueue(struct bpf_dtab_netdev *obj, struct xdp_frame *xdpf,
  262. struct net_device *dev_rx)
  263. {
  264. struct xdp_bulk_queue *bq = this_cpu_ptr(obj->bulkq);
  265. if (unlikely(bq->count == DEV_MAP_BULK_SIZE))
  266. bq_xmit_all(obj, bq, 0);
  267. /* Ingress dev_rx will be the same for all xdp_frame's in
  268. * bulk_queue, because bq stored per-CPU and must be flushed
  269. * from net_device drivers NAPI func end.
  270. */
  271. if (!bq->dev_rx)
  272. bq->dev_rx = dev_rx;
  273. bq->q[bq->count++] = xdpf;
  274. return 0;
  275. }
  276. int dev_map_enqueue(struct bpf_dtab_netdev *dst, struct xdp_buff *xdp,
  277. struct net_device *dev_rx)
  278. {
  279. struct net_device *dev = dst->dev;
  280. struct xdp_frame *xdpf;
  281. if (!dev->netdev_ops->ndo_xdp_xmit)
  282. return -EOPNOTSUPP;
  283. xdpf = convert_to_xdp_frame(xdp);
  284. if (unlikely(!xdpf))
  285. return -EOVERFLOW;
  286. return bq_enqueue(dst, xdpf, dev_rx);
  287. }
  288. static void *dev_map_lookup_elem(struct bpf_map *map, void *key)
  289. {
  290. struct bpf_dtab_netdev *obj = __dev_map_lookup_elem(map, *(u32 *)key);
  291. struct net_device *dev = obj ? obj->dev : NULL;
  292. return dev ? &dev->ifindex : NULL;
  293. }
  294. static void dev_map_flush_old(struct bpf_dtab_netdev *dev)
  295. {
  296. if (dev->dev->netdev_ops->ndo_xdp_xmit) {
  297. struct xdp_bulk_queue *bq;
  298. unsigned long *bitmap;
  299. int cpu;
  300. for_each_online_cpu(cpu) {
  301. bitmap = per_cpu_ptr(dev->dtab->flush_needed, cpu);
  302. __clear_bit(dev->bit, bitmap);
  303. bq = per_cpu_ptr(dev->bulkq, cpu);
  304. bq_xmit_all(dev, bq, XDP_XMIT_FLUSH);
  305. }
  306. }
  307. }
  308. static void __dev_map_entry_free(struct rcu_head *rcu)
  309. {
  310. struct bpf_dtab_netdev *dev;
  311. dev = container_of(rcu, struct bpf_dtab_netdev, rcu);
  312. dev_map_flush_old(dev);
  313. free_percpu(dev->bulkq);
  314. dev_put(dev->dev);
  315. kfree(dev);
  316. }
  317. static int dev_map_delete_elem(struct bpf_map *map, void *key)
  318. {
  319. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  320. struct bpf_dtab_netdev *old_dev;
  321. int k = *(u32 *)key;
  322. if (k >= map->max_entries)
  323. return -EINVAL;
  324. /* Use call_rcu() here to ensure any rcu critical sections have
  325. * completed, but this does not guarantee a flush has happened
  326. * yet. Because driver side rcu_read_lock/unlock only protects the
  327. * running XDP program. However, for pending flush operations the
  328. * dev and ctx are stored in another per cpu map. And additionally,
  329. * the driver tear down ensures all soft irqs are complete before
  330. * removing the net device in the case of dev_put equals zero.
  331. */
  332. old_dev = xchg(&dtab->netdev_map[k], NULL);
  333. if (old_dev)
  334. call_rcu(&old_dev->rcu, __dev_map_entry_free);
  335. return 0;
  336. }
  337. static int dev_map_update_elem(struct bpf_map *map, void *key, void *value,
  338. u64 map_flags)
  339. {
  340. struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
  341. struct net *net = current->nsproxy->net_ns;
  342. gfp_t gfp = GFP_ATOMIC | __GFP_NOWARN;
  343. struct bpf_dtab_netdev *dev, *old_dev;
  344. u32 i = *(u32 *)key;
  345. u32 ifindex = *(u32 *)value;
  346. if (unlikely(map_flags > BPF_EXIST))
  347. return -EINVAL;
  348. if (unlikely(i >= dtab->map.max_entries))
  349. return -E2BIG;
  350. if (unlikely(map_flags == BPF_NOEXIST))
  351. return -EEXIST;
  352. if (!ifindex) {
  353. dev = NULL;
  354. } else {
  355. dev = kmalloc_node(sizeof(*dev), gfp, map->numa_node);
  356. if (!dev)
  357. return -ENOMEM;
  358. dev->bulkq = __alloc_percpu_gfp(sizeof(*dev->bulkq),
  359. sizeof(void *), gfp);
  360. if (!dev->bulkq) {
  361. kfree(dev);
  362. return -ENOMEM;
  363. }
  364. dev->dev = dev_get_by_index(net, ifindex);
  365. if (!dev->dev) {
  366. free_percpu(dev->bulkq);
  367. kfree(dev);
  368. return -EINVAL;
  369. }
  370. dev->bit = i;
  371. dev->dtab = dtab;
  372. }
  373. /* Use call_rcu() here to ensure rcu critical sections have completed
  374. * Remembering the driver side flush operation will happen before the
  375. * net device is removed.
  376. */
  377. old_dev = xchg(&dtab->netdev_map[i], dev);
  378. if (old_dev)
  379. call_rcu(&old_dev->rcu, __dev_map_entry_free);
  380. return 0;
  381. }
  382. const struct bpf_map_ops dev_map_ops = {
  383. .map_alloc = dev_map_alloc,
  384. .map_free = dev_map_free,
  385. .map_get_next_key = dev_map_get_next_key,
  386. .map_lookup_elem = dev_map_lookup_elem,
  387. .map_update_elem = dev_map_update_elem,
  388. .map_delete_elem = dev_map_delete_elem,
  389. };
  390. static int dev_map_notification(struct notifier_block *notifier,
  391. ulong event, void *ptr)
  392. {
  393. struct net_device *netdev = netdev_notifier_info_to_dev(ptr);
  394. struct bpf_dtab *dtab;
  395. int i;
  396. switch (event) {
  397. case NETDEV_UNREGISTER:
  398. /* This rcu_read_lock/unlock pair is needed because
  399. * dev_map_list is an RCU list AND to ensure a delete
  400. * operation does not free a netdev_map entry while we
  401. * are comparing it against the netdev being unregistered.
  402. */
  403. rcu_read_lock();
  404. list_for_each_entry_rcu(dtab, &dev_map_list, list) {
  405. for (i = 0; i < dtab->map.max_entries; i++) {
  406. struct bpf_dtab_netdev *dev, *odev;
  407. dev = READ_ONCE(dtab->netdev_map[i]);
  408. if (!dev ||
  409. dev->dev->ifindex != netdev->ifindex)
  410. continue;
  411. odev = cmpxchg(&dtab->netdev_map[i], dev, NULL);
  412. if (dev == odev)
  413. call_rcu(&dev->rcu,
  414. __dev_map_entry_free);
  415. }
  416. }
  417. rcu_read_unlock();
  418. break;
  419. default:
  420. break;
  421. }
  422. return NOTIFY_OK;
  423. }
  424. static struct notifier_block dev_map_notifier = {
  425. .notifier_call = dev_map_notification,
  426. };
  427. static int __init dev_map_init(void)
  428. {
  429. /* Assure tracepoint shadow struct _bpf_dtab_netdev is in sync */
  430. BUILD_BUG_ON(offsetof(struct bpf_dtab_netdev, dev) !=
  431. offsetof(struct _bpf_dtab_netdev, dev));
  432. register_netdevice_notifier(&dev_map_notifier);
  433. return 0;
  434. }
  435. subsys_initcall(dev_map_init);