intel_dvo.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549
  1. /*
  2. * Copyright 2006 Dave Airlie <airlied@linux.ie>
  3. * Copyright © 2006-2007 Intel Corporation
  4. *
  5. * Permission is hereby granted, free of charge, to any person obtaining a
  6. * copy of this software and associated documentation files (the "Software"),
  7. * to deal in the Software without restriction, including without limitation
  8. * the rights to use, copy, modify, merge, publish, distribute, sublicense,
  9. * and/or sell copies of the Software, and to permit persons to whom the
  10. * Software is furnished to do so, subject to the following conditions:
  11. *
  12. * The above copyright notice and this permission notice (including the next
  13. * paragraph) shall be included in all copies or substantial portions of the
  14. * Software.
  15. *
  16. * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17. * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18. * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
  19. * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20. * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  21. * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  22. * DEALINGS IN THE SOFTWARE.
  23. *
  24. * Authors:
  25. * Eric Anholt <eric@anholt.net>
  26. */
  27. #include <linux/i2c.h>
  28. #include <linux/slab.h>
  29. #include <drm/drmP.h>
  30. #include <drm/drm_atomic_helper.h>
  31. #include <drm/drm_crtc.h>
  32. #include "intel_drv.h"
  33. #include <drm/i915_drm.h>
  34. #include "i915_drv.h"
  35. #include "dvo.h"
  36. #define SIL164_ADDR 0x38
  37. #define CH7xxx_ADDR 0x76
  38. #define TFP410_ADDR 0x38
  39. #define NS2501_ADDR 0x38
  40. static const struct intel_dvo_device intel_dvo_devices[] = {
  41. {
  42. .type = INTEL_DVO_CHIP_TMDS,
  43. .name = "sil164",
  44. .dvo_reg = DVOC,
  45. .dvo_srcdim_reg = DVOC_SRCDIM,
  46. .slave_addr = SIL164_ADDR,
  47. .dev_ops = &sil164_ops,
  48. },
  49. {
  50. .type = INTEL_DVO_CHIP_TMDS,
  51. .name = "ch7xxx",
  52. .dvo_reg = DVOC,
  53. .dvo_srcdim_reg = DVOC_SRCDIM,
  54. .slave_addr = CH7xxx_ADDR,
  55. .dev_ops = &ch7xxx_ops,
  56. },
  57. {
  58. .type = INTEL_DVO_CHIP_TMDS,
  59. .name = "ch7xxx",
  60. .dvo_reg = DVOC,
  61. .dvo_srcdim_reg = DVOC_SRCDIM,
  62. .slave_addr = 0x75, /* For some ch7010 */
  63. .dev_ops = &ch7xxx_ops,
  64. },
  65. {
  66. .type = INTEL_DVO_CHIP_LVDS,
  67. .name = "ivch",
  68. .dvo_reg = DVOA,
  69. .dvo_srcdim_reg = DVOA_SRCDIM,
  70. .slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
  71. .dev_ops = &ivch_ops,
  72. },
  73. {
  74. .type = INTEL_DVO_CHIP_TMDS,
  75. .name = "tfp410",
  76. .dvo_reg = DVOC,
  77. .dvo_srcdim_reg = DVOC_SRCDIM,
  78. .slave_addr = TFP410_ADDR,
  79. .dev_ops = &tfp410_ops,
  80. },
  81. {
  82. .type = INTEL_DVO_CHIP_LVDS,
  83. .name = "ch7017",
  84. .dvo_reg = DVOC,
  85. .dvo_srcdim_reg = DVOC_SRCDIM,
  86. .slave_addr = 0x75,
  87. .gpio = GMBUS_PIN_DPB,
  88. .dev_ops = &ch7017_ops,
  89. },
  90. {
  91. .type = INTEL_DVO_CHIP_TMDS,
  92. .name = "ns2501",
  93. .dvo_reg = DVOB,
  94. .dvo_srcdim_reg = DVOB_SRCDIM,
  95. .slave_addr = NS2501_ADDR,
  96. .dev_ops = &ns2501_ops,
  97. }
  98. };
  99. struct intel_dvo {
  100. struct intel_encoder base;
  101. struct intel_dvo_device dev;
  102. struct intel_connector *attached_connector;
  103. bool panel_wants_dither;
  104. };
  105. static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
  106. {
  107. return container_of(encoder, struct intel_dvo, base);
  108. }
  109. static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
  110. {
  111. return enc_to_dvo(intel_attached_encoder(connector));
  112. }
  113. static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
  114. {
  115. struct drm_device *dev = connector->base.dev;
  116. struct drm_i915_private *dev_priv = to_i915(dev);
  117. struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
  118. u32 tmp;
  119. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  120. if (!(tmp & DVO_ENABLE))
  121. return false;
  122. return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
  123. }
  124. static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
  125. enum pipe *pipe)
  126. {
  127. struct drm_device *dev = encoder->base.dev;
  128. struct drm_i915_private *dev_priv = to_i915(dev);
  129. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  130. u32 tmp;
  131. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  132. if (!(tmp & DVO_ENABLE))
  133. return false;
  134. *pipe = PORT_TO_PIPE(tmp);
  135. return true;
  136. }
  137. static void intel_dvo_get_config(struct intel_encoder *encoder,
  138. struct intel_crtc_state *pipe_config)
  139. {
  140. struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
  141. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  142. u32 tmp, flags = 0;
  143. pipe_config->output_types |= BIT(INTEL_OUTPUT_DVO);
  144. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  145. if (tmp & DVO_HSYNC_ACTIVE_HIGH)
  146. flags |= DRM_MODE_FLAG_PHSYNC;
  147. else
  148. flags |= DRM_MODE_FLAG_NHSYNC;
  149. if (tmp & DVO_VSYNC_ACTIVE_HIGH)
  150. flags |= DRM_MODE_FLAG_PVSYNC;
  151. else
  152. flags |= DRM_MODE_FLAG_NVSYNC;
  153. pipe_config->base.adjusted_mode.flags |= flags;
  154. pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
  155. }
  156. static void intel_disable_dvo(struct intel_encoder *encoder,
  157. const struct intel_crtc_state *old_crtc_state,
  158. const struct drm_connector_state *old_conn_state)
  159. {
  160. struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
  161. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  162. i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
  163. u32 temp = I915_READ(dvo_reg);
  164. intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
  165. I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
  166. I915_READ(dvo_reg);
  167. }
  168. static void intel_enable_dvo(struct intel_encoder *encoder,
  169. const struct intel_crtc_state *pipe_config,
  170. const struct drm_connector_state *conn_state)
  171. {
  172. struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
  173. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  174. i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
  175. u32 temp = I915_READ(dvo_reg);
  176. intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
  177. &pipe_config->base.mode,
  178. &pipe_config->base.adjusted_mode);
  179. I915_WRITE(dvo_reg, temp | DVO_ENABLE);
  180. I915_READ(dvo_reg);
  181. intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
  182. }
  183. static enum drm_mode_status
  184. intel_dvo_mode_valid(struct drm_connector *connector,
  185. struct drm_display_mode *mode)
  186. {
  187. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  188. const struct drm_display_mode *fixed_mode =
  189. to_intel_connector(connector)->panel.fixed_mode;
  190. int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
  191. int target_clock = mode->clock;
  192. if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
  193. return MODE_NO_DBLESCAN;
  194. /* XXX: Validate clock range */
  195. if (fixed_mode) {
  196. if (mode->hdisplay > fixed_mode->hdisplay)
  197. return MODE_PANEL;
  198. if (mode->vdisplay > fixed_mode->vdisplay)
  199. return MODE_PANEL;
  200. target_clock = fixed_mode->clock;
  201. }
  202. if (target_clock > max_dotclk)
  203. return MODE_CLOCK_HIGH;
  204. return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
  205. }
  206. static bool intel_dvo_compute_config(struct intel_encoder *encoder,
  207. struct intel_crtc_state *pipe_config,
  208. struct drm_connector_state *conn_state)
  209. {
  210. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  211. const struct drm_display_mode *fixed_mode =
  212. intel_dvo->attached_connector->panel.fixed_mode;
  213. struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
  214. /* If we have timings from the BIOS for the panel, put them in
  215. * to the adjusted mode. The CRTC will be set up for this mode,
  216. * with the panel scaling set up to source from the H/VDisplay
  217. * of the original mode.
  218. */
  219. if (fixed_mode)
  220. intel_fixed_panel_mode(fixed_mode, adjusted_mode);
  221. return true;
  222. }
  223. static void intel_dvo_pre_enable(struct intel_encoder *encoder,
  224. const struct intel_crtc_state *pipe_config,
  225. const struct drm_connector_state *conn_state)
  226. {
  227. struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
  228. struct intel_crtc *crtc = to_intel_crtc(pipe_config->base.crtc);
  229. const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
  230. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  231. int pipe = crtc->pipe;
  232. u32 dvo_val;
  233. i915_reg_t dvo_reg = intel_dvo->dev.dvo_reg;
  234. i915_reg_t dvo_srcdim_reg = intel_dvo->dev.dvo_srcdim_reg;
  235. /* Save the data order, since I don't know what it should be set to. */
  236. dvo_val = I915_READ(dvo_reg) &
  237. (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
  238. dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
  239. DVO_BLANK_ACTIVE_HIGH;
  240. if (pipe == 1)
  241. dvo_val |= DVO_PIPE_B_SELECT;
  242. dvo_val |= DVO_PIPE_STALL;
  243. if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
  244. dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
  245. if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
  246. dvo_val |= DVO_VSYNC_ACTIVE_HIGH;
  247. /*I915_WRITE(DVOB_SRCDIM,
  248. (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
  249. (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
  250. I915_WRITE(dvo_srcdim_reg,
  251. (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
  252. (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
  253. /*I915_WRITE(DVOB, dvo_val);*/
  254. I915_WRITE(dvo_reg, dvo_val);
  255. }
  256. /**
  257. * Detect the output connection on our DVO device.
  258. *
  259. * Unimplemented.
  260. */
  261. static enum drm_connector_status
  262. intel_dvo_detect(struct drm_connector *connector, bool force)
  263. {
  264. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  265. DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
  266. connector->base.id, connector->name);
  267. return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
  268. }
  269. static int intel_dvo_get_modes(struct drm_connector *connector)
  270. {
  271. struct drm_i915_private *dev_priv = to_i915(connector->dev);
  272. const struct drm_display_mode *fixed_mode =
  273. to_intel_connector(connector)->panel.fixed_mode;
  274. /* We should probably have an i2c driver get_modes function for those
  275. * devices which will have a fixed set of modes determined by the chip
  276. * (TV-out, for example), but for now with just TMDS and LVDS,
  277. * that's not the case.
  278. */
  279. intel_ddc_get_modes(connector,
  280. intel_gmbus_get_adapter(dev_priv, GMBUS_PIN_DPC));
  281. if (!list_empty(&connector->probed_modes))
  282. return 1;
  283. if (fixed_mode) {
  284. struct drm_display_mode *mode;
  285. mode = drm_mode_duplicate(connector->dev, fixed_mode);
  286. if (mode) {
  287. drm_mode_probed_add(connector, mode);
  288. return 1;
  289. }
  290. }
  291. return 0;
  292. }
  293. static void intel_dvo_destroy(struct drm_connector *connector)
  294. {
  295. drm_connector_cleanup(connector);
  296. intel_panel_fini(&to_intel_connector(connector)->panel);
  297. kfree(connector);
  298. }
  299. static const struct drm_connector_funcs intel_dvo_connector_funcs = {
  300. .detect = intel_dvo_detect,
  301. .late_register = intel_connector_register,
  302. .early_unregister = intel_connector_unregister,
  303. .destroy = intel_dvo_destroy,
  304. .fill_modes = drm_helper_probe_single_connector_modes,
  305. .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
  306. .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
  307. };
  308. static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
  309. .mode_valid = intel_dvo_mode_valid,
  310. .get_modes = intel_dvo_get_modes,
  311. };
  312. static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
  313. {
  314. struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
  315. if (intel_dvo->dev.dev_ops->destroy)
  316. intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);
  317. intel_encoder_destroy(encoder);
  318. }
  319. static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
  320. .destroy = intel_dvo_enc_destroy,
  321. };
  322. /**
  323. * Attempts to get a fixed panel timing for LVDS (currently only the i830).
  324. *
  325. * Other chips with DVO LVDS will need to extend this to deal with the LVDS
  326. * chip being on DVOB/C and having multiple pipes.
  327. */
  328. static struct drm_display_mode *
  329. intel_dvo_get_current_mode(struct intel_encoder *encoder)
  330. {
  331. struct drm_display_mode *mode;
  332. mode = intel_encoder_current_mode(encoder);
  333. if (mode) {
  334. DRM_DEBUG_KMS("using current (BIOS) mode: ");
  335. drm_mode_debug_printmodeline(mode);
  336. mode->type |= DRM_MODE_TYPE_PREFERRED;
  337. }
  338. return mode;
  339. }
  340. static enum port intel_dvo_port(i915_reg_t dvo_reg)
  341. {
  342. if (i915_mmio_reg_equal(dvo_reg, DVOA))
  343. return PORT_A;
  344. else if (i915_mmio_reg_equal(dvo_reg, DVOB))
  345. return PORT_B;
  346. else
  347. return PORT_C;
  348. }
  349. void intel_dvo_init(struct drm_i915_private *dev_priv)
  350. {
  351. struct intel_encoder *intel_encoder;
  352. struct intel_dvo *intel_dvo;
  353. struct intel_connector *intel_connector;
  354. int i;
  355. int encoder_type = DRM_MODE_ENCODER_NONE;
  356. intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
  357. if (!intel_dvo)
  358. return;
  359. intel_connector = intel_connector_alloc();
  360. if (!intel_connector) {
  361. kfree(intel_dvo);
  362. return;
  363. }
  364. intel_dvo->attached_connector = intel_connector;
  365. intel_encoder = &intel_dvo->base;
  366. intel_encoder->disable = intel_disable_dvo;
  367. intel_encoder->enable = intel_enable_dvo;
  368. intel_encoder->get_hw_state = intel_dvo_get_hw_state;
  369. intel_encoder->get_config = intel_dvo_get_config;
  370. intel_encoder->compute_config = intel_dvo_compute_config;
  371. intel_encoder->pre_enable = intel_dvo_pre_enable;
  372. intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
  373. /* Now, try to find a controller */
  374. for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
  375. struct drm_connector *connector = &intel_connector->base;
  376. const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
  377. struct i2c_adapter *i2c;
  378. int gpio;
  379. bool dvoinit;
  380. enum pipe pipe;
  381. uint32_t dpll[I915_MAX_PIPES];
  382. enum port port;
  383. /* Allow the I2C driver info to specify the GPIO to be used in
  384. * special cases, but otherwise default to what's defined
  385. * in the spec.
  386. */
  387. if (intel_gmbus_is_valid_pin(dev_priv, dvo->gpio))
  388. gpio = dvo->gpio;
  389. else if (dvo->type == INTEL_DVO_CHIP_LVDS)
  390. gpio = GMBUS_PIN_SSC;
  391. else
  392. gpio = GMBUS_PIN_DPB;
  393. /* Set up the I2C bus necessary for the chip we're probing.
  394. * It appears that everything is on GPIOE except for panels
  395. * on i830 laptops, which are on GPIOB (DVOA).
  396. */
  397. i2c = intel_gmbus_get_adapter(dev_priv, gpio);
  398. intel_dvo->dev = *dvo;
  399. /* GMBUS NAK handling seems to be unstable, hence let the
  400. * transmitter detection run in bit banging mode for now.
  401. */
  402. intel_gmbus_force_bit(i2c, true);
  403. /* ns2501 requires the DVO 2x clock before it will
  404. * respond to i2c accesses, so make sure we have
  405. * have the clock enabled before we attempt to
  406. * initialize the device.
  407. */
  408. for_each_pipe(dev_priv, pipe) {
  409. dpll[pipe] = I915_READ(DPLL(pipe));
  410. I915_WRITE(DPLL(pipe), dpll[pipe] | DPLL_DVO_2X_MODE);
  411. }
  412. dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);
  413. /* restore the DVO 2x clock state to original */
  414. for_each_pipe(dev_priv, pipe) {
  415. I915_WRITE(DPLL(pipe), dpll[pipe]);
  416. }
  417. intel_gmbus_force_bit(i2c, false);
  418. if (!dvoinit)
  419. continue;
  420. port = intel_dvo_port(dvo->dvo_reg);
  421. drm_encoder_init(&dev_priv->drm, &intel_encoder->base,
  422. &intel_dvo_enc_funcs, encoder_type,
  423. "DVO %c", port_name(port));
  424. intel_encoder->type = INTEL_OUTPUT_DVO;
  425. intel_encoder->power_domain = POWER_DOMAIN_PORT_OTHER;
  426. intel_encoder->port = port;
  427. intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
  428. switch (dvo->type) {
  429. case INTEL_DVO_CHIP_TMDS:
  430. intel_encoder->cloneable = (1 << INTEL_OUTPUT_ANALOG) |
  431. (1 << INTEL_OUTPUT_DVO);
  432. drm_connector_init(&dev_priv->drm, connector,
  433. &intel_dvo_connector_funcs,
  434. DRM_MODE_CONNECTOR_DVII);
  435. encoder_type = DRM_MODE_ENCODER_TMDS;
  436. break;
  437. case INTEL_DVO_CHIP_LVDS:
  438. intel_encoder->cloneable = 0;
  439. drm_connector_init(&dev_priv->drm, connector,
  440. &intel_dvo_connector_funcs,
  441. DRM_MODE_CONNECTOR_LVDS);
  442. encoder_type = DRM_MODE_ENCODER_LVDS;
  443. break;
  444. }
  445. drm_connector_helper_add(connector,
  446. &intel_dvo_connector_helper_funcs);
  447. connector->display_info.subpixel_order = SubPixelHorizontalRGB;
  448. connector->interlace_allowed = false;
  449. connector->doublescan_allowed = false;
  450. intel_connector_attach_encoder(intel_connector, intel_encoder);
  451. if (dvo->type == INTEL_DVO_CHIP_LVDS) {
  452. /* For our LVDS chipsets, we should hopefully be able
  453. * to dig the fixed panel mode out of the BIOS data.
  454. * However, it's in a different format from the BIOS
  455. * data on chipsets with integrated LVDS (stored in AIM
  456. * headers, likely), so for now, just get the current
  457. * mode being output through DVO.
  458. */
  459. intel_panel_init(&intel_connector->panel,
  460. intel_dvo_get_current_mode(intel_encoder),
  461. NULL, NULL);
  462. intel_dvo->panel_wants_dither = true;
  463. }
  464. return;
  465. }
  466. kfree(intel_dvo);
  467. kfree(intel_connector);
  468. }