rtc-pm8xxx.c 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566
  1. /* Copyright (c) 2010-2011, Code Aurora Forum. All rights reserved.
  2. *
  3. * This program is free software; you can redistribute it and/or modify
  4. * it under the terms of the GNU General Public License version 2 and
  5. * only version 2 as published by the Free Software Foundation.
  6. *
  7. * This program is distributed in the hope that it will be useful,
  8. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  9. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  10. * GNU General Public License for more details.
  11. */
  12. #include <linux/of.h>
  13. #include <linux/module.h>
  14. #include <linux/init.h>
  15. #include <linux/rtc.h>
  16. #include <linux/platform_device.h>
  17. #include <linux/pm.h>
  18. #include <linux/regmap.h>
  19. #include <linux/slab.h>
  20. #include <linux/spinlock.h>
  21. /* RTC Register offsets from RTC CTRL REG */
  22. #define PM8XXX_ALARM_CTRL_OFFSET 0x01
  23. #define PM8XXX_RTC_WRITE_OFFSET 0x02
  24. #define PM8XXX_RTC_READ_OFFSET 0x06
  25. #define PM8XXX_ALARM_RW_OFFSET 0x0A
  26. /* RTC_CTRL register bit fields */
  27. #define PM8xxx_RTC_ENABLE BIT(7)
  28. #define PM8xxx_RTC_ALARM_CLEAR BIT(0)
  29. #define NUM_8_BIT_RTC_REGS 0x4
  30. /**
  31. * struct pm8xxx_rtc_regs - describe RTC registers per PMIC versions
  32. * @ctrl: base address of control register
  33. * @write: base address of write register
  34. * @read: base address of read register
  35. * @alarm_ctrl: base address of alarm control register
  36. * @alarm_ctrl2: base address of alarm control2 register
  37. * @alarm_rw: base address of alarm read-write register
  38. * @alarm_en: alarm enable mask
  39. */
  40. struct pm8xxx_rtc_regs {
  41. unsigned int ctrl;
  42. unsigned int write;
  43. unsigned int read;
  44. unsigned int alarm_ctrl;
  45. unsigned int alarm_ctrl2;
  46. unsigned int alarm_rw;
  47. unsigned int alarm_en;
  48. };
  49. /**
  50. * struct pm8xxx_rtc - rtc driver internal structure
  51. * @rtc: rtc device for this driver.
  52. * @regmap: regmap used to access RTC registers
  53. * @allow_set_time: indicates whether writing to the RTC is allowed
  54. * @rtc_alarm_irq: rtc alarm irq number.
  55. * @ctrl_reg: rtc control register.
  56. * @rtc_dev: device structure.
  57. * @ctrl_reg_lock: spinlock protecting access to ctrl_reg.
  58. */
  59. struct pm8xxx_rtc {
  60. struct rtc_device *rtc;
  61. struct regmap *regmap;
  62. bool allow_set_time;
  63. int rtc_alarm_irq;
  64. const struct pm8xxx_rtc_regs *regs;
  65. struct device *rtc_dev;
  66. spinlock_t ctrl_reg_lock;
  67. };
  68. /*
  69. * Steps to write the RTC registers.
  70. * 1. Disable alarm if enabled.
  71. * 2. Disable rtc if enabled.
  72. * 3. Write 0x00 to LSB.
  73. * 4. Write Byte[1], Byte[2], Byte[3] then Byte[0].
  74. * 5. Enable rtc if disabled in step 2.
  75. * 6. Enable alarm if disabled in step 1.
  76. */
  77. static int pm8xxx_rtc_set_time(struct device *dev, struct rtc_time *tm)
  78. {
  79. int rc, i;
  80. unsigned long secs, irq_flags;
  81. u8 value[NUM_8_BIT_RTC_REGS], alarm_enabled = 0, rtc_disabled = 0;
  82. unsigned int ctrl_reg, rtc_ctrl_reg;
  83. struct pm8xxx_rtc *rtc_dd = dev_get_drvdata(dev);
  84. const struct pm8xxx_rtc_regs *regs = rtc_dd->regs;
  85. if (!rtc_dd->allow_set_time)
  86. return -EACCES;
  87. rtc_tm_to_time(tm, &secs);
  88. dev_dbg(dev, "Seconds value to be written to RTC = %lu\n", secs);
  89. for (i = 0; i < NUM_8_BIT_RTC_REGS; i++) {
  90. value[i] = secs & 0xFF;
  91. secs >>= 8;
  92. }
  93. spin_lock_irqsave(&rtc_dd->ctrl_reg_lock, irq_flags);
  94. rc = regmap_read(rtc_dd->regmap, regs->alarm_ctrl, &ctrl_reg);
  95. if (rc)
  96. goto rtc_rw_fail;
  97. if (ctrl_reg & regs->alarm_en) {
  98. alarm_enabled = 1;
  99. ctrl_reg &= ~regs->alarm_en;
  100. rc = regmap_write(rtc_dd->regmap, regs->alarm_ctrl, ctrl_reg);
  101. if (rc) {
  102. dev_err(dev, "Write to RTC Alarm control register failed\n");
  103. goto rtc_rw_fail;
  104. }
  105. }
  106. /* Disable RTC H/w before writing on RTC register */
  107. rc = regmap_read(rtc_dd->regmap, regs->ctrl, &rtc_ctrl_reg);
  108. if (rc)
  109. goto rtc_rw_fail;
  110. if (rtc_ctrl_reg & PM8xxx_RTC_ENABLE) {
  111. rtc_disabled = 1;
  112. rtc_ctrl_reg &= ~PM8xxx_RTC_ENABLE;
  113. rc = regmap_write(rtc_dd->regmap, regs->ctrl, rtc_ctrl_reg);
  114. if (rc) {
  115. dev_err(dev, "Write to RTC control register failed\n");
  116. goto rtc_rw_fail;
  117. }
  118. }
  119. /* Write 0 to Byte[0] */
  120. rc = regmap_write(rtc_dd->regmap, regs->write, 0);
  121. if (rc) {
  122. dev_err(dev, "Write to RTC write data register failed\n");
  123. goto rtc_rw_fail;
  124. }
  125. /* Write Byte[1], Byte[2], Byte[3] */
  126. rc = regmap_bulk_write(rtc_dd->regmap, regs->write + 1,
  127. &value[1], sizeof(value) - 1);
  128. if (rc) {
  129. dev_err(dev, "Write to RTC write data register failed\n");
  130. goto rtc_rw_fail;
  131. }
  132. /* Write Byte[0] */
  133. rc = regmap_write(rtc_dd->regmap, regs->write, value[0]);
  134. if (rc) {
  135. dev_err(dev, "Write to RTC write data register failed\n");
  136. goto rtc_rw_fail;
  137. }
  138. /* Enable RTC H/w after writing on RTC register */
  139. if (rtc_disabled) {
  140. rtc_ctrl_reg |= PM8xxx_RTC_ENABLE;
  141. rc = regmap_write(rtc_dd->regmap, regs->ctrl, rtc_ctrl_reg);
  142. if (rc) {
  143. dev_err(dev, "Write to RTC control register failed\n");
  144. goto rtc_rw_fail;
  145. }
  146. }
  147. if (alarm_enabled) {
  148. ctrl_reg |= regs->alarm_en;
  149. rc = regmap_write(rtc_dd->regmap, regs->alarm_ctrl, ctrl_reg);
  150. if (rc) {
  151. dev_err(dev, "Write to RTC Alarm control register failed\n");
  152. goto rtc_rw_fail;
  153. }
  154. }
  155. rtc_rw_fail:
  156. spin_unlock_irqrestore(&rtc_dd->ctrl_reg_lock, irq_flags);
  157. return rc;
  158. }
  159. static int pm8xxx_rtc_read_time(struct device *dev, struct rtc_time *tm)
  160. {
  161. int rc;
  162. u8 value[NUM_8_BIT_RTC_REGS];
  163. unsigned long secs;
  164. unsigned int reg;
  165. struct pm8xxx_rtc *rtc_dd = dev_get_drvdata(dev);
  166. const struct pm8xxx_rtc_regs *regs = rtc_dd->regs;
  167. rc = regmap_bulk_read(rtc_dd->regmap, regs->read, value, sizeof(value));
  168. if (rc) {
  169. dev_err(dev, "RTC read data register failed\n");
  170. return rc;
  171. }
  172. /*
  173. * Read the LSB again and check if there has been a carry over.
  174. * If there is, redo the read operation.
  175. */
  176. rc = regmap_read(rtc_dd->regmap, regs->read, &reg);
  177. if (rc < 0) {
  178. dev_err(dev, "RTC read data register failed\n");
  179. return rc;
  180. }
  181. if (unlikely(reg < value[0])) {
  182. rc = regmap_bulk_read(rtc_dd->regmap, regs->read,
  183. value, sizeof(value));
  184. if (rc) {
  185. dev_err(dev, "RTC read data register failed\n");
  186. return rc;
  187. }
  188. }
  189. secs = value[0] | (value[1] << 8) | (value[2] << 16) | (value[3] << 24);
  190. rtc_time_to_tm(secs, tm);
  191. dev_dbg(dev, "secs = %lu, h:m:s == %d:%d:%d, d/m/y = %d/%d/%d\n",
  192. secs, tm->tm_hour, tm->tm_min, tm->tm_sec,
  193. tm->tm_mday, tm->tm_mon, tm->tm_year);
  194. return 0;
  195. }
  196. static int pm8xxx_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
  197. {
  198. int rc, i;
  199. u8 value[NUM_8_BIT_RTC_REGS];
  200. unsigned int ctrl_reg;
  201. unsigned long secs, irq_flags;
  202. struct pm8xxx_rtc *rtc_dd = dev_get_drvdata(dev);
  203. const struct pm8xxx_rtc_regs *regs = rtc_dd->regs;
  204. rtc_tm_to_time(&alarm->time, &secs);
  205. for (i = 0; i < NUM_8_BIT_RTC_REGS; i++) {
  206. value[i] = secs & 0xFF;
  207. secs >>= 8;
  208. }
  209. spin_lock_irqsave(&rtc_dd->ctrl_reg_lock, irq_flags);
  210. rc = regmap_bulk_write(rtc_dd->regmap, regs->alarm_rw, value,
  211. sizeof(value));
  212. if (rc) {
  213. dev_err(dev, "Write to RTC ALARM register failed\n");
  214. goto rtc_rw_fail;
  215. }
  216. rc = regmap_read(rtc_dd->regmap, regs->alarm_ctrl, &ctrl_reg);
  217. if (rc)
  218. goto rtc_rw_fail;
  219. if (alarm->enabled)
  220. ctrl_reg |= regs->alarm_en;
  221. else
  222. ctrl_reg &= ~regs->alarm_en;
  223. rc = regmap_write(rtc_dd->regmap, regs->alarm_ctrl, ctrl_reg);
  224. if (rc) {
  225. dev_err(dev, "Write to RTC alarm control register failed\n");
  226. goto rtc_rw_fail;
  227. }
  228. dev_dbg(dev, "Alarm Set for h:r:s=%d:%d:%d, d/m/y=%d/%d/%d\n",
  229. alarm->time.tm_hour, alarm->time.tm_min,
  230. alarm->time.tm_sec, alarm->time.tm_mday,
  231. alarm->time.tm_mon, alarm->time.tm_year);
  232. rtc_rw_fail:
  233. spin_unlock_irqrestore(&rtc_dd->ctrl_reg_lock, irq_flags);
  234. return rc;
  235. }
  236. static int pm8xxx_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
  237. {
  238. int rc;
  239. u8 value[NUM_8_BIT_RTC_REGS];
  240. unsigned long secs;
  241. struct pm8xxx_rtc *rtc_dd = dev_get_drvdata(dev);
  242. const struct pm8xxx_rtc_regs *regs = rtc_dd->regs;
  243. rc = regmap_bulk_read(rtc_dd->regmap, regs->alarm_rw, value,
  244. sizeof(value));
  245. if (rc) {
  246. dev_err(dev, "RTC alarm time read failed\n");
  247. return rc;
  248. }
  249. secs = value[0] | (value[1] << 8) | (value[2] << 16) | (value[3] << 24);
  250. rtc_time_to_tm(secs, &alarm->time);
  251. rc = rtc_valid_tm(&alarm->time);
  252. if (rc < 0) {
  253. dev_err(dev, "Invalid alarm time read from RTC\n");
  254. return rc;
  255. }
  256. dev_dbg(dev, "Alarm set for - h:r:s=%d:%d:%d, d/m/y=%d/%d/%d\n",
  257. alarm->time.tm_hour, alarm->time.tm_min,
  258. alarm->time.tm_sec, alarm->time.tm_mday,
  259. alarm->time.tm_mon, alarm->time.tm_year);
  260. return 0;
  261. }
  262. static int pm8xxx_rtc_alarm_irq_enable(struct device *dev, unsigned int enable)
  263. {
  264. int rc;
  265. unsigned long irq_flags;
  266. struct pm8xxx_rtc *rtc_dd = dev_get_drvdata(dev);
  267. const struct pm8xxx_rtc_regs *regs = rtc_dd->regs;
  268. unsigned int ctrl_reg;
  269. spin_lock_irqsave(&rtc_dd->ctrl_reg_lock, irq_flags);
  270. rc = regmap_read(rtc_dd->regmap, regs->alarm_ctrl, &ctrl_reg);
  271. if (rc)
  272. goto rtc_rw_fail;
  273. if (enable)
  274. ctrl_reg |= regs->alarm_en;
  275. else
  276. ctrl_reg &= ~regs->alarm_en;
  277. rc = regmap_write(rtc_dd->regmap, regs->alarm_ctrl, ctrl_reg);
  278. if (rc) {
  279. dev_err(dev, "Write to RTC control register failed\n");
  280. goto rtc_rw_fail;
  281. }
  282. rtc_rw_fail:
  283. spin_unlock_irqrestore(&rtc_dd->ctrl_reg_lock, irq_flags);
  284. return rc;
  285. }
  286. static const struct rtc_class_ops pm8xxx_rtc_ops = {
  287. .read_time = pm8xxx_rtc_read_time,
  288. .set_time = pm8xxx_rtc_set_time,
  289. .set_alarm = pm8xxx_rtc_set_alarm,
  290. .read_alarm = pm8xxx_rtc_read_alarm,
  291. .alarm_irq_enable = pm8xxx_rtc_alarm_irq_enable,
  292. };
  293. static irqreturn_t pm8xxx_alarm_trigger(int irq, void *dev_id)
  294. {
  295. struct pm8xxx_rtc *rtc_dd = dev_id;
  296. const struct pm8xxx_rtc_regs *regs = rtc_dd->regs;
  297. unsigned int ctrl_reg;
  298. int rc;
  299. unsigned long irq_flags;
  300. rtc_update_irq(rtc_dd->rtc, 1, RTC_IRQF | RTC_AF);
  301. spin_lock_irqsave(&rtc_dd->ctrl_reg_lock, irq_flags);
  302. /* Clear the alarm enable bit */
  303. rc = regmap_read(rtc_dd->regmap, regs->alarm_ctrl, &ctrl_reg);
  304. if (rc) {
  305. spin_unlock_irqrestore(&rtc_dd->ctrl_reg_lock, irq_flags);
  306. goto rtc_alarm_handled;
  307. }
  308. ctrl_reg &= ~regs->alarm_en;
  309. rc = regmap_write(rtc_dd->regmap, regs->alarm_ctrl, ctrl_reg);
  310. if (rc) {
  311. spin_unlock_irqrestore(&rtc_dd->ctrl_reg_lock, irq_flags);
  312. dev_err(rtc_dd->rtc_dev,
  313. "Write to alarm control register failed\n");
  314. goto rtc_alarm_handled;
  315. }
  316. spin_unlock_irqrestore(&rtc_dd->ctrl_reg_lock, irq_flags);
  317. /* Clear RTC alarm register */
  318. rc = regmap_read(rtc_dd->regmap, regs->alarm_ctrl2, &ctrl_reg);
  319. if (rc) {
  320. dev_err(rtc_dd->rtc_dev,
  321. "RTC Alarm control2 register read failed\n");
  322. goto rtc_alarm_handled;
  323. }
  324. ctrl_reg |= PM8xxx_RTC_ALARM_CLEAR;
  325. rc = regmap_write(rtc_dd->regmap, regs->alarm_ctrl2, ctrl_reg);
  326. if (rc)
  327. dev_err(rtc_dd->rtc_dev,
  328. "Write to RTC Alarm control2 register failed\n");
  329. rtc_alarm_handled:
  330. return IRQ_HANDLED;
  331. }
  332. static int pm8xxx_rtc_enable(struct pm8xxx_rtc *rtc_dd)
  333. {
  334. const struct pm8xxx_rtc_regs *regs = rtc_dd->regs;
  335. unsigned int ctrl_reg;
  336. int rc;
  337. /* Check if the RTC is on, else turn it on */
  338. rc = regmap_read(rtc_dd->regmap, regs->ctrl, &ctrl_reg);
  339. if (rc)
  340. return rc;
  341. if (!(ctrl_reg & PM8xxx_RTC_ENABLE)) {
  342. ctrl_reg |= PM8xxx_RTC_ENABLE;
  343. rc = regmap_write(rtc_dd->regmap, regs->ctrl, ctrl_reg);
  344. if (rc)
  345. return rc;
  346. }
  347. return 0;
  348. }
  349. static const struct pm8xxx_rtc_regs pm8921_regs = {
  350. .ctrl = 0x11d,
  351. .write = 0x11f,
  352. .read = 0x123,
  353. .alarm_rw = 0x127,
  354. .alarm_ctrl = 0x11d,
  355. .alarm_ctrl2 = 0x11e,
  356. .alarm_en = BIT(1),
  357. };
  358. static const struct pm8xxx_rtc_regs pm8058_regs = {
  359. .ctrl = 0x1e8,
  360. .write = 0x1ea,
  361. .read = 0x1ee,
  362. .alarm_rw = 0x1f2,
  363. .alarm_ctrl = 0x1e8,
  364. .alarm_ctrl2 = 0x1e9,
  365. .alarm_en = BIT(1),
  366. };
  367. static const struct pm8xxx_rtc_regs pm8941_regs = {
  368. .ctrl = 0x6046,
  369. .write = 0x6040,
  370. .read = 0x6048,
  371. .alarm_rw = 0x6140,
  372. .alarm_ctrl = 0x6146,
  373. .alarm_ctrl2 = 0x6148,
  374. .alarm_en = BIT(7),
  375. };
  376. /*
  377. * Hardcoded RTC bases until IORESOURCE_REG mapping is figured out
  378. */
  379. static const struct of_device_id pm8xxx_id_table[] = {
  380. { .compatible = "qcom,pm8921-rtc", .data = &pm8921_regs },
  381. { .compatible = "qcom,pm8018-rtc", .data = &pm8921_regs },
  382. { .compatible = "qcom,pm8058-rtc", .data = &pm8058_regs },
  383. { .compatible = "qcom,pm8941-rtc", .data = &pm8941_regs },
  384. { },
  385. };
  386. MODULE_DEVICE_TABLE(of, pm8xxx_id_table);
  387. static int pm8xxx_rtc_probe(struct platform_device *pdev)
  388. {
  389. int rc;
  390. struct pm8xxx_rtc *rtc_dd;
  391. const struct of_device_id *match;
  392. match = of_match_node(pm8xxx_id_table, pdev->dev.of_node);
  393. if (!match)
  394. return -ENXIO;
  395. rtc_dd = devm_kzalloc(&pdev->dev, sizeof(*rtc_dd), GFP_KERNEL);
  396. if (rtc_dd == NULL)
  397. return -ENOMEM;
  398. /* Initialise spinlock to protect RTC control register */
  399. spin_lock_init(&rtc_dd->ctrl_reg_lock);
  400. rtc_dd->regmap = dev_get_regmap(pdev->dev.parent, NULL);
  401. if (!rtc_dd->regmap) {
  402. dev_err(&pdev->dev, "Parent regmap unavailable.\n");
  403. return -ENXIO;
  404. }
  405. rtc_dd->rtc_alarm_irq = platform_get_irq(pdev, 0);
  406. if (rtc_dd->rtc_alarm_irq < 0) {
  407. dev_err(&pdev->dev, "Alarm IRQ resource absent!\n");
  408. return -ENXIO;
  409. }
  410. rtc_dd->allow_set_time = of_property_read_bool(pdev->dev.of_node,
  411. "allow-set-time");
  412. rtc_dd->regs = match->data;
  413. rtc_dd->rtc_dev = &pdev->dev;
  414. rc = pm8xxx_rtc_enable(rtc_dd);
  415. if (rc)
  416. return rc;
  417. platform_set_drvdata(pdev, rtc_dd);
  418. device_init_wakeup(&pdev->dev, 1);
  419. /* Register the RTC device */
  420. rtc_dd->rtc = devm_rtc_device_register(&pdev->dev, "pm8xxx_rtc",
  421. &pm8xxx_rtc_ops, THIS_MODULE);
  422. if (IS_ERR(rtc_dd->rtc)) {
  423. dev_err(&pdev->dev, "%s: RTC registration failed (%ld)\n",
  424. __func__, PTR_ERR(rtc_dd->rtc));
  425. return PTR_ERR(rtc_dd->rtc);
  426. }
  427. /* Request the alarm IRQ */
  428. rc = devm_request_any_context_irq(&pdev->dev, rtc_dd->rtc_alarm_irq,
  429. pm8xxx_alarm_trigger,
  430. IRQF_TRIGGER_RISING,
  431. "pm8xxx_rtc_alarm", rtc_dd);
  432. if (rc < 0) {
  433. dev_err(&pdev->dev, "Request IRQ failed (%d)\n", rc);
  434. return rc;
  435. }
  436. dev_dbg(&pdev->dev, "Probe success !!\n");
  437. return 0;
  438. }
  439. #ifdef CONFIG_PM_SLEEP
  440. static int pm8xxx_rtc_resume(struct device *dev)
  441. {
  442. struct pm8xxx_rtc *rtc_dd = dev_get_drvdata(dev);
  443. if (device_may_wakeup(dev))
  444. disable_irq_wake(rtc_dd->rtc_alarm_irq);
  445. return 0;
  446. }
  447. static int pm8xxx_rtc_suspend(struct device *dev)
  448. {
  449. struct pm8xxx_rtc *rtc_dd = dev_get_drvdata(dev);
  450. if (device_may_wakeup(dev))
  451. enable_irq_wake(rtc_dd->rtc_alarm_irq);
  452. return 0;
  453. }
  454. #endif
  455. static SIMPLE_DEV_PM_OPS(pm8xxx_rtc_pm_ops,
  456. pm8xxx_rtc_suspend,
  457. pm8xxx_rtc_resume);
  458. static struct platform_driver pm8xxx_rtc_driver = {
  459. .probe = pm8xxx_rtc_probe,
  460. .driver = {
  461. .name = "rtc-pm8xxx",
  462. .pm = &pm8xxx_rtc_pm_ops,
  463. .of_match_table = pm8xxx_id_table,
  464. },
  465. };
  466. module_platform_driver(pm8xxx_rtc_driver);
  467. MODULE_ALIAS("platform:rtc-pm8xxx");
  468. MODULE_DESCRIPTION("PMIC8xxx RTC driver");
  469. MODULE_LICENSE("GPL v2");
  470. MODULE_AUTHOR("Anirudh Ghayal <aghayal@codeaurora.org>");