drm_probe_helper.c 20 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602
  1. /*
  2. * Copyright (c) 2006-2008 Intel Corporation
  3. * Copyright (c) 2007 Dave Airlie <airlied@linux.ie>
  4. *
  5. * DRM core CRTC related functions
  6. *
  7. * Permission to use, copy, modify, distribute, and sell this software and its
  8. * documentation for any purpose is hereby granted without fee, provided that
  9. * the above copyright notice appear in all copies and that both that copyright
  10. * notice and this permission notice appear in supporting documentation, and
  11. * that the name of the copyright holders not be used in advertising or
  12. * publicity pertaining to distribution of the software without specific,
  13. * written prior permission. The copyright holders make no representations
  14. * about the suitability of this software for any purpose. It is provided "as
  15. * is" without express or implied warranty.
  16. *
  17. * THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
  18. * INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO
  19. * EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY SPECIAL, INDIRECT OR
  20. * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE,
  21. * DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER
  22. * TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE
  23. * OF THIS SOFTWARE.
  24. *
  25. * Authors:
  26. * Keith Packard
  27. * Eric Anholt <eric@anholt.net>
  28. * Dave Airlie <airlied@linux.ie>
  29. * Jesse Barnes <jesse.barnes@intel.com>
  30. */
  31. #include <linux/export.h>
  32. #include <linux/moduleparam.h>
  33. #include <drm/drmP.h>
  34. #include <drm/drm_crtc.h>
  35. #include <drm/drm_fourcc.h>
  36. #include <drm/drm_crtc_helper.h>
  37. #include <drm/drm_fb_helper.h>
  38. #include <drm/drm_edid.h>
  39. /**
  40. * DOC: output probing helper overview
  41. *
  42. * This library provides some helper code for output probing. It provides an
  43. * implementation of the core &drm_connector_funcs.fill_modes interface with
  44. * drm_helper_probe_single_connector_modes.
  45. *
  46. * It also provides support for polling connectors with a work item and for
  47. * generic hotplug interrupt handling where the driver doesn't or cannot keep
  48. * track of a per-connector hpd interrupt.
  49. *
  50. * This helper library can be used independently of the modeset helper library.
  51. * Drivers can also overwrite different parts e.g. use their own hotplug
  52. * handling code to avoid probing unrelated outputs.
  53. *
  54. * The probe helpers share the function table structures with other display
  55. * helper libraries. See &struct drm_connector_helper_funcs for the details.
  56. */
  57. static bool drm_kms_helper_poll = true;
  58. module_param_named(poll, drm_kms_helper_poll, bool, 0600);
  59. static enum drm_mode_status
  60. drm_mode_validate_flag(const struct drm_display_mode *mode,
  61. int flags)
  62. {
  63. if ((mode->flags & DRM_MODE_FLAG_INTERLACE) &&
  64. !(flags & DRM_MODE_FLAG_INTERLACE))
  65. return MODE_NO_INTERLACE;
  66. if ((mode->flags & DRM_MODE_FLAG_DBLSCAN) &&
  67. !(flags & DRM_MODE_FLAG_DBLSCAN))
  68. return MODE_NO_DBLESCAN;
  69. if ((mode->flags & DRM_MODE_FLAG_3D_MASK) &&
  70. !(flags & DRM_MODE_FLAG_3D_MASK))
  71. return MODE_NO_STEREO;
  72. return MODE_OK;
  73. }
  74. static int drm_helper_probe_add_cmdline_mode(struct drm_connector *connector)
  75. {
  76. struct drm_cmdline_mode *cmdline_mode;
  77. struct drm_display_mode *mode;
  78. cmdline_mode = &connector->cmdline_mode;
  79. if (!cmdline_mode->specified)
  80. return 0;
  81. /* Only add a GTF mode if we find no matching probed modes */
  82. list_for_each_entry(mode, &connector->probed_modes, head) {
  83. if (mode->hdisplay != cmdline_mode->xres ||
  84. mode->vdisplay != cmdline_mode->yres)
  85. continue;
  86. if (cmdline_mode->refresh_specified) {
  87. /* The probed mode's vrefresh is set until later */
  88. if (drm_mode_vrefresh(mode) != cmdline_mode->refresh)
  89. continue;
  90. }
  91. return 0;
  92. }
  93. mode = drm_mode_create_from_cmdline_mode(connector->dev,
  94. cmdline_mode);
  95. if (mode == NULL)
  96. return 0;
  97. drm_mode_probed_add(connector, mode);
  98. return 1;
  99. }
  100. #define DRM_OUTPUT_POLL_PERIOD (10*HZ)
  101. /**
  102. * drm_kms_helper_poll_enable - re-enable output polling.
  103. * @dev: drm_device
  104. *
  105. * This function re-enables the output polling work, after it has been
  106. * temporarily disabled using drm_kms_helper_poll_disable(), for example over
  107. * suspend/resume.
  108. *
  109. * Drivers can call this helper from their device resume implementation. It is
  110. * an error to call this when the output polling support has not yet been set
  111. * up.
  112. *
  113. * Note that calls to enable and disable polling must be strictly ordered, which
  114. * is automatically the case when they're only call from suspend/resume
  115. * callbacks.
  116. */
  117. void drm_kms_helper_poll_enable(struct drm_device *dev)
  118. {
  119. bool poll = false;
  120. struct drm_connector *connector;
  121. struct drm_connector_list_iter conn_iter;
  122. unsigned long delay = DRM_OUTPUT_POLL_PERIOD;
  123. if (!dev->mode_config.poll_enabled || !drm_kms_helper_poll)
  124. return;
  125. drm_connector_list_iter_get(dev, &conn_iter);
  126. drm_for_each_connector_iter(connector, &conn_iter) {
  127. if (connector->polled & (DRM_CONNECTOR_POLL_CONNECT |
  128. DRM_CONNECTOR_POLL_DISCONNECT))
  129. poll = true;
  130. }
  131. drm_connector_list_iter_put(&conn_iter);
  132. if (dev->mode_config.delayed_event) {
  133. /*
  134. * FIXME:
  135. *
  136. * Use short (1s) delay to handle the initial delayed event.
  137. * This delay should not be needed, but Optimus/nouveau will
  138. * fail in a mysterious way if the delayed event is handled as
  139. * soon as possible like it is done in
  140. * drm_helper_probe_single_connector_modes() in case the poll
  141. * was enabled before.
  142. */
  143. poll = true;
  144. delay = HZ;
  145. }
  146. if (poll)
  147. schedule_delayed_work(&dev->mode_config.output_poll_work, delay);
  148. }
  149. EXPORT_SYMBOL(drm_kms_helper_poll_enable);
  150. static enum drm_connector_status
  151. drm_connector_detect(struct drm_connector *connector, bool force)
  152. {
  153. return connector->funcs->detect ?
  154. connector->funcs->detect(connector, force) :
  155. connector_status_connected;
  156. }
  157. /**
  158. * drm_helper_probe_single_connector_modes - get complete set of display modes
  159. * @connector: connector to probe
  160. * @maxX: max width for modes
  161. * @maxY: max height for modes
  162. *
  163. * Based on the helper callbacks implemented by @connector in struct
  164. * &drm_connector_helper_funcs try to detect all valid modes. Modes will first
  165. * be added to the connector's probed_modes list, then culled (based on validity
  166. * and the @maxX, @maxY parameters) and put into the normal modes list.
  167. *
  168. * Intended to be used as a generic implementation of the
  169. * &drm_connector_funcs.fill_modes() vfunc for drivers that use the CRTC helpers
  170. * for output mode filtering and detection.
  171. *
  172. * The basic procedure is as follows
  173. *
  174. * 1. All modes currently on the connector's modes list are marked as stale
  175. *
  176. * 2. New modes are added to the connector's probed_modes list with
  177. * drm_mode_probed_add(). New modes start their life with status as OK.
  178. * Modes are added from a single source using the following priority order.
  179. *
  180. * - debugfs 'override_edid' (used for testing only)
  181. * - firmware EDID (drm_load_edid_firmware())
  182. * - &drm_connector_helper_funcs.get_modes vfunc
  183. * - if the connector status is connector_status_connected, standard
  184. * VESA DMT modes up to 1024x768 are automatically added
  185. * (drm_add_modes_noedid())
  186. *
  187. * Finally modes specified via the kernel command line (video=...) are
  188. * added in addition to what the earlier probes produced
  189. * (drm_helper_probe_add_cmdline_mode()). These modes are generated
  190. * using the VESA GTF/CVT formulas.
  191. *
  192. * 3. Modes are moved from the probed_modes list to the modes list. Potential
  193. * duplicates are merged together (see drm_mode_connector_list_update()).
  194. * After this step the probed_modes list will be empty again.
  195. *
  196. * 4. Any non-stale mode on the modes list then undergoes validation
  197. *
  198. * - drm_mode_validate_basic() performs basic sanity checks
  199. * - drm_mode_validate_size() filters out modes larger than @maxX and @maxY
  200. * (if specified)
  201. * - drm_mode_validate_flag() checks the modes against basic connector
  202. * capabilities (interlace_allowed,doublescan_allowed,stereo_allowed)
  203. * - the optional &drm_connector_helper_funcs.mode_valid helper can perform
  204. * driver and/or hardware specific checks
  205. *
  206. * 5. Any mode whose status is not OK is pruned from the connector's modes list,
  207. * accompanied by a debug message indicating the reason for the mode's
  208. * rejection (see drm_mode_prune_invalid()).
  209. *
  210. * Returns:
  211. * The number of modes found on @connector.
  212. */
  213. int drm_helper_probe_single_connector_modes(struct drm_connector *connector,
  214. uint32_t maxX, uint32_t maxY)
  215. {
  216. struct drm_device *dev = connector->dev;
  217. struct drm_display_mode *mode;
  218. const struct drm_connector_helper_funcs *connector_funcs =
  219. connector->helper_private;
  220. int count = 0;
  221. int mode_flags = 0;
  222. bool verbose_prune = true;
  223. enum drm_connector_status old_status;
  224. WARN_ON(!mutex_is_locked(&dev->mode_config.mutex));
  225. DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", connector->base.id,
  226. connector->name);
  227. /* set all old modes to the stale state */
  228. list_for_each_entry(mode, &connector->modes, head)
  229. mode->status = MODE_STALE;
  230. old_status = connector->status;
  231. if (connector->force) {
  232. if (connector->force == DRM_FORCE_ON ||
  233. connector->force == DRM_FORCE_ON_DIGITAL)
  234. connector->status = connector_status_connected;
  235. else
  236. connector->status = connector_status_disconnected;
  237. if (connector->funcs->force)
  238. connector->funcs->force(connector);
  239. } else {
  240. connector->status = drm_connector_detect(connector, true);
  241. }
  242. /*
  243. * Normally either the driver's hpd code or the poll loop should
  244. * pick up any changes and fire the hotplug event. But if
  245. * userspace sneaks in a probe, we might miss a change. Hence
  246. * check here, and if anything changed start the hotplug code.
  247. */
  248. if (old_status != connector->status) {
  249. DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s\n",
  250. connector->base.id,
  251. connector->name,
  252. drm_get_connector_status_name(old_status),
  253. drm_get_connector_status_name(connector->status));
  254. /*
  255. * The hotplug event code might call into the fb
  256. * helpers, and so expects that we do not hold any
  257. * locks. Fire up the poll struct instead, it will
  258. * disable itself again.
  259. */
  260. dev->mode_config.delayed_event = true;
  261. if (dev->mode_config.poll_enabled)
  262. schedule_delayed_work(&dev->mode_config.output_poll_work,
  263. 0);
  264. }
  265. /* Re-enable polling in case the global poll config changed. */
  266. if (drm_kms_helper_poll != dev->mode_config.poll_running)
  267. drm_kms_helper_poll_enable(dev);
  268. dev->mode_config.poll_running = drm_kms_helper_poll;
  269. if (connector->status == connector_status_disconnected) {
  270. DRM_DEBUG_KMS("[CONNECTOR:%d:%s] disconnected\n",
  271. connector->base.id, connector->name);
  272. drm_mode_connector_update_edid_property(connector, NULL);
  273. verbose_prune = false;
  274. goto prune;
  275. }
  276. if (connector->override_edid) {
  277. struct edid *edid = (struct edid *) connector->edid_blob_ptr->data;
  278. count = drm_add_edid_modes(connector, edid);
  279. drm_edid_to_eld(connector, edid);
  280. } else {
  281. count = drm_load_edid_firmware(connector);
  282. if (count == 0)
  283. count = (*connector_funcs->get_modes)(connector);
  284. }
  285. if (count == 0 && connector->status == connector_status_connected)
  286. count = drm_add_modes_noedid(connector, 1024, 768);
  287. count += drm_helper_probe_add_cmdline_mode(connector);
  288. if (count == 0)
  289. goto prune;
  290. drm_mode_connector_list_update(connector);
  291. if (connector->interlace_allowed)
  292. mode_flags |= DRM_MODE_FLAG_INTERLACE;
  293. if (connector->doublescan_allowed)
  294. mode_flags |= DRM_MODE_FLAG_DBLSCAN;
  295. if (connector->stereo_allowed)
  296. mode_flags |= DRM_MODE_FLAG_3D_MASK;
  297. list_for_each_entry(mode, &connector->modes, head) {
  298. if (mode->status == MODE_OK)
  299. mode->status = drm_mode_validate_basic(mode);
  300. if (mode->status == MODE_OK)
  301. mode->status = drm_mode_validate_size(mode, maxX, maxY);
  302. if (mode->status == MODE_OK)
  303. mode->status = drm_mode_validate_flag(mode, mode_flags);
  304. if (mode->status == MODE_OK && connector_funcs->mode_valid)
  305. mode->status = connector_funcs->mode_valid(connector,
  306. mode);
  307. }
  308. prune:
  309. drm_mode_prune_invalid(dev, &connector->modes, verbose_prune);
  310. if (list_empty(&connector->modes))
  311. return 0;
  312. list_for_each_entry(mode, &connector->modes, head)
  313. mode->vrefresh = drm_mode_vrefresh(mode);
  314. drm_mode_sort(&connector->modes);
  315. DRM_DEBUG_KMS("[CONNECTOR:%d:%s] probed modes :\n", connector->base.id,
  316. connector->name);
  317. list_for_each_entry(mode, &connector->modes, head) {
  318. drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V);
  319. drm_mode_debug_printmodeline(mode);
  320. }
  321. return count;
  322. }
  323. EXPORT_SYMBOL(drm_helper_probe_single_connector_modes);
  324. /**
  325. * drm_kms_helper_hotplug_event - fire off KMS hotplug events
  326. * @dev: drm_device whose connector state changed
  327. *
  328. * This function fires off the uevent for userspace and also calls the
  329. * output_poll_changed function, which is most commonly used to inform the fbdev
  330. * emulation code and allow it to update the fbcon output configuration.
  331. *
  332. * Drivers should call this from their hotplug handling code when a change is
  333. * detected. Note that this function does not do any output detection of its
  334. * own, like drm_helper_hpd_irq_event() does - this is assumed to be done by the
  335. * driver already.
  336. *
  337. * This function must be called from process context with no mode
  338. * setting locks held.
  339. */
  340. void drm_kms_helper_hotplug_event(struct drm_device *dev)
  341. {
  342. /* send a uevent + call fbdev */
  343. drm_sysfs_hotplug_event(dev);
  344. if (dev->mode_config.funcs->output_poll_changed)
  345. dev->mode_config.funcs->output_poll_changed(dev);
  346. }
  347. EXPORT_SYMBOL(drm_kms_helper_hotplug_event);
  348. static void output_poll_execute(struct work_struct *work)
  349. {
  350. struct delayed_work *delayed_work = to_delayed_work(work);
  351. struct drm_device *dev = container_of(delayed_work, struct drm_device, mode_config.output_poll_work);
  352. struct drm_connector *connector;
  353. struct drm_connector_list_iter conn_iter;
  354. enum drm_connector_status old_status;
  355. bool repoll = false, changed;
  356. /* Pick up any changes detected by the probe functions. */
  357. changed = dev->mode_config.delayed_event;
  358. dev->mode_config.delayed_event = false;
  359. if (!drm_kms_helper_poll)
  360. goto out;
  361. if (!mutex_trylock(&dev->mode_config.mutex)) {
  362. repoll = true;
  363. goto out;
  364. }
  365. drm_connector_list_iter_get(dev, &conn_iter);
  366. drm_for_each_connector_iter(connector, &conn_iter) {
  367. /* Ignore forced connectors. */
  368. if (connector->force)
  369. continue;
  370. /* Ignore HPD capable connectors and connectors where we don't
  371. * want any hotplug detection at all for polling. */
  372. if (!connector->polled || connector->polled == DRM_CONNECTOR_POLL_HPD)
  373. continue;
  374. old_status = connector->status;
  375. /* if we are connected and don't want to poll for disconnect
  376. skip it */
  377. if (old_status == connector_status_connected &&
  378. !(connector->polled & DRM_CONNECTOR_POLL_DISCONNECT))
  379. continue;
  380. repoll = true;
  381. connector->status = drm_connector_detect(connector, false);
  382. if (old_status != connector->status) {
  383. const char *old, *new;
  384. /*
  385. * The poll work sets force=false when calling detect so
  386. * that drivers can avoid to do disruptive tests (e.g.
  387. * when load detect cycles could cause flickering on
  388. * other, running displays). This bears the risk that we
  389. * flip-flop between unknown here in the poll work and
  390. * the real state when userspace forces a full detect
  391. * call after receiving a hotplug event due to this
  392. * change.
  393. *
  394. * Hence clamp an unknown detect status to the old
  395. * value.
  396. */
  397. if (connector->status == connector_status_unknown) {
  398. connector->status = old_status;
  399. continue;
  400. }
  401. old = drm_get_connector_status_name(old_status);
  402. new = drm_get_connector_status_name(connector->status);
  403. DRM_DEBUG_KMS("[CONNECTOR:%d:%s] "
  404. "status updated from %s to %s\n",
  405. connector->base.id,
  406. connector->name,
  407. old, new);
  408. changed = true;
  409. }
  410. }
  411. drm_connector_list_iter_put(&conn_iter);
  412. mutex_unlock(&dev->mode_config.mutex);
  413. out:
  414. if (changed)
  415. drm_kms_helper_hotplug_event(dev);
  416. if (repoll)
  417. schedule_delayed_work(delayed_work, DRM_OUTPUT_POLL_PERIOD);
  418. }
  419. /**
  420. * drm_kms_helper_poll_disable - disable output polling
  421. * @dev: drm_device
  422. *
  423. * This function disables the output polling work.
  424. *
  425. * Drivers can call this helper from their device suspend implementation. It is
  426. * not an error to call this even when output polling isn't enabled or already
  427. * disabled. Polling is re-enabled by calling drm_kms_helper_poll_enable().
  428. *
  429. * Note that calls to enable and disable polling must be strictly ordered, which
  430. * is automatically the case when they're only call from suspend/resume
  431. * callbacks.
  432. */
  433. void drm_kms_helper_poll_disable(struct drm_device *dev)
  434. {
  435. if (!dev->mode_config.poll_enabled)
  436. return;
  437. cancel_delayed_work_sync(&dev->mode_config.output_poll_work);
  438. }
  439. EXPORT_SYMBOL(drm_kms_helper_poll_disable);
  440. /**
  441. * drm_kms_helper_poll_init - initialize and enable output polling
  442. * @dev: drm_device
  443. *
  444. * This function intializes and then also enables output polling support for
  445. * @dev. Drivers which do not have reliable hotplug support in hardware can use
  446. * this helper infrastructure to regularly poll such connectors for changes in
  447. * their connection state.
  448. *
  449. * Drivers can control which connectors are polled by setting the
  450. * DRM_CONNECTOR_POLL_CONNECT and DRM_CONNECTOR_POLL_DISCONNECT flags. On
  451. * connectors where probing live outputs can result in visual distortion drivers
  452. * should not set the DRM_CONNECTOR_POLL_DISCONNECT flag to avoid this.
  453. * Connectors which have no flag or only DRM_CONNECTOR_POLL_HPD set are
  454. * completely ignored by the polling logic.
  455. *
  456. * Note that a connector can be both polled and probed from the hotplug handler,
  457. * in case the hotplug interrupt is known to be unreliable.
  458. */
  459. void drm_kms_helper_poll_init(struct drm_device *dev)
  460. {
  461. INIT_DELAYED_WORK(&dev->mode_config.output_poll_work, output_poll_execute);
  462. dev->mode_config.poll_enabled = true;
  463. drm_kms_helper_poll_enable(dev);
  464. }
  465. EXPORT_SYMBOL(drm_kms_helper_poll_init);
  466. /**
  467. * drm_kms_helper_poll_fini - disable output polling and clean it up
  468. * @dev: drm_device
  469. */
  470. void drm_kms_helper_poll_fini(struct drm_device *dev)
  471. {
  472. drm_kms_helper_poll_disable(dev);
  473. }
  474. EXPORT_SYMBOL(drm_kms_helper_poll_fini);
  475. /**
  476. * drm_helper_hpd_irq_event - hotplug processing
  477. * @dev: drm_device
  478. *
  479. * Drivers can use this helper function to run a detect cycle on all connectors
  480. * which have the DRM_CONNECTOR_POLL_HPD flag set in their &polled member. All
  481. * other connectors are ignored, which is useful to avoid reprobing fixed
  482. * panels.
  483. *
  484. * This helper function is useful for drivers which can't or don't track hotplug
  485. * interrupts for each connector.
  486. *
  487. * Drivers which support hotplug interrupts for each connector individually and
  488. * which have a more fine-grained detect logic should bypass this code and
  489. * directly call drm_kms_helper_hotplug_event() in case the connector state
  490. * changed.
  491. *
  492. * This function must be called from process context with no mode
  493. * setting locks held.
  494. *
  495. * Note that a connector can be both polled and probed from the hotplug handler,
  496. * in case the hotplug interrupt is known to be unreliable.
  497. */
  498. bool drm_helper_hpd_irq_event(struct drm_device *dev)
  499. {
  500. struct drm_connector *connector;
  501. struct drm_connector_list_iter conn_iter;
  502. enum drm_connector_status old_status;
  503. bool changed = false;
  504. if (!dev->mode_config.poll_enabled)
  505. return false;
  506. mutex_lock(&dev->mode_config.mutex);
  507. drm_connector_list_iter_get(dev, &conn_iter);
  508. drm_for_each_connector_iter(connector, &conn_iter) {
  509. /* Only handle HPD capable connectors. */
  510. if (!(connector->polled & DRM_CONNECTOR_POLL_HPD))
  511. continue;
  512. old_status = connector->status;
  513. connector->status = drm_connector_detect(connector, false);
  514. DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s\n",
  515. connector->base.id,
  516. connector->name,
  517. drm_get_connector_status_name(old_status),
  518. drm_get_connector_status_name(connector->status));
  519. if (old_status != connector->status)
  520. changed = true;
  521. }
  522. drm_connector_list_iter_put(&conn_iter);
  523. mutex_unlock(&dev->mode_config.mutex);
  524. if (changed)
  525. drm_kms_helper_hotplug_event(dev);
  526. return changed;
  527. }
  528. EXPORT_SYMBOL(drm_helper_hpd_irq_event);