xfs_attr_remote.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649
  1. /*
  2. * Copyright (c) 2000-2005 Silicon Graphics, Inc.
  3. * Copyright (c) 2013 Red Hat, Inc.
  4. * All Rights Reserved.
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU General Public License as
  8. * published by the Free Software Foundation.
  9. *
  10. * This program is distributed in the hope that it would be useful,
  11. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  12. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13. * GNU General Public License for more details.
  14. *
  15. * You should have received a copy of the GNU General Public License
  16. * along with this program; if not, write the Free Software Foundation,
  17. * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
  18. */
  19. #include "xfs.h"
  20. #include "xfs_fs.h"
  21. #include "xfs_shared.h"
  22. #include "xfs_format.h"
  23. #include "xfs_log_format.h"
  24. #include "xfs_trans_resv.h"
  25. #include "xfs_bit.h"
  26. #include "xfs_mount.h"
  27. #include "xfs_da_format.h"
  28. #include "xfs_da_btree.h"
  29. #include "xfs_inode.h"
  30. #include "xfs_alloc.h"
  31. #include "xfs_trans.h"
  32. #include "xfs_inode_item.h"
  33. #include "xfs_bmap.h"
  34. #include "xfs_bmap_util.h"
  35. #include "xfs_attr.h"
  36. #include "xfs_attr_leaf.h"
  37. #include "xfs_attr_remote.h"
  38. #include "xfs_trans_space.h"
  39. #include "xfs_trace.h"
  40. #include "xfs_cksum.h"
  41. #include "xfs_buf_item.h"
  42. #include "xfs_error.h"
  43. #define ATTR_RMTVALUE_MAPSIZE 1 /* # of map entries at once */
  44. /*
  45. * Each contiguous block has a header, so it is not just a simple attribute
  46. * length to FSB conversion.
  47. */
  48. int
  49. xfs_attr3_rmt_blocks(
  50. struct xfs_mount *mp,
  51. int attrlen)
  52. {
  53. if (xfs_sb_version_hascrc(&mp->m_sb)) {
  54. int buflen = XFS_ATTR3_RMT_BUF_SPACE(mp, mp->m_sb.sb_blocksize);
  55. return (attrlen + buflen - 1) / buflen;
  56. }
  57. return XFS_B_TO_FSB(mp, attrlen);
  58. }
  59. /*
  60. * Checking of the remote attribute header is split into two parts. The verifier
  61. * does CRC, location and bounds checking, the unpacking function checks the
  62. * attribute parameters and owner.
  63. */
  64. static bool
  65. xfs_attr3_rmt_hdr_ok(
  66. void *ptr,
  67. xfs_ino_t ino,
  68. uint32_t offset,
  69. uint32_t size,
  70. xfs_daddr_t bno)
  71. {
  72. struct xfs_attr3_rmt_hdr *rmt = ptr;
  73. if (bno != be64_to_cpu(rmt->rm_blkno))
  74. return false;
  75. if (offset != be32_to_cpu(rmt->rm_offset))
  76. return false;
  77. if (size != be32_to_cpu(rmt->rm_bytes))
  78. return false;
  79. if (ino != be64_to_cpu(rmt->rm_owner))
  80. return false;
  81. /* ok */
  82. return true;
  83. }
  84. static bool
  85. xfs_attr3_rmt_verify(
  86. struct xfs_mount *mp,
  87. void *ptr,
  88. int fsbsize,
  89. xfs_daddr_t bno)
  90. {
  91. struct xfs_attr3_rmt_hdr *rmt = ptr;
  92. if (!xfs_sb_version_hascrc(&mp->m_sb))
  93. return false;
  94. if (rmt->rm_magic != cpu_to_be32(XFS_ATTR3_RMT_MAGIC))
  95. return false;
  96. if (!uuid_equal(&rmt->rm_uuid, &mp->m_sb.sb_meta_uuid))
  97. return false;
  98. if (be64_to_cpu(rmt->rm_blkno) != bno)
  99. return false;
  100. if (be32_to_cpu(rmt->rm_bytes) > fsbsize - sizeof(*rmt))
  101. return false;
  102. if (be32_to_cpu(rmt->rm_offset) +
  103. be32_to_cpu(rmt->rm_bytes) > XATTR_SIZE_MAX)
  104. return false;
  105. if (rmt->rm_owner == 0)
  106. return false;
  107. return true;
  108. }
  109. static void
  110. xfs_attr3_rmt_read_verify(
  111. struct xfs_buf *bp)
  112. {
  113. struct xfs_mount *mp = bp->b_target->bt_mount;
  114. char *ptr;
  115. int len;
  116. xfs_daddr_t bno;
  117. int blksize = mp->m_attr_geo->blksize;
  118. /* no verification of non-crc buffers */
  119. if (!xfs_sb_version_hascrc(&mp->m_sb))
  120. return;
  121. ptr = bp->b_addr;
  122. bno = bp->b_bn;
  123. len = BBTOB(bp->b_length);
  124. ASSERT(len >= blksize);
  125. while (len > 0) {
  126. if (!xfs_verify_cksum(ptr, blksize, XFS_ATTR3_RMT_CRC_OFF)) {
  127. xfs_buf_ioerror(bp, -EFSBADCRC);
  128. break;
  129. }
  130. if (!xfs_attr3_rmt_verify(mp, ptr, blksize, bno)) {
  131. xfs_buf_ioerror(bp, -EFSCORRUPTED);
  132. break;
  133. }
  134. len -= blksize;
  135. ptr += blksize;
  136. bno += BTOBB(blksize);
  137. }
  138. if (bp->b_error)
  139. xfs_verifier_error(bp);
  140. else
  141. ASSERT(len == 0);
  142. }
  143. static void
  144. xfs_attr3_rmt_write_verify(
  145. struct xfs_buf *bp)
  146. {
  147. struct xfs_mount *mp = bp->b_target->bt_mount;
  148. int blksize = mp->m_attr_geo->blksize;
  149. char *ptr;
  150. int len;
  151. xfs_daddr_t bno;
  152. /* no verification of non-crc buffers */
  153. if (!xfs_sb_version_hascrc(&mp->m_sb))
  154. return;
  155. ptr = bp->b_addr;
  156. bno = bp->b_bn;
  157. len = BBTOB(bp->b_length);
  158. ASSERT(len >= blksize);
  159. while (len > 0) {
  160. struct xfs_attr3_rmt_hdr *rmt = (struct xfs_attr3_rmt_hdr *)ptr;
  161. if (!xfs_attr3_rmt_verify(mp, ptr, blksize, bno)) {
  162. xfs_buf_ioerror(bp, -EFSCORRUPTED);
  163. xfs_verifier_error(bp);
  164. return;
  165. }
  166. /*
  167. * Ensure we aren't writing bogus LSNs to disk. See
  168. * xfs_attr3_rmt_hdr_set() for the explanation.
  169. */
  170. if (rmt->rm_lsn != cpu_to_be64(NULLCOMMITLSN)) {
  171. xfs_buf_ioerror(bp, -EFSCORRUPTED);
  172. xfs_verifier_error(bp);
  173. return;
  174. }
  175. xfs_update_cksum(ptr, blksize, XFS_ATTR3_RMT_CRC_OFF);
  176. len -= blksize;
  177. ptr += blksize;
  178. bno += BTOBB(blksize);
  179. }
  180. ASSERT(len == 0);
  181. }
  182. const struct xfs_buf_ops xfs_attr3_rmt_buf_ops = {
  183. .verify_read = xfs_attr3_rmt_read_verify,
  184. .verify_write = xfs_attr3_rmt_write_verify,
  185. };
  186. STATIC int
  187. xfs_attr3_rmt_hdr_set(
  188. struct xfs_mount *mp,
  189. void *ptr,
  190. xfs_ino_t ino,
  191. uint32_t offset,
  192. uint32_t size,
  193. xfs_daddr_t bno)
  194. {
  195. struct xfs_attr3_rmt_hdr *rmt = ptr;
  196. if (!xfs_sb_version_hascrc(&mp->m_sb))
  197. return 0;
  198. rmt->rm_magic = cpu_to_be32(XFS_ATTR3_RMT_MAGIC);
  199. rmt->rm_offset = cpu_to_be32(offset);
  200. rmt->rm_bytes = cpu_to_be32(size);
  201. uuid_copy(&rmt->rm_uuid, &mp->m_sb.sb_meta_uuid);
  202. rmt->rm_owner = cpu_to_be64(ino);
  203. rmt->rm_blkno = cpu_to_be64(bno);
  204. /*
  205. * Remote attribute blocks are written synchronously, so we don't
  206. * have an LSN that we can stamp in them that makes any sense to log
  207. * recovery. To ensure that log recovery handles overwrites of these
  208. * blocks sanely (i.e. once they've been freed and reallocated as some
  209. * other type of metadata) we need to ensure that the LSN has a value
  210. * that tells log recovery to ignore the LSN and overwrite the buffer
  211. * with whatever is in it's log. To do this, we use the magic
  212. * NULLCOMMITLSN to indicate that the LSN is invalid.
  213. */
  214. rmt->rm_lsn = cpu_to_be64(NULLCOMMITLSN);
  215. return sizeof(struct xfs_attr3_rmt_hdr);
  216. }
  217. /*
  218. * Helper functions to copy attribute data in and out of the one disk extents
  219. */
  220. STATIC int
  221. xfs_attr_rmtval_copyout(
  222. struct xfs_mount *mp,
  223. struct xfs_buf *bp,
  224. xfs_ino_t ino,
  225. int *offset,
  226. int *valuelen,
  227. __uint8_t **dst)
  228. {
  229. char *src = bp->b_addr;
  230. xfs_daddr_t bno = bp->b_bn;
  231. int len = BBTOB(bp->b_length);
  232. int blksize = mp->m_attr_geo->blksize;
  233. ASSERT(len >= blksize);
  234. while (len > 0 && *valuelen > 0) {
  235. int hdr_size = 0;
  236. int byte_cnt = XFS_ATTR3_RMT_BUF_SPACE(mp, blksize);
  237. byte_cnt = min(*valuelen, byte_cnt);
  238. if (xfs_sb_version_hascrc(&mp->m_sb)) {
  239. if (!xfs_attr3_rmt_hdr_ok(src, ino, *offset,
  240. byte_cnt, bno)) {
  241. xfs_alert(mp,
  242. "remote attribute header mismatch bno/off/len/owner (0x%llx/0x%x/Ox%x/0x%llx)",
  243. bno, *offset, byte_cnt, ino);
  244. return -EFSCORRUPTED;
  245. }
  246. hdr_size = sizeof(struct xfs_attr3_rmt_hdr);
  247. }
  248. memcpy(*dst, src + hdr_size, byte_cnt);
  249. /* roll buffer forwards */
  250. len -= blksize;
  251. src += blksize;
  252. bno += BTOBB(blksize);
  253. /* roll attribute data forwards */
  254. *valuelen -= byte_cnt;
  255. *dst += byte_cnt;
  256. *offset += byte_cnt;
  257. }
  258. return 0;
  259. }
  260. STATIC void
  261. xfs_attr_rmtval_copyin(
  262. struct xfs_mount *mp,
  263. struct xfs_buf *bp,
  264. xfs_ino_t ino,
  265. int *offset,
  266. int *valuelen,
  267. __uint8_t **src)
  268. {
  269. char *dst = bp->b_addr;
  270. xfs_daddr_t bno = bp->b_bn;
  271. int len = BBTOB(bp->b_length);
  272. int blksize = mp->m_attr_geo->blksize;
  273. ASSERT(len >= blksize);
  274. while (len > 0 && *valuelen > 0) {
  275. int hdr_size;
  276. int byte_cnt = XFS_ATTR3_RMT_BUF_SPACE(mp, blksize);
  277. byte_cnt = min(*valuelen, byte_cnt);
  278. hdr_size = xfs_attr3_rmt_hdr_set(mp, dst, ino, *offset,
  279. byte_cnt, bno);
  280. memcpy(dst + hdr_size, *src, byte_cnt);
  281. /*
  282. * If this is the last block, zero the remainder of it.
  283. * Check that we are actually the last block, too.
  284. */
  285. if (byte_cnt + hdr_size < blksize) {
  286. ASSERT(*valuelen - byte_cnt == 0);
  287. ASSERT(len == blksize);
  288. memset(dst + hdr_size + byte_cnt, 0,
  289. blksize - hdr_size - byte_cnt);
  290. }
  291. /* roll buffer forwards */
  292. len -= blksize;
  293. dst += blksize;
  294. bno += BTOBB(blksize);
  295. /* roll attribute data forwards */
  296. *valuelen -= byte_cnt;
  297. *src += byte_cnt;
  298. *offset += byte_cnt;
  299. }
  300. }
  301. /*
  302. * Read the value associated with an attribute from the out-of-line buffer
  303. * that we stored it in.
  304. */
  305. int
  306. xfs_attr_rmtval_get(
  307. struct xfs_da_args *args)
  308. {
  309. struct xfs_bmbt_irec map[ATTR_RMTVALUE_MAPSIZE];
  310. struct xfs_mount *mp = args->dp->i_mount;
  311. struct xfs_buf *bp;
  312. xfs_dablk_t lblkno = args->rmtblkno;
  313. __uint8_t *dst = args->value;
  314. int valuelen;
  315. int nmap;
  316. int error;
  317. int blkcnt = args->rmtblkcnt;
  318. int i;
  319. int offset = 0;
  320. trace_xfs_attr_rmtval_get(args);
  321. ASSERT(!(args->flags & ATTR_KERNOVAL));
  322. ASSERT(args->rmtvaluelen == args->valuelen);
  323. valuelen = args->rmtvaluelen;
  324. while (valuelen > 0) {
  325. nmap = ATTR_RMTVALUE_MAPSIZE;
  326. error = xfs_bmapi_read(args->dp, (xfs_fileoff_t)lblkno,
  327. blkcnt, map, &nmap,
  328. XFS_BMAPI_ATTRFORK);
  329. if (error)
  330. return error;
  331. ASSERT(nmap >= 1);
  332. for (i = 0; (i < nmap) && (valuelen > 0); i++) {
  333. xfs_daddr_t dblkno;
  334. int dblkcnt;
  335. ASSERT((map[i].br_startblock != DELAYSTARTBLOCK) &&
  336. (map[i].br_startblock != HOLESTARTBLOCK));
  337. dblkno = XFS_FSB_TO_DADDR(mp, map[i].br_startblock);
  338. dblkcnt = XFS_FSB_TO_BB(mp, map[i].br_blockcount);
  339. error = xfs_trans_read_buf(mp, NULL, mp->m_ddev_targp,
  340. dblkno, dblkcnt, 0, &bp,
  341. &xfs_attr3_rmt_buf_ops);
  342. if (error)
  343. return error;
  344. error = xfs_attr_rmtval_copyout(mp, bp, args->dp->i_ino,
  345. &offset, &valuelen,
  346. &dst);
  347. xfs_buf_relse(bp);
  348. if (error)
  349. return error;
  350. /* roll attribute extent map forwards */
  351. lblkno += map[i].br_blockcount;
  352. blkcnt -= map[i].br_blockcount;
  353. }
  354. }
  355. ASSERT(valuelen == 0);
  356. return 0;
  357. }
  358. /*
  359. * Write the value associated with an attribute into the out-of-line buffer
  360. * that we have defined for it.
  361. */
  362. int
  363. xfs_attr_rmtval_set(
  364. struct xfs_da_args *args)
  365. {
  366. struct xfs_inode *dp = args->dp;
  367. struct xfs_mount *mp = dp->i_mount;
  368. struct xfs_bmbt_irec map;
  369. xfs_dablk_t lblkno;
  370. xfs_fileoff_t lfileoff = 0;
  371. __uint8_t *src = args->value;
  372. int blkcnt;
  373. int valuelen;
  374. int nmap;
  375. int error;
  376. int offset = 0;
  377. trace_xfs_attr_rmtval_set(args);
  378. /*
  379. * Find a "hole" in the attribute address space large enough for
  380. * us to drop the new attribute's value into. Because CRC enable
  381. * attributes have headers, we can't just do a straight byte to FSB
  382. * conversion and have to take the header space into account.
  383. */
  384. blkcnt = xfs_attr3_rmt_blocks(mp, args->rmtvaluelen);
  385. error = xfs_bmap_first_unused(args->trans, args->dp, blkcnt, &lfileoff,
  386. XFS_ATTR_FORK);
  387. if (error)
  388. return error;
  389. args->rmtblkno = lblkno = (xfs_dablk_t)lfileoff;
  390. args->rmtblkcnt = blkcnt;
  391. /*
  392. * Roll through the "value", allocating blocks on disk as required.
  393. */
  394. while (blkcnt > 0) {
  395. int committed;
  396. /*
  397. * Allocate a single extent, up to the size of the value.
  398. *
  399. * Note that we have to consider this a data allocation as we
  400. * write the remote attribute without logging the contents.
  401. * Hence we must ensure that we aren't using blocks that are on
  402. * the busy list so that we don't overwrite blocks which have
  403. * recently been freed but their transactions are not yet
  404. * committed to disk. If we overwrite the contents of a busy
  405. * extent and then crash then the block may not contain the
  406. * correct metadata after log recovery occurs.
  407. */
  408. xfs_bmap_init(args->flist, args->firstblock);
  409. nmap = 1;
  410. error = xfs_bmapi_write(args->trans, dp, (xfs_fileoff_t)lblkno,
  411. blkcnt, XFS_BMAPI_ATTRFORK, args->firstblock,
  412. args->total, &map, &nmap, args->flist);
  413. if (!error) {
  414. error = xfs_bmap_finish(&args->trans, args->flist,
  415. &committed);
  416. }
  417. if (error) {
  418. ASSERT(committed);
  419. args->trans = NULL;
  420. xfs_bmap_cancel(args->flist);
  421. return error;
  422. }
  423. /*
  424. * bmap_finish() may have committed the last trans and started
  425. * a new one. We need the inode to be in all transactions.
  426. */
  427. if (committed)
  428. xfs_trans_ijoin(args->trans, dp, 0);
  429. ASSERT(nmap == 1);
  430. ASSERT((map.br_startblock != DELAYSTARTBLOCK) &&
  431. (map.br_startblock != HOLESTARTBLOCK));
  432. lblkno += map.br_blockcount;
  433. blkcnt -= map.br_blockcount;
  434. /*
  435. * Start the next trans in the chain.
  436. */
  437. error = xfs_trans_roll(&args->trans, dp);
  438. if (error)
  439. return error;
  440. }
  441. /*
  442. * Roll through the "value", copying the attribute value to the
  443. * already-allocated blocks. Blocks are written synchronously
  444. * so that we can know they are all on disk before we turn off
  445. * the INCOMPLETE flag.
  446. */
  447. lblkno = args->rmtblkno;
  448. blkcnt = args->rmtblkcnt;
  449. valuelen = args->rmtvaluelen;
  450. while (valuelen > 0) {
  451. struct xfs_buf *bp;
  452. xfs_daddr_t dblkno;
  453. int dblkcnt;
  454. ASSERT(blkcnt > 0);
  455. xfs_bmap_init(args->flist, args->firstblock);
  456. nmap = 1;
  457. error = xfs_bmapi_read(dp, (xfs_fileoff_t)lblkno,
  458. blkcnt, &map, &nmap,
  459. XFS_BMAPI_ATTRFORK);
  460. if (error)
  461. return error;
  462. ASSERT(nmap == 1);
  463. ASSERT((map.br_startblock != DELAYSTARTBLOCK) &&
  464. (map.br_startblock != HOLESTARTBLOCK));
  465. dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock),
  466. dblkcnt = XFS_FSB_TO_BB(mp, map.br_blockcount);
  467. bp = xfs_buf_get(mp->m_ddev_targp, dblkno, dblkcnt, 0);
  468. if (!bp)
  469. return -ENOMEM;
  470. bp->b_ops = &xfs_attr3_rmt_buf_ops;
  471. xfs_attr_rmtval_copyin(mp, bp, args->dp->i_ino, &offset,
  472. &valuelen, &src);
  473. error = xfs_bwrite(bp); /* GROT: NOTE: synchronous write */
  474. xfs_buf_relse(bp);
  475. if (error)
  476. return error;
  477. /* roll attribute extent map forwards */
  478. lblkno += map.br_blockcount;
  479. blkcnt -= map.br_blockcount;
  480. }
  481. ASSERT(valuelen == 0);
  482. return 0;
  483. }
  484. /*
  485. * Remove the value associated with an attribute by deleting the
  486. * out-of-line buffer that it is stored on.
  487. */
  488. int
  489. xfs_attr_rmtval_remove(
  490. struct xfs_da_args *args)
  491. {
  492. struct xfs_mount *mp = args->dp->i_mount;
  493. xfs_dablk_t lblkno;
  494. int blkcnt;
  495. int error;
  496. int done;
  497. trace_xfs_attr_rmtval_remove(args);
  498. /*
  499. * Roll through the "value", invalidating the attribute value's blocks.
  500. */
  501. lblkno = args->rmtblkno;
  502. blkcnt = args->rmtblkcnt;
  503. while (blkcnt > 0) {
  504. struct xfs_bmbt_irec map;
  505. struct xfs_buf *bp;
  506. xfs_daddr_t dblkno;
  507. int dblkcnt;
  508. int nmap;
  509. /*
  510. * Try to remember where we decided to put the value.
  511. */
  512. nmap = 1;
  513. error = xfs_bmapi_read(args->dp, (xfs_fileoff_t)lblkno,
  514. blkcnt, &map, &nmap, XFS_BMAPI_ATTRFORK);
  515. if (error)
  516. return error;
  517. ASSERT(nmap == 1);
  518. ASSERT((map.br_startblock != DELAYSTARTBLOCK) &&
  519. (map.br_startblock != HOLESTARTBLOCK));
  520. dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock),
  521. dblkcnt = XFS_FSB_TO_BB(mp, map.br_blockcount);
  522. /*
  523. * If the "remote" value is in the cache, remove it.
  524. */
  525. bp = xfs_incore(mp->m_ddev_targp, dblkno, dblkcnt, XBF_TRYLOCK);
  526. if (bp) {
  527. xfs_buf_stale(bp);
  528. xfs_buf_relse(bp);
  529. bp = NULL;
  530. }
  531. lblkno += map.br_blockcount;
  532. blkcnt -= map.br_blockcount;
  533. }
  534. /*
  535. * Keep de-allocating extents until the remote-value region is gone.
  536. */
  537. lblkno = args->rmtblkno;
  538. blkcnt = args->rmtblkcnt;
  539. done = 0;
  540. while (!done) {
  541. int committed;
  542. xfs_bmap_init(args->flist, args->firstblock);
  543. error = xfs_bunmapi(args->trans, args->dp, lblkno, blkcnt,
  544. XFS_BMAPI_ATTRFORK, 1, args->firstblock,
  545. args->flist, &done);
  546. if (!error) {
  547. error = xfs_bmap_finish(&args->trans, args->flist,
  548. &committed);
  549. }
  550. if (error) {
  551. ASSERT(committed);
  552. args->trans = NULL;
  553. xfs_bmap_cancel(args->flist);
  554. return error;
  555. }
  556. /*
  557. * bmap_finish() may have committed the last trans and started
  558. * a new one. We need the inode to be in all transactions.
  559. */
  560. if (committed)
  561. xfs_trans_ijoin(args->trans, args->dp, 0);
  562. /*
  563. * Close out trans and start the next one in the chain.
  564. */
  565. error = xfs_trans_roll(&args->trans, args->dp);
  566. if (error)
  567. return error;
  568. }
  569. return 0;
  570. }