br_vlan.c 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736
  1. #include <linux/kernel.h>
  2. #include <linux/netdevice.h>
  3. #include <linux/rtnetlink.h>
  4. #include <linux/slab.h>
  5. #include "br_private.h"
  6. static void __vlan_add_pvid(struct net_port_vlans *v, u16 vid)
  7. {
  8. if (v->pvid == vid)
  9. return;
  10. smp_wmb();
  11. v->pvid = vid;
  12. }
  13. static void __vlan_delete_pvid(struct net_port_vlans *v, u16 vid)
  14. {
  15. if (v->pvid != vid)
  16. return;
  17. smp_wmb();
  18. v->pvid = 0;
  19. }
  20. static void __vlan_add_flags(struct net_port_vlans *v, u16 vid, u16 flags)
  21. {
  22. if (flags & BRIDGE_VLAN_INFO_PVID)
  23. __vlan_add_pvid(v, vid);
  24. else
  25. __vlan_delete_pvid(v, vid);
  26. if (flags & BRIDGE_VLAN_INFO_UNTAGGED)
  27. set_bit(vid, v->untagged_bitmap);
  28. else
  29. clear_bit(vid, v->untagged_bitmap);
  30. }
  31. static int __vlan_add(struct net_port_vlans *v, u16 vid, u16 flags)
  32. {
  33. struct net_bridge_port *p = NULL;
  34. struct net_bridge *br;
  35. struct net_device *dev;
  36. int err;
  37. if (test_bit(vid, v->vlan_bitmap)) {
  38. __vlan_add_flags(v, vid, flags);
  39. return 0;
  40. }
  41. if (v->port_idx) {
  42. p = v->parent.port;
  43. br = p->br;
  44. dev = p->dev;
  45. } else {
  46. br = v->parent.br;
  47. dev = br->dev;
  48. }
  49. if (p) {
  50. /* Add VLAN to the device filter if it is supported.
  51. * This ensures tagged traffic enters the bridge when
  52. * promiscuous mode is disabled by br_manage_promisc().
  53. */
  54. err = vlan_vid_add(dev, br->vlan_proto, vid);
  55. if (err)
  56. return err;
  57. }
  58. err = br_fdb_insert(br, p, dev->dev_addr, vid);
  59. if (err) {
  60. br_err(br, "failed insert local address into bridge "
  61. "forwarding table\n");
  62. goto out_filt;
  63. }
  64. set_bit(vid, v->vlan_bitmap);
  65. v->num_vlans++;
  66. __vlan_add_flags(v, vid, flags);
  67. return 0;
  68. out_filt:
  69. if (p)
  70. vlan_vid_del(dev, br->vlan_proto, vid);
  71. return err;
  72. }
  73. static int __vlan_del(struct net_port_vlans *v, u16 vid)
  74. {
  75. if (!test_bit(vid, v->vlan_bitmap))
  76. return -EINVAL;
  77. __vlan_delete_pvid(v, vid);
  78. clear_bit(vid, v->untagged_bitmap);
  79. if (v->port_idx) {
  80. struct net_bridge_port *p = v->parent.port;
  81. vlan_vid_del(p->dev, p->br->vlan_proto, vid);
  82. }
  83. clear_bit(vid, v->vlan_bitmap);
  84. v->num_vlans--;
  85. if (bitmap_empty(v->vlan_bitmap, VLAN_N_VID)) {
  86. if (v->port_idx)
  87. RCU_INIT_POINTER(v->parent.port->vlan_info, NULL);
  88. else
  89. RCU_INIT_POINTER(v->parent.br->vlan_info, NULL);
  90. kfree_rcu(v, rcu);
  91. }
  92. return 0;
  93. }
  94. static void __vlan_flush(struct net_port_vlans *v)
  95. {
  96. smp_wmb();
  97. v->pvid = 0;
  98. bitmap_zero(v->vlan_bitmap, VLAN_N_VID);
  99. if (v->port_idx)
  100. RCU_INIT_POINTER(v->parent.port->vlan_info, NULL);
  101. else
  102. RCU_INIT_POINTER(v->parent.br->vlan_info, NULL);
  103. kfree_rcu(v, rcu);
  104. }
  105. struct sk_buff *br_handle_vlan(struct net_bridge *br,
  106. const struct net_port_vlans *pv,
  107. struct sk_buff *skb)
  108. {
  109. u16 vid;
  110. /* If this packet was not filtered at input, let it pass */
  111. if (!BR_INPUT_SKB_CB(skb)->vlan_filtered)
  112. goto out;
  113. /* Vlan filter table must be configured at this point. The
  114. * only exception is the bridge is set in promisc mode and the
  115. * packet is destined for the bridge device. In this case
  116. * pass the packet as is.
  117. */
  118. if (!pv) {
  119. if ((br->dev->flags & IFF_PROMISC) && skb->dev == br->dev) {
  120. goto out;
  121. } else {
  122. kfree_skb(skb);
  123. return NULL;
  124. }
  125. }
  126. /* At this point, we know that the frame was filtered and contains
  127. * a valid vlan id. If the vlan id is set in the untagged bitmap,
  128. * send untagged; otherwise, send tagged.
  129. */
  130. br_vlan_get_tag(skb, &vid);
  131. if (test_bit(vid, pv->untagged_bitmap))
  132. skb->vlan_tci = 0;
  133. out:
  134. return skb;
  135. }
  136. /* Called under RCU */
  137. bool br_allowed_ingress(struct net_bridge *br, struct net_port_vlans *v,
  138. struct sk_buff *skb, u16 *vid)
  139. {
  140. bool tagged;
  141. __be16 proto;
  142. /* If VLAN filtering is disabled on the bridge, all packets are
  143. * permitted.
  144. */
  145. if (!br->vlan_enabled) {
  146. BR_INPUT_SKB_CB(skb)->vlan_filtered = false;
  147. return true;
  148. }
  149. /* If there are no vlan in the permitted list, all packets are
  150. * rejected.
  151. */
  152. if (!v)
  153. goto drop;
  154. BR_INPUT_SKB_CB(skb)->vlan_filtered = true;
  155. proto = br->vlan_proto;
  156. /* If vlan tx offload is disabled on bridge device and frame was
  157. * sent from vlan device on the bridge device, it does not have
  158. * HW accelerated vlan tag.
  159. */
  160. if (unlikely(!vlan_tx_tag_present(skb) &&
  161. skb->protocol == proto)) {
  162. skb = skb_vlan_untag(skb);
  163. if (unlikely(!skb))
  164. return false;
  165. }
  166. if (!br_vlan_get_tag(skb, vid)) {
  167. /* Tagged frame */
  168. if (skb->vlan_proto != proto) {
  169. /* Protocol-mismatch, empty out vlan_tci for new tag */
  170. skb_push(skb, ETH_HLEN);
  171. skb = __vlan_put_tag(skb, skb->vlan_proto,
  172. vlan_tx_tag_get(skb));
  173. if (unlikely(!skb))
  174. return false;
  175. skb_pull(skb, ETH_HLEN);
  176. skb_reset_mac_len(skb);
  177. *vid = 0;
  178. tagged = false;
  179. } else {
  180. tagged = true;
  181. }
  182. } else {
  183. /* Untagged frame */
  184. tagged = false;
  185. }
  186. if (!*vid) {
  187. u16 pvid = br_get_pvid(v);
  188. /* Frame had a tag with VID 0 or did not have a tag.
  189. * See if pvid is set on this port. That tells us which
  190. * vlan untagged or priority-tagged traffic belongs to.
  191. */
  192. if (!pvid)
  193. goto drop;
  194. /* PVID is set on this port. Any untagged or priority-tagged
  195. * ingress frame is considered to belong to this vlan.
  196. */
  197. *vid = pvid;
  198. if (likely(!tagged))
  199. /* Untagged Frame. */
  200. __vlan_hwaccel_put_tag(skb, proto, pvid);
  201. else
  202. /* Priority-tagged Frame.
  203. * At this point, We know that skb->vlan_tci had
  204. * VLAN_TAG_PRESENT bit and its VID field was 0x000.
  205. * We update only VID field and preserve PCP field.
  206. */
  207. skb->vlan_tci |= pvid;
  208. return true;
  209. }
  210. /* Frame had a valid vlan tag. See if vlan is allowed */
  211. if (test_bit(*vid, v->vlan_bitmap))
  212. return true;
  213. drop:
  214. kfree_skb(skb);
  215. return false;
  216. }
  217. /* Called under RCU. */
  218. bool br_allowed_egress(struct net_bridge *br,
  219. const struct net_port_vlans *v,
  220. const struct sk_buff *skb)
  221. {
  222. u16 vid;
  223. /* If this packet was not filtered at input, let it pass */
  224. if (!BR_INPUT_SKB_CB(skb)->vlan_filtered)
  225. return true;
  226. if (!v)
  227. return false;
  228. br_vlan_get_tag(skb, &vid);
  229. if (test_bit(vid, v->vlan_bitmap))
  230. return true;
  231. return false;
  232. }
  233. /* Called under RCU */
  234. bool br_should_learn(struct net_bridge_port *p, struct sk_buff *skb, u16 *vid)
  235. {
  236. struct net_bridge *br = p->br;
  237. struct net_port_vlans *v;
  238. /* If filtering was disabled at input, let it pass. */
  239. if (!br->vlan_enabled)
  240. return true;
  241. v = rcu_dereference(p->vlan_info);
  242. if (!v)
  243. return false;
  244. if (!br_vlan_get_tag(skb, vid) && skb->vlan_proto != br->vlan_proto)
  245. *vid = 0;
  246. if (!*vid) {
  247. *vid = br_get_pvid(v);
  248. if (!*vid)
  249. return false;
  250. return true;
  251. }
  252. if (test_bit(*vid, v->vlan_bitmap))
  253. return true;
  254. return false;
  255. }
  256. /* Must be protected by RTNL.
  257. * Must be called with vid in range from 1 to 4094 inclusive.
  258. */
  259. int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags)
  260. {
  261. struct net_port_vlans *pv = NULL;
  262. int err;
  263. ASSERT_RTNL();
  264. pv = rtnl_dereference(br->vlan_info);
  265. if (pv)
  266. return __vlan_add(pv, vid, flags);
  267. /* Create port vlan infomration
  268. */
  269. pv = kzalloc(sizeof(*pv), GFP_KERNEL);
  270. if (!pv)
  271. return -ENOMEM;
  272. pv->parent.br = br;
  273. err = __vlan_add(pv, vid, flags);
  274. if (err)
  275. goto out;
  276. rcu_assign_pointer(br->vlan_info, pv);
  277. return 0;
  278. out:
  279. kfree(pv);
  280. return err;
  281. }
  282. /* Must be protected by RTNL.
  283. * Must be called with vid in range from 1 to 4094 inclusive.
  284. */
  285. int br_vlan_delete(struct net_bridge *br, u16 vid)
  286. {
  287. struct net_port_vlans *pv;
  288. ASSERT_RTNL();
  289. pv = rtnl_dereference(br->vlan_info);
  290. if (!pv)
  291. return -EINVAL;
  292. br_fdb_find_delete_local(br, NULL, br->dev->dev_addr, vid);
  293. __vlan_del(pv, vid);
  294. return 0;
  295. }
  296. void br_vlan_flush(struct net_bridge *br)
  297. {
  298. struct net_port_vlans *pv;
  299. ASSERT_RTNL();
  300. pv = rtnl_dereference(br->vlan_info);
  301. if (!pv)
  302. return;
  303. __vlan_flush(pv);
  304. }
  305. bool br_vlan_find(struct net_bridge *br, u16 vid)
  306. {
  307. struct net_port_vlans *pv;
  308. bool found = false;
  309. rcu_read_lock();
  310. pv = rcu_dereference(br->vlan_info);
  311. if (!pv)
  312. goto out;
  313. if (test_bit(vid, pv->vlan_bitmap))
  314. found = true;
  315. out:
  316. rcu_read_unlock();
  317. return found;
  318. }
  319. /* Must be protected by RTNL. */
  320. static void recalculate_group_addr(struct net_bridge *br)
  321. {
  322. if (br->group_addr_set)
  323. return;
  324. spin_lock_bh(&br->lock);
  325. if (!br->vlan_enabled || br->vlan_proto == htons(ETH_P_8021Q)) {
  326. /* Bridge Group Address */
  327. br->group_addr[5] = 0x00;
  328. } else { /* vlan_enabled && ETH_P_8021AD */
  329. /* Provider Bridge Group Address */
  330. br->group_addr[5] = 0x08;
  331. }
  332. spin_unlock_bh(&br->lock);
  333. }
  334. /* Must be protected by RTNL. */
  335. void br_recalculate_fwd_mask(struct net_bridge *br)
  336. {
  337. if (!br->vlan_enabled || br->vlan_proto == htons(ETH_P_8021Q))
  338. br->group_fwd_mask_required = BR_GROUPFWD_DEFAULT;
  339. else /* vlan_enabled && ETH_P_8021AD */
  340. br->group_fwd_mask_required = BR_GROUPFWD_8021AD &
  341. ~(1u << br->group_addr[5]);
  342. }
  343. int br_vlan_filter_toggle(struct net_bridge *br, unsigned long val)
  344. {
  345. if (!rtnl_trylock())
  346. return restart_syscall();
  347. if (br->vlan_enabled == val)
  348. goto unlock;
  349. br->vlan_enabled = val;
  350. br_manage_promisc(br);
  351. recalculate_group_addr(br);
  352. br_recalculate_fwd_mask(br);
  353. unlock:
  354. rtnl_unlock();
  355. return 0;
  356. }
  357. int br_vlan_set_proto(struct net_bridge *br, unsigned long val)
  358. {
  359. int err = 0;
  360. struct net_bridge_port *p;
  361. struct net_port_vlans *pv;
  362. __be16 proto, oldproto;
  363. u16 vid, errvid;
  364. if (val != ETH_P_8021Q && val != ETH_P_8021AD)
  365. return -EPROTONOSUPPORT;
  366. if (!rtnl_trylock())
  367. return restart_syscall();
  368. proto = htons(val);
  369. if (br->vlan_proto == proto)
  370. goto unlock;
  371. /* Add VLANs for the new proto to the device filter. */
  372. list_for_each_entry(p, &br->port_list, list) {
  373. pv = rtnl_dereference(p->vlan_info);
  374. if (!pv)
  375. continue;
  376. for_each_set_bit(vid, pv->vlan_bitmap, VLAN_N_VID) {
  377. err = vlan_vid_add(p->dev, proto, vid);
  378. if (err)
  379. goto err_filt;
  380. }
  381. }
  382. oldproto = br->vlan_proto;
  383. br->vlan_proto = proto;
  384. recalculate_group_addr(br);
  385. br_recalculate_fwd_mask(br);
  386. /* Delete VLANs for the old proto from the device filter. */
  387. list_for_each_entry(p, &br->port_list, list) {
  388. pv = rtnl_dereference(p->vlan_info);
  389. if (!pv)
  390. continue;
  391. for_each_set_bit(vid, pv->vlan_bitmap, VLAN_N_VID)
  392. vlan_vid_del(p->dev, oldproto, vid);
  393. }
  394. unlock:
  395. rtnl_unlock();
  396. return err;
  397. err_filt:
  398. errvid = vid;
  399. for_each_set_bit(vid, pv->vlan_bitmap, errvid)
  400. vlan_vid_del(p->dev, proto, vid);
  401. list_for_each_entry_continue_reverse(p, &br->port_list, list) {
  402. pv = rtnl_dereference(p->vlan_info);
  403. if (!pv)
  404. continue;
  405. for_each_set_bit(vid, pv->vlan_bitmap, VLAN_N_VID)
  406. vlan_vid_del(p->dev, proto, vid);
  407. }
  408. goto unlock;
  409. }
  410. static bool vlan_default_pvid(struct net_port_vlans *pv, u16 vid)
  411. {
  412. return pv && vid == pv->pvid && test_bit(vid, pv->untagged_bitmap);
  413. }
  414. static void br_vlan_disable_default_pvid(struct net_bridge *br)
  415. {
  416. struct net_bridge_port *p;
  417. u16 pvid = br->default_pvid;
  418. /* Disable default_pvid on all ports where it is still
  419. * configured.
  420. */
  421. if (vlan_default_pvid(br_get_vlan_info(br), pvid))
  422. br_vlan_delete(br, pvid);
  423. list_for_each_entry(p, &br->port_list, list) {
  424. if (vlan_default_pvid(nbp_get_vlan_info(p), pvid))
  425. nbp_vlan_delete(p, pvid);
  426. }
  427. br->default_pvid = 0;
  428. }
  429. static int __br_vlan_set_default_pvid(struct net_bridge *br, u16 pvid)
  430. {
  431. struct net_bridge_port *p;
  432. u16 old_pvid;
  433. int err = 0;
  434. unsigned long *changed;
  435. changed = kcalloc(BITS_TO_LONGS(BR_MAX_PORTS), sizeof(unsigned long),
  436. GFP_KERNEL);
  437. if (!changed)
  438. return -ENOMEM;
  439. old_pvid = br->default_pvid;
  440. /* Update default_pvid config only if we do not conflict with
  441. * user configuration.
  442. */
  443. if ((!old_pvid || vlan_default_pvid(br_get_vlan_info(br), old_pvid)) &&
  444. !br_vlan_find(br, pvid)) {
  445. err = br_vlan_add(br, pvid,
  446. BRIDGE_VLAN_INFO_PVID |
  447. BRIDGE_VLAN_INFO_UNTAGGED);
  448. if (err)
  449. goto out;
  450. br_vlan_delete(br, old_pvid);
  451. set_bit(0, changed);
  452. }
  453. list_for_each_entry(p, &br->port_list, list) {
  454. /* Update default_pvid config only if we do not conflict with
  455. * user configuration.
  456. */
  457. if ((old_pvid &&
  458. !vlan_default_pvid(nbp_get_vlan_info(p), old_pvid)) ||
  459. nbp_vlan_find(p, pvid))
  460. continue;
  461. err = nbp_vlan_add(p, pvid,
  462. BRIDGE_VLAN_INFO_PVID |
  463. BRIDGE_VLAN_INFO_UNTAGGED);
  464. if (err)
  465. goto err_port;
  466. nbp_vlan_delete(p, old_pvid);
  467. set_bit(p->port_no, changed);
  468. }
  469. br->default_pvid = pvid;
  470. out:
  471. kfree(changed);
  472. return err;
  473. err_port:
  474. list_for_each_entry_continue_reverse(p, &br->port_list, list) {
  475. if (!test_bit(p->port_no, changed))
  476. continue;
  477. if (old_pvid)
  478. nbp_vlan_add(p, old_pvid,
  479. BRIDGE_VLAN_INFO_PVID |
  480. BRIDGE_VLAN_INFO_UNTAGGED);
  481. nbp_vlan_delete(p, pvid);
  482. }
  483. if (test_bit(0, changed)) {
  484. if (old_pvid)
  485. br_vlan_add(br, old_pvid,
  486. BRIDGE_VLAN_INFO_PVID |
  487. BRIDGE_VLAN_INFO_UNTAGGED);
  488. br_vlan_delete(br, pvid);
  489. }
  490. goto out;
  491. }
  492. int br_vlan_set_default_pvid(struct net_bridge *br, unsigned long val)
  493. {
  494. u16 pvid = val;
  495. int err = 0;
  496. if (val >= VLAN_VID_MASK)
  497. return -EINVAL;
  498. if (!rtnl_trylock())
  499. return restart_syscall();
  500. if (pvid == br->default_pvid)
  501. goto unlock;
  502. /* Only allow default pvid change when filtering is disabled */
  503. if (br->vlan_enabled) {
  504. pr_info_once("Please disable vlan filtering to change default_pvid\n");
  505. err = -EPERM;
  506. goto unlock;
  507. }
  508. if (!pvid)
  509. br_vlan_disable_default_pvid(br);
  510. else
  511. err = __br_vlan_set_default_pvid(br, pvid);
  512. unlock:
  513. rtnl_unlock();
  514. return err;
  515. }
  516. int br_vlan_init(struct net_bridge *br)
  517. {
  518. br->vlan_proto = htons(ETH_P_8021Q);
  519. br->default_pvid = 1;
  520. return br_vlan_add(br, 1,
  521. BRIDGE_VLAN_INFO_PVID | BRIDGE_VLAN_INFO_UNTAGGED);
  522. }
  523. /* Must be protected by RTNL.
  524. * Must be called with vid in range from 1 to 4094 inclusive.
  525. */
  526. int nbp_vlan_add(struct net_bridge_port *port, u16 vid, u16 flags)
  527. {
  528. struct net_port_vlans *pv = NULL;
  529. int err;
  530. ASSERT_RTNL();
  531. pv = rtnl_dereference(port->vlan_info);
  532. if (pv)
  533. return __vlan_add(pv, vid, flags);
  534. /* Create port vlan infomration
  535. */
  536. pv = kzalloc(sizeof(*pv), GFP_KERNEL);
  537. if (!pv) {
  538. err = -ENOMEM;
  539. goto clean_up;
  540. }
  541. pv->port_idx = port->port_no;
  542. pv->parent.port = port;
  543. err = __vlan_add(pv, vid, flags);
  544. if (err)
  545. goto clean_up;
  546. rcu_assign_pointer(port->vlan_info, pv);
  547. return 0;
  548. clean_up:
  549. kfree(pv);
  550. return err;
  551. }
  552. /* Must be protected by RTNL.
  553. * Must be called with vid in range from 1 to 4094 inclusive.
  554. */
  555. int nbp_vlan_delete(struct net_bridge_port *port, u16 vid)
  556. {
  557. struct net_port_vlans *pv;
  558. ASSERT_RTNL();
  559. pv = rtnl_dereference(port->vlan_info);
  560. if (!pv)
  561. return -EINVAL;
  562. br_fdb_find_delete_local(port->br, port, port->dev->dev_addr, vid);
  563. return __vlan_del(pv, vid);
  564. }
  565. void nbp_vlan_flush(struct net_bridge_port *port)
  566. {
  567. struct net_port_vlans *pv;
  568. u16 vid;
  569. ASSERT_RTNL();
  570. pv = rtnl_dereference(port->vlan_info);
  571. if (!pv)
  572. return;
  573. for_each_set_bit(vid, pv->vlan_bitmap, VLAN_N_VID)
  574. vlan_vid_del(port->dev, port->br->vlan_proto, vid);
  575. __vlan_flush(pv);
  576. }
  577. bool nbp_vlan_find(struct net_bridge_port *port, u16 vid)
  578. {
  579. struct net_port_vlans *pv;
  580. bool found = false;
  581. rcu_read_lock();
  582. pv = rcu_dereference(port->vlan_info);
  583. if (!pv)
  584. goto out;
  585. if (test_bit(vid, pv->vlan_bitmap))
  586. found = true;
  587. out:
  588. rcu_read_unlock();
  589. return found;
  590. }
  591. int nbp_vlan_init(struct net_bridge_port *p)
  592. {
  593. return p->br->default_pvid ?
  594. nbp_vlan_add(p, p->br->default_pvid,
  595. BRIDGE_VLAN_INFO_PVID |
  596. BRIDGE_VLAN_INFO_UNTAGGED) :
  597. 0;
  598. }