drm_plane_helper.c 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612
  1. /*
  2. * Copyright (C) 2014 Intel Corporation
  3. *
  4. * DRM universal plane helper functions
  5. *
  6. * Permission is hereby granted, free of charge, to any person obtaining a
  7. * copy of this software and associated documentation files (the "Software"),
  8. * to deal in the Software without restriction, including without limitation
  9. * the rights to use, copy, modify, merge, publish, distribute, sublicense,
  10. * and/or sell copies of the Software, and to permit persons to whom the
  11. * Software is furnished to do so, subject to the following conditions:
  12. *
  13. * The above copyright notice and this permission notice (including the next
  14. * paragraph) shall be included in all copies or substantial portions of the
  15. * Software.
  16. *
  17. * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  18. * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  19. * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
  20. * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  21. * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  22. * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  23. * SOFTWARE.
  24. */
  25. #include <linux/list.h>
  26. #include <drm/drmP.h>
  27. #include <drm/drm_plane_helper.h>
  28. #include <drm/drm_rect.h>
  29. #include <drm/drm_atomic.h>
  30. #include <drm/drm_crtc_helper.h>
  31. #include <drm/drm_atomic_helper.h>
  32. #define SUBPIXEL_MASK 0xffff
  33. /**
  34. * DOC: overview
  35. *
  36. * This helper library has two parts. The first part has support to implement
  37. * primary plane support on top of the normal CRTC configuration interface.
  38. * Since the legacy ->set_config interface ties the primary plane together with
  39. * the CRTC state this does not allow userspace to disable the primary plane
  40. * itself. To avoid too much duplicated code use
  41. * drm_plane_helper_check_update() which can be used to enforce the same
  42. * restrictions as primary planes had thus. The default primary plane only
  43. * expose XRBG8888 and ARGB8888 as valid pixel formats for the attached
  44. * framebuffer.
  45. *
  46. * Drivers are highly recommended to implement proper support for primary
  47. * planes, and newly merged drivers must not rely upon these transitional
  48. * helpers.
  49. *
  50. * The second part also implements transitional helpers which allow drivers to
  51. * gradually switch to the atomic helper infrastructure for plane updates. Once
  52. * that switch is complete drivers shouldn't use these any longer, instead using
  53. * the proper legacy implementations for update and disable plane hooks provided
  54. * by the atomic helpers.
  55. *
  56. * Again drivers are strongly urged to switch to the new interfaces.
  57. *
  58. * The plane helpers share the function table structures with other helpers,
  59. * specifically also the atomic helpers. See struct &drm_plane_helper_funcs for
  60. * the details.
  61. */
  62. /*
  63. * This is the minimal list of formats that seem to be safe for modeset use
  64. * with all current DRM drivers. Most hardware can actually support more
  65. * formats than this and drivers may specify a more accurate list when
  66. * creating the primary plane. However drivers that still call
  67. * drm_plane_init() will use this minimal format list as the default.
  68. */
  69. static const uint32_t safe_modeset_formats[] = {
  70. DRM_FORMAT_XRGB8888,
  71. DRM_FORMAT_ARGB8888,
  72. };
  73. /*
  74. * Returns the connectors currently associated with a CRTC. This function
  75. * should be called twice: once with a NULL connector list to retrieve
  76. * the list size, and once with the properly allocated list to be filled in.
  77. */
  78. static int get_connectors_for_crtc(struct drm_crtc *crtc,
  79. struct drm_connector **connector_list,
  80. int num_connectors)
  81. {
  82. struct drm_device *dev = crtc->dev;
  83. struct drm_connector *connector;
  84. int count = 0;
  85. /*
  86. * Note: Once we change the plane hooks to more fine-grained locking we
  87. * need to grab the connection_mutex here to be able to make these
  88. * checks.
  89. */
  90. WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
  91. drm_for_each_connector(connector, dev) {
  92. if (connector->encoder && connector->encoder->crtc == crtc) {
  93. if (connector_list != NULL && count < num_connectors)
  94. *(connector_list++) = connector;
  95. count++;
  96. }
  97. }
  98. return count;
  99. }
  100. /**
  101. * drm_plane_helper_check_update() - Check plane update for validity
  102. * @plane: plane object to update
  103. * @crtc: owning CRTC of owning plane
  104. * @fb: framebuffer to flip onto plane
  105. * @src: source coordinates in 16.16 fixed point
  106. * @dest: integer destination coordinates
  107. * @clip: integer clipping coordinates
  108. * @rotation: plane rotation
  109. * @min_scale: minimum @src:@dest scaling factor in 16.16 fixed point
  110. * @max_scale: maximum @src:@dest scaling factor in 16.16 fixed point
  111. * @can_position: is it legal to position the plane such that it
  112. * doesn't cover the entire crtc? This will generally
  113. * only be false for primary planes.
  114. * @can_update_disabled: can the plane be updated while the crtc
  115. * is disabled?
  116. * @visible: output parameter indicating whether plane is still visible after
  117. * clipping
  118. *
  119. * Checks that a desired plane update is valid. Drivers that provide
  120. * their own plane handling rather than helper-provided implementations may
  121. * still wish to call this function to avoid duplication of error checking
  122. * code.
  123. *
  124. * RETURNS:
  125. * Zero if update appears valid, error code on failure
  126. */
  127. int drm_plane_helper_check_update(struct drm_plane *plane,
  128. struct drm_crtc *crtc,
  129. struct drm_framebuffer *fb,
  130. struct drm_rect *src,
  131. struct drm_rect *dest,
  132. const struct drm_rect *clip,
  133. unsigned int rotation,
  134. int min_scale,
  135. int max_scale,
  136. bool can_position,
  137. bool can_update_disabled,
  138. bool *visible)
  139. {
  140. int hscale, vscale;
  141. if (!fb) {
  142. *visible = false;
  143. return 0;
  144. }
  145. /* crtc should only be NULL when disabling (i.e., !fb) */
  146. if (WARN_ON(!crtc)) {
  147. *visible = false;
  148. return 0;
  149. }
  150. if (!crtc->enabled && !can_update_disabled) {
  151. DRM_DEBUG_KMS("Cannot update plane of a disabled CRTC.\n");
  152. return -EINVAL;
  153. }
  154. drm_rect_rotate(src, fb->width << 16, fb->height << 16, rotation);
  155. /* Check scaling */
  156. hscale = drm_rect_calc_hscale(src, dest, min_scale, max_scale);
  157. vscale = drm_rect_calc_vscale(src, dest, min_scale, max_scale);
  158. if (hscale < 0 || vscale < 0) {
  159. DRM_DEBUG_KMS("Invalid scaling of plane\n");
  160. drm_rect_debug_print("src: ", src, true);
  161. drm_rect_debug_print("dst: ", dest, false);
  162. return -ERANGE;
  163. }
  164. *visible = drm_rect_clip_scaled(src, dest, clip, hscale, vscale);
  165. drm_rect_rotate_inv(src, fb->width << 16, fb->height << 16, rotation);
  166. if (!*visible)
  167. /*
  168. * Plane isn't visible; some drivers can handle this
  169. * so we just return success here. Drivers that can't
  170. * (including those that use the primary plane helper's
  171. * update function) will return an error from their
  172. * update_plane handler.
  173. */
  174. return 0;
  175. if (!can_position && !drm_rect_equals(dest, clip)) {
  176. DRM_DEBUG_KMS("Plane must cover entire CRTC\n");
  177. drm_rect_debug_print("dst: ", dest, false);
  178. drm_rect_debug_print("clip: ", clip, false);
  179. return -EINVAL;
  180. }
  181. return 0;
  182. }
  183. EXPORT_SYMBOL(drm_plane_helper_check_update);
  184. /**
  185. * drm_primary_helper_update() - Helper for primary plane update
  186. * @plane: plane object to update
  187. * @crtc: owning CRTC of owning plane
  188. * @fb: framebuffer to flip onto plane
  189. * @crtc_x: x offset of primary plane on crtc
  190. * @crtc_y: y offset of primary plane on crtc
  191. * @crtc_w: width of primary plane rectangle on crtc
  192. * @crtc_h: height of primary plane rectangle on crtc
  193. * @src_x: x offset of @fb for panning
  194. * @src_y: y offset of @fb for panning
  195. * @src_w: width of source rectangle in @fb
  196. * @src_h: height of source rectangle in @fb
  197. *
  198. * Provides a default plane update handler for primary planes. This is handler
  199. * is called in response to a userspace SetPlane operation on the plane with a
  200. * non-NULL framebuffer. We call the driver's modeset handler to update the
  201. * framebuffer.
  202. *
  203. * SetPlane() on a primary plane of a disabled CRTC is not supported, and will
  204. * return an error.
  205. *
  206. * Note that we make some assumptions about hardware limitations that may not be
  207. * true for all hardware --
  208. *
  209. * 1. Primary plane cannot be repositioned.
  210. * 2. Primary plane cannot be scaled.
  211. * 3. Primary plane must cover the entire CRTC.
  212. * 4. Subpixel positioning is not supported.
  213. *
  214. * Drivers for hardware that don't have these restrictions can provide their
  215. * own implementation rather than using this helper.
  216. *
  217. * RETURNS:
  218. * Zero on success, error code on failure
  219. */
  220. int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc,
  221. struct drm_framebuffer *fb,
  222. int crtc_x, int crtc_y,
  223. unsigned int crtc_w, unsigned int crtc_h,
  224. uint32_t src_x, uint32_t src_y,
  225. uint32_t src_w, uint32_t src_h)
  226. {
  227. struct drm_mode_set set = {
  228. .crtc = crtc,
  229. .fb = fb,
  230. .mode = &crtc->mode,
  231. .x = src_x >> 16,
  232. .y = src_y >> 16,
  233. };
  234. struct drm_rect src = {
  235. .x1 = src_x,
  236. .y1 = src_y,
  237. .x2 = src_x + src_w,
  238. .y2 = src_y + src_h,
  239. };
  240. struct drm_rect dest = {
  241. .x1 = crtc_x,
  242. .y1 = crtc_y,
  243. .x2 = crtc_x + crtc_w,
  244. .y2 = crtc_y + crtc_h,
  245. };
  246. const struct drm_rect clip = {
  247. .x2 = crtc->mode.hdisplay,
  248. .y2 = crtc->mode.vdisplay,
  249. };
  250. struct drm_connector **connector_list;
  251. int num_connectors, ret;
  252. bool visible;
  253. ret = drm_plane_helper_check_update(plane, crtc, fb,
  254. &src, &dest, &clip,
  255. BIT(DRM_ROTATE_0),
  256. DRM_PLANE_HELPER_NO_SCALING,
  257. DRM_PLANE_HELPER_NO_SCALING,
  258. false, false, &visible);
  259. if (ret)
  260. return ret;
  261. if (!visible)
  262. /*
  263. * Primary plane isn't visible. Note that unless a driver
  264. * provides their own disable function, this will just
  265. * wind up returning -EINVAL to userspace.
  266. */
  267. return plane->funcs->disable_plane(plane);
  268. /* Find current connectors for CRTC */
  269. num_connectors = get_connectors_for_crtc(crtc, NULL, 0);
  270. BUG_ON(num_connectors == 0);
  271. connector_list = kzalloc(num_connectors * sizeof(*connector_list),
  272. GFP_KERNEL);
  273. if (!connector_list)
  274. return -ENOMEM;
  275. get_connectors_for_crtc(crtc, connector_list, num_connectors);
  276. set.connectors = connector_list;
  277. set.num_connectors = num_connectors;
  278. /*
  279. * We call set_config() directly here rather than using
  280. * drm_mode_set_config_internal. We're reprogramming the same
  281. * connectors that were already in use, so we shouldn't need the extra
  282. * cross-CRTC fb refcounting to accomodate stealing connectors.
  283. * drm_mode_setplane() already handles the basic refcounting for the
  284. * framebuffers involved in this operation.
  285. */
  286. ret = crtc->funcs->set_config(&set);
  287. kfree(connector_list);
  288. return ret;
  289. }
  290. EXPORT_SYMBOL(drm_primary_helper_update);
  291. /**
  292. * drm_primary_helper_disable() - Helper for primary plane disable
  293. * @plane: plane to disable
  294. *
  295. * Provides a default plane disable handler for primary planes. This is handler
  296. * is called in response to a userspace SetPlane operation on the plane with a
  297. * NULL framebuffer parameter. It unconditionally fails the disable call with
  298. * -EINVAL the only way to disable the primary plane without driver support is
  299. * to disable the entier CRTC. Which does not match the plane ->disable hook.
  300. *
  301. * Note that some hardware may be able to disable the primary plane without
  302. * disabling the whole CRTC. Drivers for such hardware should provide their
  303. * own disable handler that disables just the primary plane (and they'll likely
  304. * need to provide their own update handler as well to properly re-enable a
  305. * disabled primary plane).
  306. *
  307. * RETURNS:
  308. * Unconditionally returns -EINVAL.
  309. */
  310. int drm_primary_helper_disable(struct drm_plane *plane)
  311. {
  312. return -EINVAL;
  313. }
  314. EXPORT_SYMBOL(drm_primary_helper_disable);
  315. /**
  316. * drm_primary_helper_destroy() - Helper for primary plane destruction
  317. * @plane: plane to destroy
  318. *
  319. * Provides a default plane destroy handler for primary planes. This handler
  320. * is called during CRTC destruction. We disable the primary plane, remove
  321. * it from the DRM plane list, and deallocate the plane structure.
  322. */
  323. void drm_primary_helper_destroy(struct drm_plane *plane)
  324. {
  325. drm_plane_cleanup(plane);
  326. kfree(plane);
  327. }
  328. EXPORT_SYMBOL(drm_primary_helper_destroy);
  329. const struct drm_plane_funcs drm_primary_helper_funcs = {
  330. .update_plane = drm_primary_helper_update,
  331. .disable_plane = drm_primary_helper_disable,
  332. .destroy = drm_primary_helper_destroy,
  333. };
  334. EXPORT_SYMBOL(drm_primary_helper_funcs);
  335. static struct drm_plane *create_primary_plane(struct drm_device *dev)
  336. {
  337. struct drm_plane *primary;
  338. int ret;
  339. primary = kzalloc(sizeof(*primary), GFP_KERNEL);
  340. if (primary == NULL) {
  341. DRM_DEBUG_KMS("Failed to allocate primary plane\n");
  342. return NULL;
  343. }
  344. /*
  345. * Remove the format_default field from drm_plane when dropping
  346. * this helper.
  347. */
  348. primary->format_default = true;
  349. /* possible_crtc's will be filled in later by crtc_init */
  350. ret = drm_universal_plane_init(dev, primary, 0,
  351. &drm_primary_helper_funcs,
  352. safe_modeset_formats,
  353. ARRAY_SIZE(safe_modeset_formats),
  354. DRM_PLANE_TYPE_PRIMARY, NULL);
  355. if (ret) {
  356. kfree(primary);
  357. primary = NULL;
  358. }
  359. return primary;
  360. }
  361. /**
  362. * drm_crtc_init - Legacy CRTC initialization function
  363. * @dev: DRM device
  364. * @crtc: CRTC object to init
  365. * @funcs: callbacks for the new CRTC
  366. *
  367. * Initialize a CRTC object with a default helper-provided primary plane and no
  368. * cursor plane.
  369. *
  370. * Returns:
  371. * Zero on success, error code on failure.
  372. */
  373. int drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc,
  374. const struct drm_crtc_funcs *funcs)
  375. {
  376. struct drm_plane *primary;
  377. primary = create_primary_plane(dev);
  378. return drm_crtc_init_with_planes(dev, crtc, primary, NULL, funcs,
  379. NULL);
  380. }
  381. EXPORT_SYMBOL(drm_crtc_init);
  382. int drm_plane_helper_commit(struct drm_plane *plane,
  383. struct drm_plane_state *plane_state,
  384. struct drm_framebuffer *old_fb)
  385. {
  386. const struct drm_plane_helper_funcs *plane_funcs;
  387. struct drm_crtc *crtc[2];
  388. const struct drm_crtc_helper_funcs *crtc_funcs[2];
  389. int i, ret = 0;
  390. plane_funcs = plane->helper_private;
  391. /* Since this is a transitional helper we can't assume that plane->state
  392. * is always valid. Hence we need to use plane->crtc instead of
  393. * plane->state->crtc as the old crtc. */
  394. crtc[0] = plane->crtc;
  395. crtc[1] = crtc[0] != plane_state->crtc ? plane_state->crtc : NULL;
  396. for (i = 0; i < 2; i++)
  397. crtc_funcs[i] = crtc[i] ? crtc[i]->helper_private : NULL;
  398. if (plane_funcs->atomic_check) {
  399. ret = plane_funcs->atomic_check(plane, plane_state);
  400. if (ret)
  401. goto out;
  402. }
  403. if (plane_funcs->prepare_fb && plane_state->fb &&
  404. plane_state->fb != old_fb) {
  405. ret = plane_funcs->prepare_fb(plane,
  406. plane_state);
  407. if (ret)
  408. goto out;
  409. }
  410. /* Point of no return, commit sw state. */
  411. swap(plane->state, plane_state);
  412. for (i = 0; i < 2; i++) {
  413. if (crtc_funcs[i] && crtc_funcs[i]->atomic_begin)
  414. crtc_funcs[i]->atomic_begin(crtc[i], crtc[i]->state);
  415. }
  416. /*
  417. * Drivers may optionally implement the ->atomic_disable callback, so
  418. * special-case that here.
  419. */
  420. if (drm_atomic_plane_disabling(plane, plane_state) &&
  421. plane_funcs->atomic_disable)
  422. plane_funcs->atomic_disable(plane, plane_state);
  423. else
  424. plane_funcs->atomic_update(plane, plane_state);
  425. for (i = 0; i < 2; i++) {
  426. if (crtc_funcs[i] && crtc_funcs[i]->atomic_flush)
  427. crtc_funcs[i]->atomic_flush(crtc[i], crtc[i]->state);
  428. }
  429. /*
  430. * If we only moved the plane and didn't change fb's, there's no need to
  431. * wait for vblank.
  432. */
  433. if (plane->state->fb == old_fb)
  434. goto out;
  435. for (i = 0; i < 2; i++) {
  436. if (!crtc[i])
  437. continue;
  438. if (crtc[i]->cursor == plane)
  439. continue;
  440. /* There's no other way to figure out whether the crtc is running. */
  441. ret = drm_crtc_vblank_get(crtc[i]);
  442. if (ret == 0) {
  443. drm_crtc_wait_one_vblank(crtc[i]);
  444. drm_crtc_vblank_put(crtc[i]);
  445. }
  446. ret = 0;
  447. }
  448. if (plane_funcs->cleanup_fb)
  449. plane_funcs->cleanup_fb(plane, plane_state);
  450. out:
  451. if (plane_state) {
  452. if (plane->funcs->atomic_destroy_state)
  453. plane->funcs->atomic_destroy_state(plane, plane_state);
  454. else
  455. drm_atomic_helper_plane_destroy_state(plane, plane_state);
  456. }
  457. return ret;
  458. }
  459. /**
  460. * drm_plane_helper_update() - Transitional helper for plane update
  461. * @plane: plane object to update
  462. * @crtc: owning CRTC of owning plane
  463. * @fb: framebuffer to flip onto plane
  464. * @crtc_x: x offset of primary plane on crtc
  465. * @crtc_y: y offset of primary plane on crtc
  466. * @crtc_w: width of primary plane rectangle on crtc
  467. * @crtc_h: height of primary plane rectangle on crtc
  468. * @src_x: x offset of @fb for panning
  469. * @src_y: y offset of @fb for panning
  470. * @src_w: width of source rectangle in @fb
  471. * @src_h: height of source rectangle in @fb
  472. *
  473. * Provides a default plane update handler using the atomic plane update
  474. * functions. It is fully left to the driver to check plane constraints and
  475. * handle corner-cases like a fully occluded or otherwise invisible plane.
  476. *
  477. * This is useful for piecewise transitioning of a driver to the atomic helpers.
  478. *
  479. * RETURNS:
  480. * Zero on success, error code on failure
  481. */
  482. int drm_plane_helper_update(struct drm_plane *plane, struct drm_crtc *crtc,
  483. struct drm_framebuffer *fb,
  484. int crtc_x, int crtc_y,
  485. unsigned int crtc_w, unsigned int crtc_h,
  486. uint32_t src_x, uint32_t src_y,
  487. uint32_t src_w, uint32_t src_h)
  488. {
  489. struct drm_plane_state *plane_state;
  490. if (plane->funcs->atomic_duplicate_state)
  491. plane_state = plane->funcs->atomic_duplicate_state(plane);
  492. else {
  493. if (!plane->state)
  494. drm_atomic_helper_plane_reset(plane);
  495. plane_state = drm_atomic_helper_plane_duplicate_state(plane);
  496. }
  497. if (!plane_state)
  498. return -ENOMEM;
  499. plane_state->plane = plane;
  500. plane_state->crtc = crtc;
  501. drm_atomic_set_fb_for_plane(plane_state, fb);
  502. plane_state->crtc_x = crtc_x;
  503. plane_state->crtc_y = crtc_y;
  504. plane_state->crtc_h = crtc_h;
  505. plane_state->crtc_w = crtc_w;
  506. plane_state->src_x = src_x;
  507. plane_state->src_y = src_y;
  508. plane_state->src_h = src_h;
  509. plane_state->src_w = src_w;
  510. return drm_plane_helper_commit(plane, plane_state, plane->fb);
  511. }
  512. EXPORT_SYMBOL(drm_plane_helper_update);
  513. /**
  514. * drm_plane_helper_disable() - Transitional helper for plane disable
  515. * @plane: plane to disable
  516. *
  517. * Provides a default plane disable handler using the atomic plane update
  518. * functions. It is fully left to the driver to check plane constraints and
  519. * handle corner-cases like a fully occluded or otherwise invisible plane.
  520. *
  521. * This is useful for piecewise transitioning of a driver to the atomic helpers.
  522. *
  523. * RETURNS:
  524. * Zero on success, error code on failure
  525. */
  526. int drm_plane_helper_disable(struct drm_plane *plane)
  527. {
  528. struct drm_plane_state *plane_state;
  529. /* crtc helpers love to call disable functions for already disabled hw
  530. * functions. So cope with that. */
  531. if (!plane->crtc)
  532. return 0;
  533. if (plane->funcs->atomic_duplicate_state)
  534. plane_state = plane->funcs->atomic_duplicate_state(plane);
  535. else {
  536. if (!plane->state)
  537. drm_atomic_helper_plane_reset(plane);
  538. plane_state = drm_atomic_helper_plane_duplicate_state(plane);
  539. }
  540. if (!plane_state)
  541. return -ENOMEM;
  542. plane_state->plane = plane;
  543. plane_state->crtc = NULL;
  544. drm_atomic_set_fb_for_plane(plane_state, NULL);
  545. return drm_plane_helper_commit(plane, plane_state, plane->fb);
  546. }
  547. EXPORT_SYMBOL(drm_plane_helper_disable);