intel_dvo.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576
  1. /*
  2. * Copyright 2006 Dave Airlie <airlied@linux.ie>
  3. * Copyright © 2006-2007 Intel Corporation
  4. *
  5. * Permission is hereby granted, free of charge, to any person obtaining a
  6. * copy of this software and associated documentation files (the "Software"),
  7. * to deal in the Software without restriction, including without limitation
  8. * the rights to use, copy, modify, merge, publish, distribute, sublicense,
  9. * and/or sell copies of the Software, and to permit persons to whom the
  10. * Software is furnished to do so, subject to the following conditions:
  11. *
  12. * The above copyright notice and this permission notice (including the next
  13. * paragraph) shall be included in all copies or substantial portions of the
  14. * Software.
  15. *
  16. * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17. * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18. * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
  19. * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20. * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  21. * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  22. * DEALINGS IN THE SOFTWARE.
  23. *
  24. * Authors:
  25. * Eric Anholt <eric@anholt.net>
  26. */
  27. #include <linux/i2c.h>
  28. #include <linux/slab.h>
  29. #include <drm/drmP.h>
  30. #include <drm/drm_crtc.h>
  31. #include "intel_drv.h"
  32. #include <drm/i915_drm.h>
  33. #include "i915_drv.h"
  34. #include "dvo.h"
  35. #define SIL164_ADDR 0x38
  36. #define CH7xxx_ADDR 0x76
  37. #define TFP410_ADDR 0x38
  38. #define NS2501_ADDR 0x38
  39. static const struct intel_dvo_device intel_dvo_devices[] = {
  40. {
  41. .type = INTEL_DVO_CHIP_TMDS,
  42. .name = "sil164",
  43. .dvo_reg = DVOC,
  44. .slave_addr = SIL164_ADDR,
  45. .dev_ops = &sil164_ops,
  46. },
  47. {
  48. .type = INTEL_DVO_CHIP_TMDS,
  49. .name = "ch7xxx",
  50. .dvo_reg = DVOC,
  51. .slave_addr = CH7xxx_ADDR,
  52. .dev_ops = &ch7xxx_ops,
  53. },
  54. {
  55. .type = INTEL_DVO_CHIP_TMDS,
  56. .name = "ch7xxx",
  57. .dvo_reg = DVOC,
  58. .slave_addr = 0x75, /* For some ch7010 */
  59. .dev_ops = &ch7xxx_ops,
  60. },
  61. {
  62. .type = INTEL_DVO_CHIP_LVDS,
  63. .name = "ivch",
  64. .dvo_reg = DVOA,
  65. .slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
  66. .dev_ops = &ivch_ops,
  67. },
  68. {
  69. .type = INTEL_DVO_CHIP_TMDS,
  70. .name = "tfp410",
  71. .dvo_reg = DVOC,
  72. .slave_addr = TFP410_ADDR,
  73. .dev_ops = &tfp410_ops,
  74. },
  75. {
  76. .type = INTEL_DVO_CHIP_LVDS,
  77. .name = "ch7017",
  78. .dvo_reg = DVOC,
  79. .slave_addr = 0x75,
  80. .gpio = GMBUS_PORT_DPB,
  81. .dev_ops = &ch7017_ops,
  82. },
  83. {
  84. .type = INTEL_DVO_CHIP_TMDS,
  85. .name = "ns2501",
  86. .dvo_reg = DVOC,
  87. .slave_addr = NS2501_ADDR,
  88. .dev_ops = &ns2501_ops,
  89. }
  90. };
  91. struct intel_dvo {
  92. struct intel_encoder base;
  93. struct intel_dvo_device dev;
  94. struct drm_display_mode *panel_fixed_mode;
  95. bool panel_wants_dither;
  96. };
  97. static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
  98. {
  99. return container_of(encoder, struct intel_dvo, base);
  100. }
  101. static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
  102. {
  103. return enc_to_dvo(intel_attached_encoder(connector));
  104. }
  105. static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
  106. {
  107. struct drm_device *dev = connector->base.dev;
  108. struct drm_i915_private *dev_priv = dev->dev_private;
  109. struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
  110. u32 tmp;
  111. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  112. if (!(tmp & DVO_ENABLE))
  113. return false;
  114. return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
  115. }
  116. static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
  117. enum pipe *pipe)
  118. {
  119. struct drm_device *dev = encoder->base.dev;
  120. struct drm_i915_private *dev_priv = dev->dev_private;
  121. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  122. u32 tmp;
  123. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  124. if (!(tmp & DVO_ENABLE))
  125. return false;
  126. *pipe = PORT_TO_PIPE(tmp);
  127. return true;
  128. }
  129. static void intel_dvo_get_config(struct intel_encoder *encoder,
  130. struct intel_crtc_config *pipe_config)
  131. {
  132. struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
  133. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  134. u32 tmp, flags = 0;
  135. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  136. if (tmp & DVO_HSYNC_ACTIVE_HIGH)
  137. flags |= DRM_MODE_FLAG_PHSYNC;
  138. else
  139. flags |= DRM_MODE_FLAG_NHSYNC;
  140. if (tmp & DVO_VSYNC_ACTIVE_HIGH)
  141. flags |= DRM_MODE_FLAG_PVSYNC;
  142. else
  143. flags |= DRM_MODE_FLAG_NVSYNC;
  144. pipe_config->adjusted_mode.flags |= flags;
  145. pipe_config->adjusted_mode.crtc_clock = pipe_config->port_clock;
  146. }
  147. static void intel_disable_dvo(struct intel_encoder *encoder)
  148. {
  149. struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
  150. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  151. u32 dvo_reg = intel_dvo->dev.dvo_reg;
  152. u32 temp = I915_READ(dvo_reg);
  153. intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
  154. I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
  155. I915_READ(dvo_reg);
  156. }
  157. static void intel_enable_dvo(struct intel_encoder *encoder)
  158. {
  159. struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
  160. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  161. struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
  162. u32 dvo_reg = intel_dvo->dev.dvo_reg;
  163. u32 temp = I915_READ(dvo_reg);
  164. I915_WRITE(dvo_reg, temp | DVO_ENABLE);
  165. I915_READ(dvo_reg);
  166. intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
  167. &crtc->config.requested_mode,
  168. &crtc->config.adjusted_mode);
  169. intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
  170. }
  171. /* Special dpms function to support cloning between dvo/sdvo/crt. */
  172. static void intel_dvo_dpms(struct drm_connector *connector, int mode)
  173. {
  174. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  175. struct drm_crtc *crtc;
  176. struct intel_crtc_config *config;
  177. /* dvo supports only 2 dpms states. */
  178. if (mode != DRM_MODE_DPMS_ON)
  179. mode = DRM_MODE_DPMS_OFF;
  180. if (mode == connector->dpms)
  181. return;
  182. connector->dpms = mode;
  183. /* Only need to change hw state when actually enabled */
  184. crtc = intel_dvo->base.base.crtc;
  185. if (!crtc) {
  186. intel_dvo->base.connectors_active = false;
  187. return;
  188. }
  189. /* We call connector dpms manually below in case pipe dpms doesn't
  190. * change due to cloning. */
  191. if (mode == DRM_MODE_DPMS_ON) {
  192. config = &to_intel_crtc(crtc)->config;
  193. intel_dvo->base.connectors_active = true;
  194. intel_crtc_update_dpms(crtc);
  195. intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
  196. &config->requested_mode,
  197. &config->adjusted_mode);
  198. intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
  199. } else {
  200. intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
  201. intel_dvo->base.connectors_active = false;
  202. intel_crtc_update_dpms(crtc);
  203. }
  204. intel_modeset_check_state(connector->dev);
  205. }
  206. static enum drm_mode_status
  207. intel_dvo_mode_valid(struct drm_connector *connector,
  208. struct drm_display_mode *mode)
  209. {
  210. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  211. if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
  212. return MODE_NO_DBLESCAN;
  213. /* XXX: Validate clock range */
  214. if (intel_dvo->panel_fixed_mode) {
  215. if (mode->hdisplay > intel_dvo->panel_fixed_mode->hdisplay)
  216. return MODE_PANEL;
  217. if (mode->vdisplay > intel_dvo->panel_fixed_mode->vdisplay)
  218. return MODE_PANEL;
  219. }
  220. return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
  221. }
  222. static bool intel_dvo_compute_config(struct intel_encoder *encoder,
  223. struct intel_crtc_config *pipe_config)
  224. {
  225. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  226. struct drm_display_mode *adjusted_mode = &pipe_config->adjusted_mode;
  227. /* If we have timings from the BIOS for the panel, put them in
  228. * to the adjusted mode. The CRTC will be set up for this mode,
  229. * with the panel scaling set up to source from the H/VDisplay
  230. * of the original mode.
  231. */
  232. if (intel_dvo->panel_fixed_mode != NULL) {
  233. #define C(x) adjusted_mode->x = intel_dvo->panel_fixed_mode->x
  234. C(hdisplay);
  235. C(hsync_start);
  236. C(hsync_end);
  237. C(htotal);
  238. C(vdisplay);
  239. C(vsync_start);
  240. C(vsync_end);
  241. C(vtotal);
  242. C(clock);
  243. #undef C
  244. drm_mode_set_crtcinfo(adjusted_mode, 0);
  245. }
  246. return true;
  247. }
  248. static void intel_dvo_pre_enable(struct intel_encoder *encoder)
  249. {
  250. struct drm_device *dev = encoder->base.dev;
  251. struct drm_i915_private *dev_priv = dev->dev_private;
  252. struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
  253. struct drm_display_mode *adjusted_mode = &crtc->config.adjusted_mode;
  254. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  255. int pipe = crtc->pipe;
  256. u32 dvo_val;
  257. u32 dvo_reg = intel_dvo->dev.dvo_reg, dvo_srcdim_reg;
  258. switch (dvo_reg) {
  259. case DVOA:
  260. default:
  261. dvo_srcdim_reg = DVOA_SRCDIM;
  262. break;
  263. case DVOB:
  264. dvo_srcdim_reg = DVOB_SRCDIM;
  265. break;
  266. case DVOC:
  267. dvo_srcdim_reg = DVOC_SRCDIM;
  268. break;
  269. }
  270. /* Save the data order, since I don't know what it should be set to. */
  271. dvo_val = I915_READ(dvo_reg) &
  272. (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
  273. dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
  274. DVO_BLANK_ACTIVE_HIGH;
  275. if (pipe == 1)
  276. dvo_val |= DVO_PIPE_B_SELECT;
  277. dvo_val |= DVO_PIPE_STALL;
  278. if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
  279. dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
  280. if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
  281. dvo_val |= DVO_VSYNC_ACTIVE_HIGH;
  282. /*I915_WRITE(DVOB_SRCDIM,
  283. (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
  284. (adjusted_mode->VDisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
  285. I915_WRITE(dvo_srcdim_reg,
  286. (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
  287. (adjusted_mode->vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
  288. /*I915_WRITE(DVOB, dvo_val);*/
  289. I915_WRITE(dvo_reg, dvo_val);
  290. }
  291. /**
  292. * Detect the output connection on our DVO device.
  293. *
  294. * Unimplemented.
  295. */
  296. static enum drm_connector_status
  297. intel_dvo_detect(struct drm_connector *connector, bool force)
  298. {
  299. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  300. DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
  301. connector->base.id, connector->name);
  302. return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
  303. }
  304. static int intel_dvo_get_modes(struct drm_connector *connector)
  305. {
  306. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  307. struct drm_i915_private *dev_priv = connector->dev->dev_private;
  308. /* We should probably have an i2c driver get_modes function for those
  309. * devices which will have a fixed set of modes determined by the chip
  310. * (TV-out, for example), but for now with just TMDS and LVDS,
  311. * that's not the case.
  312. */
  313. intel_ddc_get_modes(connector,
  314. intel_gmbus_get_adapter(dev_priv, GMBUS_PORT_DPC));
  315. if (!list_empty(&connector->probed_modes))
  316. return 1;
  317. if (intel_dvo->panel_fixed_mode != NULL) {
  318. struct drm_display_mode *mode;
  319. mode = drm_mode_duplicate(connector->dev, intel_dvo->panel_fixed_mode);
  320. if (mode) {
  321. drm_mode_probed_add(connector, mode);
  322. return 1;
  323. }
  324. }
  325. return 0;
  326. }
  327. static void intel_dvo_destroy(struct drm_connector *connector)
  328. {
  329. drm_connector_cleanup(connector);
  330. kfree(connector);
  331. }
  332. static const struct drm_connector_funcs intel_dvo_connector_funcs = {
  333. .dpms = intel_dvo_dpms,
  334. .detect = intel_dvo_detect,
  335. .destroy = intel_dvo_destroy,
  336. .fill_modes = drm_helper_probe_single_connector_modes,
  337. };
  338. static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
  339. .mode_valid = intel_dvo_mode_valid,
  340. .get_modes = intel_dvo_get_modes,
  341. .best_encoder = intel_best_encoder,
  342. };
  343. static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
  344. {
  345. struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
  346. if (intel_dvo->dev.dev_ops->destroy)
  347. intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);
  348. kfree(intel_dvo->panel_fixed_mode);
  349. intel_encoder_destroy(encoder);
  350. }
  351. static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
  352. .destroy = intel_dvo_enc_destroy,
  353. };
  354. /**
  355. * Attempts to get a fixed panel timing for LVDS (currently only the i830).
  356. *
  357. * Other chips with DVO LVDS will need to extend this to deal with the LVDS
  358. * chip being on DVOB/C and having multiple pipes.
  359. */
  360. static struct drm_display_mode *
  361. intel_dvo_get_current_mode(struct drm_connector *connector)
  362. {
  363. struct drm_device *dev = connector->dev;
  364. struct drm_i915_private *dev_priv = dev->dev_private;
  365. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  366. uint32_t dvo_val = I915_READ(intel_dvo->dev.dvo_reg);
  367. struct drm_display_mode *mode = NULL;
  368. /* If the DVO port is active, that'll be the LVDS, so we can pull out
  369. * its timings to get how the BIOS set up the panel.
  370. */
  371. if (dvo_val & DVO_ENABLE) {
  372. struct drm_crtc *crtc;
  373. int pipe = (dvo_val & DVO_PIPE_B_SELECT) ? 1 : 0;
  374. crtc = intel_get_crtc_for_pipe(dev, pipe);
  375. if (crtc) {
  376. mode = intel_crtc_mode_get(dev, crtc);
  377. if (mode) {
  378. mode->type |= DRM_MODE_TYPE_PREFERRED;
  379. if (dvo_val & DVO_HSYNC_ACTIVE_HIGH)
  380. mode->flags |= DRM_MODE_FLAG_PHSYNC;
  381. if (dvo_val & DVO_VSYNC_ACTIVE_HIGH)
  382. mode->flags |= DRM_MODE_FLAG_PVSYNC;
  383. }
  384. }
  385. }
  386. return mode;
  387. }
  388. void intel_dvo_init(struct drm_device *dev)
  389. {
  390. struct drm_i915_private *dev_priv = dev->dev_private;
  391. struct intel_encoder *intel_encoder;
  392. struct intel_dvo *intel_dvo;
  393. struct intel_connector *intel_connector;
  394. int i;
  395. int encoder_type = DRM_MODE_ENCODER_NONE;
  396. intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
  397. if (!intel_dvo)
  398. return;
  399. intel_connector = kzalloc(sizeof(*intel_connector), GFP_KERNEL);
  400. if (!intel_connector) {
  401. kfree(intel_dvo);
  402. return;
  403. }
  404. intel_encoder = &intel_dvo->base;
  405. drm_encoder_init(dev, &intel_encoder->base,
  406. &intel_dvo_enc_funcs, encoder_type);
  407. intel_encoder->disable = intel_disable_dvo;
  408. intel_encoder->enable = intel_enable_dvo;
  409. intel_encoder->get_hw_state = intel_dvo_get_hw_state;
  410. intel_encoder->get_config = intel_dvo_get_config;
  411. intel_encoder->compute_config = intel_dvo_compute_config;
  412. intel_encoder->pre_enable = intel_dvo_pre_enable;
  413. intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
  414. intel_connector->unregister = intel_connector_unregister;
  415. /* Now, try to find a controller */
  416. for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
  417. struct drm_connector *connector = &intel_connector->base;
  418. const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
  419. struct i2c_adapter *i2c;
  420. int gpio;
  421. bool dvoinit;
  422. /* Allow the I2C driver info to specify the GPIO to be used in
  423. * special cases, but otherwise default to what's defined
  424. * in the spec.
  425. */
  426. if (intel_gmbus_is_port_valid(dvo->gpio))
  427. gpio = dvo->gpio;
  428. else if (dvo->type == INTEL_DVO_CHIP_LVDS)
  429. gpio = GMBUS_PORT_SSC;
  430. else
  431. gpio = GMBUS_PORT_DPB;
  432. /* Set up the I2C bus necessary for the chip we're probing.
  433. * It appears that everything is on GPIOE except for panels
  434. * on i830 laptops, which are on GPIOB (DVOA).
  435. */
  436. i2c = intel_gmbus_get_adapter(dev_priv, gpio);
  437. intel_dvo->dev = *dvo;
  438. /* GMBUS NAK handling seems to be unstable, hence let the
  439. * transmitter detection run in bit banging mode for now.
  440. */
  441. intel_gmbus_force_bit(i2c, true);
  442. dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);
  443. intel_gmbus_force_bit(i2c, false);
  444. if (!dvoinit)
  445. continue;
  446. intel_encoder->type = INTEL_OUTPUT_DVO;
  447. intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
  448. switch (dvo->type) {
  449. case INTEL_DVO_CHIP_TMDS:
  450. intel_encoder->cloneable = (1 << INTEL_OUTPUT_ANALOG) |
  451. (1 << INTEL_OUTPUT_DVO);
  452. drm_connector_init(dev, connector,
  453. &intel_dvo_connector_funcs,
  454. DRM_MODE_CONNECTOR_DVII);
  455. encoder_type = DRM_MODE_ENCODER_TMDS;
  456. break;
  457. case INTEL_DVO_CHIP_LVDS:
  458. intel_encoder->cloneable = 0;
  459. drm_connector_init(dev, connector,
  460. &intel_dvo_connector_funcs,
  461. DRM_MODE_CONNECTOR_LVDS);
  462. encoder_type = DRM_MODE_ENCODER_LVDS;
  463. break;
  464. }
  465. drm_connector_helper_add(connector,
  466. &intel_dvo_connector_helper_funcs);
  467. connector->display_info.subpixel_order = SubPixelHorizontalRGB;
  468. connector->interlace_allowed = false;
  469. connector->doublescan_allowed = false;
  470. intel_connector_attach_encoder(intel_connector, intel_encoder);
  471. if (dvo->type == INTEL_DVO_CHIP_LVDS) {
  472. /* For our LVDS chipsets, we should hopefully be able
  473. * to dig the fixed panel mode out of the BIOS data.
  474. * However, it's in a different format from the BIOS
  475. * data on chipsets with integrated LVDS (stored in AIM
  476. * headers, likely), so for now, just get the current
  477. * mode being output through DVO.
  478. */
  479. intel_dvo->panel_fixed_mode =
  480. intel_dvo_get_current_mode(connector);
  481. intel_dvo->panel_wants_dither = true;
  482. }
  483. drm_connector_register(connector);
  484. return;
  485. }
  486. drm_encoder_cleanup(&intel_encoder->base);
  487. kfree(intel_dvo);
  488. kfree(intel_connector);
  489. }