|
@@ -670,10 +670,8 @@ static int cx231xx_audio_init(struct cx231xx *dev)
|
|
|
|
|
|
spin_lock_init(&adev->slock);
|
|
|
err = snd_pcm_new(card, "Cx231xx Audio", 0, 0, 1, &pcm);
|
|
|
- if (err < 0) {
|
|
|
- snd_card_free(card);
|
|
|
- return err;
|
|
|
- }
|
|
|
+ if (err < 0)
|
|
|
+ goto err_free_card;
|
|
|
|
|
|
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE,
|
|
|
&snd_cx231xx_pcm_capture);
|
|
@@ -687,10 +685,9 @@ static int cx231xx_audio_init(struct cx231xx *dev)
|
|
|
INIT_WORK(&dev->wq_trigger, audio_trigger);
|
|
|
|
|
|
err = snd_card_register(card);
|
|
|
- if (err < 0) {
|
|
|
- snd_card_free(card);
|
|
|
- return err;
|
|
|
- }
|
|
|
+ if (err < 0)
|
|
|
+ goto err_free_card;
|
|
|
+
|
|
|
adev->sndcard = card;
|
|
|
adev->udev = dev->udev;
|
|
|
|
|
@@ -709,9 +706,10 @@ static int cx231xx_audio_init(struct cx231xx *dev)
|
|
|
"audio EndPoint Addr 0x%x, Alternate settings: %i\n",
|
|
|
adev->end_point_addr, adev->num_alt);
|
|
|
adev->alt_max_pkt_size = kmalloc(32 * adev->num_alt, GFP_KERNEL);
|
|
|
-
|
|
|
- if (adev->alt_max_pkt_size == NULL)
|
|
|
- return -ENOMEM;
|
|
|
+ if (!adev->alt_max_pkt_size) {
|
|
|
+ err = -ENOMEM;
|
|
|
+ goto err_free_card;
|
|
|
+ }
|
|
|
|
|
|
for (i = 0; i < adev->num_alt; i++) {
|
|
|
u16 tmp =
|
|
@@ -725,6 +723,11 @@ static int cx231xx_audio_init(struct cx231xx *dev)
|
|
|
}
|
|
|
|
|
|
return 0;
|
|
|
+
|
|
|
+err_free_card:
|
|
|
+ snd_card_free(card);
|
|
|
+
|
|
|
+ return err;
|
|
|
}
|
|
|
|
|
|
static int cx231xx_audio_fini(struct cx231xx *dev)
|