Browse Source

[media] s2255drv: fix sparse warning

drivers/media/usb/s2255/s2255drv.c:2248:20: warning: cast to restricted __le16

At the USB structs there are two different idProduct:
	usb_device_id::idProduct - already on CPU endiannes
	usb_device::descriptor.idProduct - with is LE16

In this specific case, the driver checks for the one at usb_device_id
struct, with already have CPU endianness. So, no conversion is required.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Hans Verkuil 11 years ago
parent
commit
ff3ec57df9
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/media/usb/s2255/s2255drv.c

+ 1 - 1
drivers/media/usb/s2255/s2255drv.c

@@ -2245,7 +2245,7 @@ static int s2255_probe(struct usb_interface *interface,
 	}
 	}
 
 
 	atomic_set(&dev->num_channels, 0);
 	atomic_set(&dev->num_channels, 0);
-	dev->pid = le16_to_cpu(id->idProduct);
+	dev->pid = id->idProduct;
 	dev->fw_data = kzalloc(sizeof(struct s2255_fw), GFP_KERNEL);
 	dev->fw_data = kzalloc(sizeof(struct s2255_fw), GFP_KERNEL);
 	if (!dev->fw_data)
 	if (!dev->fw_data)
 		goto errorFWDATA1;
 		goto errorFWDATA1;