Browse Source

hp_accel: Silence an uninitialized variable warning

If acpi_evaluate_integer() fails then "lret" isn't initialized.  I've
tweaked the error handling to avoid this issue.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Dan Carpenter 9 years ago
parent
commit
ff22b4806d
1 changed files with 3 additions and 1 deletions
  1. 3 1
      drivers/platform/x86/hp_accel.c

+ 3 - 1
drivers/platform/x86/hp_accel.c

@@ -127,8 +127,10 @@ static int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret)
 	arg0.integer.value = reg;
 	arg0.integer.value = reg;
 
 
 	status = acpi_evaluate_integer(dev->handle, "ALRD", &args, &lret);
 	status = acpi_evaluate_integer(dev->handle, "ALRD", &args, &lret);
+	if (ACPI_FAILURE(status))
+		return -EINVAL;
 	*ret = lret;
 	*ret = lret;
-	return (status != AE_OK) ? -EINVAL : 0;
+	return 0;
 }
 }
 
 
 /**
 /**