Browse Source

drm/msm: dsi: Return errors whan dt parsing fails

If dt parsing fails, we should return an error instead of pretending
everything completed successfully.

Cc: Doug Anderson <dianders@chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>

Signed-off-by: Rob Clark <robdclark@gmail.com>
Sean Paul 7 years ago
parent
commit
feb085ec8a
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/gpu/drm/msm/dsi/dsi_host.c

+ 2 - 0
drivers/gpu/drm/msm/dsi/dsi_host.c

@@ -1750,6 +1750,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host *msm_host)
 	if (ret) {
 	if (ret) {
 		dev_err(dev, "%s: invalid lane configuration %d\n",
 		dev_err(dev, "%s: invalid lane configuration %d\n",
 			__func__, ret);
 			__func__, ret);
+		ret = -EINVAL;
 		goto err;
 		goto err;
 	}
 	}
 
 
@@ -1757,6 +1758,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host *msm_host)
 	device_node = of_graph_get_remote_node(np, 1, 0);
 	device_node = of_graph_get_remote_node(np, 1, 0);
 	if (!device_node) {
 	if (!device_node) {
 		dev_dbg(dev, "%s: no valid device\n", __func__);
 		dev_dbg(dev, "%s: no valid device\n", __func__);
+		ret = -ENODEV;
 		goto err;
 		goto err;
 	}
 	}