Explorar o código

drm/amdgpu: use WARN_ON_ONCE instead of BUG_ON in the SA

Crashing the system doesn't helps at all. Also properly return
-EINVAL if size or alignment are outside valid ranges.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Christian König %!s(int64=9) %!d(string=hai) anos
pai
achega
fe6b2ad91f
Modificáronse 1 ficheiros con 5 adicións e 2 borrados
  1. 5 2
      drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c

+ 5 - 2
drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c

@@ -321,8 +321,11 @@ int amdgpu_sa_bo_new(struct amdgpu_sa_manager *sa_manager,
 	int i, r;
 	signed long t;
 
-	BUG_ON(align > sa_manager->align);
-	BUG_ON(size > sa_manager->size);
+	if (WARN_ON_ONCE(align > sa_manager->align))
+		return -EINVAL;
+
+	if (WARN_ON_ONCE(size > sa_manager->size))
+		return -EINVAL;
 
 	*sa_bo = kmalloc(sizeof(struct amdgpu_sa_bo), GFP_KERNEL);
 	if ((*sa_bo) == NULL) {