浏览代码

mfd: dm355evm_mps: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Linus Walleij 9 年之前
父节点
当前提交
fe0b486729
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/mfd/dm355evm_msp.c

+ 1 - 1
drivers/mfd/dm355evm_msp.c

@@ -147,7 +147,7 @@ static int msp_gpio_get(struct gpio_chip *chip, unsigned offset)
 		return status;
 		return status;
 	if (reg == DM355EVM_MSP_LED)
 	if (reg == DM355EVM_MSP_LED)
 		msp_led_cache = status;
 		msp_led_cache = status;
-	return status & MSP_GPIO_MASK(offset);
+	return !!(status & MSP_GPIO_MASK(offset));
 }
 }
 
 
 static int msp_gpio_out(struct gpio_chip *chip, unsigned offset, int value)
 static int msp_gpio_out(struct gpio_chip *chip, unsigned offset, int value)