Browse Source

[media] v4l2-common: Delete an unnecessary check before the function call "spi_unregister_device"

The spi_unregister_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Markus Elfring 9 years ago
parent
commit
fe094dad25
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/media/v4l2-core/v4l2-common.c

+ 1 - 1
drivers/media/v4l2-core/v4l2-common.c

@@ -291,7 +291,7 @@ struct v4l2_subdev *v4l2_spi_new_subdev(struct v4l2_device *v4l2_dev,
 error:
 error:
 	/* If we have a client but no subdev, then something went wrong and
 	/* If we have a client but no subdev, then something went wrong and
 	   we must unregister the client. */
 	   we must unregister the client. */
-	if (spi && sd == NULL)
+	if (!sd)
 		spi_unregister_device(spi);
 		spi_unregister_device(spi);
 
 
 	return sd;
 	return sd;