فهرست منبع

HID: roccat: Fix an error message when reading more data from bin attributes

Using cat or something to read from binary attributes would try to do an
additional read with offset equal to filesize. This resulted in an invalid
attribute error. This is fixed by giving the right answer instead of EINVAL.

Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Stefan Achatz 15 سال پیش
والد
کامیت
fd82be6c0a
1فایلهای تغییر یافته به همراه3 افزوده شده و 0 حذف شده
  1. 3 0
      drivers/hid/hid-roccat-koneplus.c

+ 3 - 0
drivers/hid/hid-roccat-koneplus.c

@@ -258,6 +258,9 @@ static ssize_t koneplus_sysfs_read(struct file *fp, struct kobject *kobj,
 	struct usb_device *usb_dev = interface_to_usbdev(to_usb_interface(dev));
 	struct usb_device *usb_dev = interface_to_usbdev(to_usb_interface(dev));
 	int retval;
 	int retval;
 
 
+	if (off >= real_size)
+		return 0;
+
 	if (off != 0 || count != real_size)
 	if (off != 0 || count != real_size)
 		return -EINVAL;
 		return -EINVAL;