浏览代码

xfs: don't allow negative error tags

Errors go from zero which means no error to XFS_ERRTAG_MAX (22).  My
static checker complains that xfs_errortag_add() puts an upper bound on
this but not a lower bound.  Let's fix it by making it unsigned.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Dan Carpenter 9 年之前
父节点
当前提交
fbc21f33cd
共有 2 个文件被更改,包括 2 次插入2 次删除
  1. 1 1
      fs/xfs/xfs_error.c
  2. 1 1
      fs/xfs/xfs_error.h

+ 1 - 1
fs/xfs/xfs_error.c

@@ -55,7 +55,7 @@ xfs_error_test(int error_tag, int *fsidp, char *expression,
 }
 }
 
 
 int
 int
-xfs_errortag_add(int error_tag, xfs_mount_t *mp)
+xfs_errortag_add(unsigned int error_tag, xfs_mount_t *mp)
 {
 {
 	int i;
 	int i;
 	int len;
 	int len;

+ 1 - 1
fs/xfs/xfs_error.h

@@ -128,7 +128,7 @@ extern int xfs_error_test(int, int *, char *, int, char *, unsigned long);
 	 xfs_error_test((tag), (mp)->m_fixedfsid, "expr", __LINE__, __FILE__, \
 	 xfs_error_test((tag), (mp)->m_fixedfsid, "expr", __LINE__, __FILE__, \
 			(rf))))
 			(rf))))
 
 
-extern int xfs_errortag_add(int error_tag, struct xfs_mount *mp);
+extern int xfs_errortag_add(unsigned int error_tag, struct xfs_mount *mp);
 extern int xfs_errortag_clearall(struct xfs_mount *mp, int loud);
 extern int xfs_errortag_clearall(struct xfs_mount *mp, int loud);
 #else
 #else
 #define XFS_TEST_ERROR(expr, mp, tag, rf)	(expr)
 #define XFS_TEST_ERROR(expr, mp, tag, rf)	(expr)