Browse Source

crypto: asymmetric_keys - set error code on failure

In function public_key_verify_signature(), returns variable ret on
error paths. When the call to kmalloc() fails, the value of ret is 0,
and it is not set to an errno before returning. This patch fixes the
bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Pan Bian 8 years ago
parent
commit
fbb726302a
1 changed files with 1 additions and 0 deletions
  1. 1 0
      crypto/asymmetric_keys/public_key.c

+ 1 - 0
crypto/asymmetric_keys/public_key.c

@@ -121,6 +121,7 @@ int public_key_verify_signature(const struct public_key *pkey,
 	if (ret)
 	if (ret)
 		goto error_free_req;
 		goto error_free_req;
 
 
+	ret = -ENOMEM;
 	outlen = crypto_akcipher_maxsize(tfm);
 	outlen = crypto_akcipher_maxsize(tfm);
 	output = kmalloc(outlen, GFP_KERNEL);
 	output = kmalloc(outlen, GFP_KERNEL);
 	if (!output)
 	if (!output)