Browse Source

gpio: Remove impossible checks on container_of() result

container_of() does pointer math on the pointer that's passed in.
If it were to return a NULL pointer the value passed in would
need to be perfectly offset from 0 to make that so. Remove these
checks because they don't make sense.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Stephen Boyd 8 years ago
parent
commit
fb505747c0
1 changed files with 1 additions and 3 deletions
  1. 1 3
      drivers/gpio/gpiolib.c

+ 1 - 3
drivers/gpio/gpiolib.c

@@ -983,7 +983,7 @@ static int gpio_chrdev_open(struct inode *inode, struct file *filp)
 					      struct gpio_device, chrdev);
 					      struct gpio_device, chrdev);
 
 
 	/* Fail on open if the backing gpiochip is gone */
 	/* Fail on open if the backing gpiochip is gone */
-	if (!gdev || !gdev->chip)
+	if (!gdev->chip)
 		return -ENODEV;
 		return -ENODEV;
 	get_device(&gdev->dev);
 	get_device(&gdev->dev);
 	filp->private_data = gdev;
 	filp->private_data = gdev;
@@ -1002,8 +1002,6 @@ static int gpio_chrdev_release(struct inode *inode, struct file *filp)
 	struct gpio_device *gdev = container_of(inode->i_cdev,
 	struct gpio_device *gdev = container_of(inode->i_cdev,
 					      struct gpio_device, chrdev);
 					      struct gpio_device, chrdev);
 
 
-	if (!gdev)
-		return -ENODEV;
 	put_device(&gdev->dev);
 	put_device(&gdev->dev);
 	return 0;
 	return 0;
 }
 }