浏览代码

sata_mv: Delete unnecessary checks before the function call "phy_power_off"

The phy_power_off() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tejun Heo <tj@kernel.org>
Markus Elfring 10 年之前
父节点
当前提交
fad0601643
共有 1 个文件被更改,包括 2 次插入4 次删除
  1. 2 4
      drivers/ata/sata_mv.c

+ 2 - 4
drivers/ata/sata_mv.c

@@ -4185,8 +4185,7 @@ err:
 			clk_disable_unprepare(hpriv->port_clks[port]);
 			clk_disable_unprepare(hpriv->port_clks[port]);
 			clk_put(hpriv->port_clks[port]);
 			clk_put(hpriv->port_clks[port]);
 		}
 		}
-		if (hpriv->port_phys[port])
-			phy_power_off(hpriv->port_phys[port]);
+		phy_power_off(hpriv->port_phys[port]);
 	}
 	}
 
 
 	return rc;
 	return rc;
@@ -4216,8 +4215,7 @@ static int mv_platform_remove(struct platform_device *pdev)
 			clk_disable_unprepare(hpriv->port_clks[port]);
 			clk_disable_unprepare(hpriv->port_clks[port]);
 			clk_put(hpriv->port_clks[port]);
 			clk_put(hpriv->port_clks[port]);
 		}
 		}
-		if (hpriv->port_phys[port])
-			phy_power_off(hpriv->port_phys[port]);
+		phy_power_off(hpriv->port_phys[port]);
 	}
 	}
 	return 0;
 	return 0;
 }
 }