|
@@ -411,7 +411,7 @@ static int psbfb_create(struct psb_fbdev *fbdev,
|
|
|
info = drm_fb_helper_alloc_fbi(&fbdev->psb_fb_helper);
|
|
|
if (IS_ERR(info)) {
|
|
|
ret = PTR_ERR(info);
|
|
|
- goto out_err1;
|
|
|
+ goto err_free_range;
|
|
|
}
|
|
|
info->par = fbdev;
|
|
|
|
|
@@ -419,7 +419,7 @@ static int psbfb_create(struct psb_fbdev *fbdev,
|
|
|
|
|
|
ret = psb_framebuffer_init(dev, psbfb, &mode_cmd, backing);
|
|
|
if (ret)
|
|
|
- goto out_unref;
|
|
|
+ goto err_release;
|
|
|
|
|
|
fb = &psbfb->base;
|
|
|
psbfb->fbdev = info;
|
|
@@ -464,14 +464,9 @@ static int psbfb_create(struct psb_fbdev *fbdev,
|
|
|
psbfb->base.width, psbfb->base.height);
|
|
|
|
|
|
return 0;
|
|
|
-out_unref:
|
|
|
- if (backing->stolen)
|
|
|
- psb_gtt_free_range(dev, backing);
|
|
|
- else
|
|
|
- drm_gem_object_unreference_unlocked(&backing->gem);
|
|
|
-
|
|
|
+err_release:
|
|
|
drm_fb_helper_release_fbi(&fbdev->psb_fb_helper);
|
|
|
-out_err1:
|
|
|
+err_free_range:
|
|
|
psb_gtt_free_range(dev, backing);
|
|
|
return ret;
|
|
|
}
|