Browse Source

mmc: mxs: Initialize the spinlock prior to using it

An interrupt may occur right after devm_request_irq() is called and
prior to the spinlock initialization, leading to a kernel oops,
as the interrupt handler uses the spinlock.

In order to prevent this problem, move the spinlock initialization
prior to requesting the interrupts.

Fixes: e4243f13d10e (mmc: mxs-mmc: add mmc host driver for i.MX23/28)
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Fabio Estevam 8 years ago
parent
commit
f91346e8b5
1 changed files with 2 additions and 2 deletions
  1. 2 2
      drivers/mmc/host/mxs-mmc.c

+ 2 - 2
drivers/mmc/host/mxs-mmc.c

@@ -661,13 +661,13 @@ static int mxs_mmc_probe(struct platform_device *pdev)
 
 
 	platform_set_drvdata(pdev, mmc);
 	platform_set_drvdata(pdev, mmc);
 
 
+	spin_lock_init(&host->lock);
+
 	ret = devm_request_irq(&pdev->dev, irq_err, mxs_mmc_irq_handler, 0,
 	ret = devm_request_irq(&pdev->dev, irq_err, mxs_mmc_irq_handler, 0,
 			       dev_name(&pdev->dev), host);
 			       dev_name(&pdev->dev), host);
 	if (ret)
 	if (ret)
 		goto out_free_dma;
 		goto out_free_dma;
 
 
-	spin_lock_init(&host->lock);
-
 	ret = mmc_add_host(mmc);
 	ret = mmc_add_host(mmc);
 	if (ret)
 	if (ret)
 		goto out_free_dma;
 		goto out_free_dma;