Browse Source

bcache: fix cache_set_flush() NULL pointer dereference on OOM

When bch_cache_set_alloc() fails to kzalloc the cache_set, the
asyncronous closure handling tries to dereference a cache_set that
hadn't yet been allocated inside of cache_set_flush() which is called
by __cache_set_unregister() during cleanup.  This appears to happen only
during an OOM condition on bcache_register.

Signed-off-by: Eric Wheeler <bcache@linux.ewheeler.net>
Cc: stable@vger.kernel.org
Eric Wheeler 9 năm trước cách đây
mục cha
commit
f8b11260a4
1 tập tin đã thay đổi với 3 bổ sung0 xóa
  1. 3 0
      drivers/md/bcache/super.c

+ 3 - 0
drivers/md/bcache/super.c

@@ -1373,6 +1373,9 @@ static void cache_set_flush(struct closure *cl)
 	struct btree *b;
 	unsigned i;
 
+	if (!c)
+		closure_return(cl);
+
 	bch_cache_accounting_destroy(&c->accounting);
 
 	kobject_put(&c->internal);