Browse Source

sfc: don't rearm interrupts if busy polling

Since commit 364b6055738b ("net: busy-poll: return busypolling status
to drivers"), napi_complete_done() returns a boolean that can be used
by drivers to conditionally rearm interrupts.

Testing with a 7142 shows a small latency improvement of ~100 ns.

Signed-off-by: Bert Kenward <bkenward@solarflare.com>
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Bert Kenward 8 years ago
parent
commit
f820c0ac6c
1 changed files with 2 additions and 2 deletions
  1. 2 2
      drivers/net/ethernet/sfc/efx.c

+ 2 - 2
drivers/net/ethernet/sfc/efx.c

@@ -328,8 +328,8 @@ static int efx_poll(struct napi_struct *napi, int budget)
 		 * since efx_nic_eventq_read_ack() will have no effect if
 		 * since efx_nic_eventq_read_ack() will have no effect if
 		 * interrupts have already been disabled.
 		 * interrupts have already been disabled.
 		 */
 		 */
-		napi_complete_done(napi, spent);
-		efx_nic_eventq_read_ack(channel);
+		if (napi_complete_done(napi, spent))
+			efx_nic_eventq_read_ack(channel);
 	}
 	}
 
 
 	return spent;
 	return spent;