|
@@ -133,8 +133,7 @@ static inline void emac_report_timeout_error(struct emac_instance *dev,
|
|
|
EMAC_FTR_440EP_PHY_CLK_FIX))
|
|
|
DBG(dev, "%s" NL, error);
|
|
|
else if (net_ratelimit())
|
|
|
- printk(KERN_ERR "%s: %s\n", dev->ofdev->dev.of_node->full_name,
|
|
|
- error);
|
|
|
+ printk(KERN_ERR "%pOF: %s\n", dev->ofdev->dev.of_node, error);
|
|
|
}
|
|
|
|
|
|
/* EMAC PHY clock workaround:
|
|
@@ -2258,8 +2257,8 @@ static void emac_ethtool_get_drvinfo(struct net_device *ndev,
|
|
|
|
|
|
strlcpy(info->driver, "ibm_emac", sizeof(info->driver));
|
|
|
strlcpy(info->version, DRV_VERSION, sizeof(info->version));
|
|
|
- snprintf(info->bus_info, sizeof(info->bus_info), "PPC 4xx EMAC-%d %s",
|
|
|
- dev->cell_index, dev->ofdev->dev.of_node->full_name);
|
|
|
+ snprintf(info->bus_info, sizeof(info->bus_info), "PPC 4xx EMAC-%d %pOF",
|
|
|
+ dev->cell_index, dev->ofdev->dev.of_node);
|
|
|
}
|
|
|
|
|
|
static const struct ethtool_ops emac_ethtool_ops = {
|
|
@@ -2431,8 +2430,8 @@ static int emac_read_uint_prop(struct device_node *np, const char *name,
|
|
|
const u32 *prop = of_get_property(np, name, &len);
|
|
|
if (prop == NULL || len < sizeof(u32)) {
|
|
|
if (fatal)
|
|
|
- printk(KERN_ERR "%s: missing %s property\n",
|
|
|
- np->full_name, name);
|
|
|
+ printk(KERN_ERR "%pOF: missing %s property\n",
|
|
|
+ np, name);
|
|
|
return -ENODEV;
|
|
|
}
|
|
|
*val = *prop;
|
|
@@ -2768,7 +2767,7 @@ static int emac_init_phy(struct emac_instance *dev)
|
|
|
#endif
|
|
|
mutex_unlock(&emac_phy_map_lock);
|
|
|
if (i == 0x20) {
|
|
|
- printk(KERN_WARNING "%s: can't find PHY!\n", np->full_name);
|
|
|
+ printk(KERN_WARNING "%pOF: can't find PHY!\n", np);
|
|
|
return -ENXIO;
|
|
|
}
|
|
|
|
|
@@ -2894,8 +2893,8 @@ static int emac_init_config(struct emac_instance *dev)
|
|
|
#ifdef CONFIG_IBM_EMAC_NO_FLOW_CTRL
|
|
|
dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
|
|
|
#else
|
|
|
- printk(KERN_ERR "%s: Flow control not disabled!\n",
|
|
|
- np->full_name);
|
|
|
+ printk(KERN_ERR "%pOF: Flow control not disabled!\n",
|
|
|
+ np);
|
|
|
return -ENXIO;
|
|
|
#endif
|
|
|
}
|
|
@@ -2918,8 +2917,7 @@ static int emac_init_config(struct emac_instance *dev)
|
|
|
#ifdef CONFIG_IBM_EMAC_TAH
|
|
|
dev->features |= EMAC_FTR_HAS_TAH;
|
|
|
#else
|
|
|
- printk(KERN_ERR "%s: TAH support not enabled !\n",
|
|
|
- np->full_name);
|
|
|
+ printk(KERN_ERR "%pOF: TAH support not enabled !\n", np);
|
|
|
return -ENXIO;
|
|
|
#endif
|
|
|
}
|
|
@@ -2928,8 +2926,7 @@ static int emac_init_config(struct emac_instance *dev)
|
|
|
#ifdef CONFIG_IBM_EMAC_ZMII
|
|
|
dev->features |= EMAC_FTR_HAS_ZMII;
|
|
|
#else
|
|
|
- printk(KERN_ERR "%s: ZMII support not enabled !\n",
|
|
|
- np->full_name);
|
|
|
+ printk(KERN_ERR "%pOF: ZMII support not enabled !\n", np);
|
|
|
return -ENXIO;
|
|
|
#endif
|
|
|
}
|
|
@@ -2938,8 +2935,7 @@ static int emac_init_config(struct emac_instance *dev)
|
|
|
#ifdef CONFIG_IBM_EMAC_RGMII
|
|
|
dev->features |= EMAC_FTR_HAS_RGMII;
|
|
|
#else
|
|
|
- printk(KERN_ERR "%s: RGMII support not enabled !\n",
|
|
|
- np->full_name);
|
|
|
+ printk(KERN_ERR "%pOF: RGMII support not enabled !\n", np);
|
|
|
return -ENXIO;
|
|
|
#endif
|
|
|
}
|
|
@@ -2947,8 +2943,8 @@ static int emac_init_config(struct emac_instance *dev)
|
|
|
/* Read MAC-address */
|
|
|
p = of_get_property(np, "local-mac-address", NULL);
|
|
|
if (p == NULL) {
|
|
|
- printk(KERN_ERR "%s: Can't find local-mac-address property\n",
|
|
|
- np->full_name);
|
|
|
+ printk(KERN_ERR "%pOF: Can't find local-mac-address property\n",
|
|
|
+ np);
|
|
|
return -ENXIO;
|
|
|
}
|
|
|
memcpy(dev->ndev->dev_addr, p, ETH_ALEN);
|
|
@@ -3043,23 +3039,21 @@ static int emac_probe(struct platform_device *ofdev)
|
|
|
dev->emac_irq = irq_of_parse_and_map(np, 0);
|
|
|
dev->wol_irq = irq_of_parse_and_map(np, 1);
|
|
|
if (!dev->emac_irq) {
|
|
|
- printk(KERN_ERR "%s: Can't map main interrupt\n", np->full_name);
|
|
|
+ printk(KERN_ERR "%pOF: Can't map main interrupt\n", np);
|
|
|
goto err_free;
|
|
|
}
|
|
|
ndev->irq = dev->emac_irq;
|
|
|
|
|
|
/* Map EMAC regs */
|
|
|
if (of_address_to_resource(np, 0, &dev->rsrc_regs)) {
|
|
|
- printk(KERN_ERR "%s: Can't get registers address\n",
|
|
|
- np->full_name);
|
|
|
+ printk(KERN_ERR "%pOF: Can't get registers address\n", np);
|
|
|
goto err_irq_unmap;
|
|
|
}
|
|
|
// TODO : request_mem_region
|
|
|
dev->emacp = ioremap(dev->rsrc_regs.start,
|
|
|
resource_size(&dev->rsrc_regs));
|
|
|
if (dev->emacp == NULL) {
|
|
|
- printk(KERN_ERR "%s: Can't map device registers!\n",
|
|
|
- np->full_name);
|
|
|
+ printk(KERN_ERR "%pOF: Can't map device registers!\n", np);
|
|
|
err = -ENOMEM;
|
|
|
goto err_irq_unmap;
|
|
|
}
|
|
@@ -3068,8 +3062,7 @@ static int emac_probe(struct platform_device *ofdev)
|
|
|
err = emac_wait_deps(dev);
|
|
|
if (err) {
|
|
|
printk(KERN_ERR
|
|
|
- "%s: Timeout waiting for dependent devices\n",
|
|
|
- np->full_name);
|
|
|
+ "%pOF: Timeout waiting for dependent devices\n", np);
|
|
|
/* display more info about what's missing ? */
|
|
|
goto err_reg_unmap;
|
|
|
}
|
|
@@ -3084,8 +3077,8 @@ static int emac_probe(struct platform_device *ofdev)
|
|
|
dev->commac.rx_chan_mask = MAL_CHAN_MASK(dev->mal_rx_chan);
|
|
|
err = mal_register_commac(dev->mal, &dev->commac);
|
|
|
if (err) {
|
|
|
- printk(KERN_ERR "%s: failed to register with mal %s!\n",
|
|
|
- np->full_name, dev->mal_dev->dev.of_node->full_name);
|
|
|
+ printk(KERN_ERR "%pOF: failed to register with mal %pOF!\n",
|
|
|
+ np, dev->mal_dev->dev.of_node);
|
|
|
goto err_rel_deps;
|
|
|
}
|
|
|
dev->rx_skb_size = emac_rx_skb_size(ndev->mtu);
|
|
@@ -3161,8 +3154,8 @@ static int emac_probe(struct platform_device *ofdev)
|
|
|
|
|
|
err = register_netdev(ndev);
|
|
|
if (err) {
|
|
|
- printk(KERN_ERR "%s: failed to register net device (%d)!\n",
|
|
|
- np->full_name, err);
|
|
|
+ printk(KERN_ERR "%pOF: failed to register net device (%d)!\n",
|
|
|
+ np, err);
|
|
|
goto err_detach_tah;
|
|
|
}
|
|
|
|
|
@@ -3176,8 +3169,8 @@ static int emac_probe(struct platform_device *ofdev)
|
|
|
wake_up_all(&emac_probe_wait);
|
|
|
|
|
|
|
|
|
- printk(KERN_INFO "%s: EMAC-%d %s, MAC %pM\n",
|
|
|
- ndev->name, dev->cell_index, np->full_name, ndev->dev_addr);
|
|
|
+ printk(KERN_INFO "%s: EMAC-%d %pOF, MAC %pM\n",
|
|
|
+ ndev->name, dev->cell_index, np, ndev->dev_addr);
|
|
|
|
|
|
if (dev->phy_mode == PHY_MODE_SGMII)
|
|
|
printk(KERN_NOTICE "%s: in SGMII mode\n", ndev->name);
|