Эх сурвалжийг харах

hwmon: (ltc2945) Don't crash the kernel unnecessarily

An implementation error should not crash the kernel if it is avoidable.
Replace BUG() with WARN_ONCE().

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Guenter Roeck 11 жил өмнө
parent
commit
f75d723091

+ 3 - 3
drivers/hwmon/ltc2945.c

@@ -1,4 +1,4 @@
-/*
+    /*
  * Driver for Linear Technology LTC2945 I2C Power Monitor
  * Driver for Linear Technology LTC2945 I2C Power Monitor
  *
  *
  * Copyright (c) 2014 Guenter Roeck
  * Copyright (c) 2014 Guenter Roeck
@@ -314,8 +314,8 @@ static ssize_t ltc2945_reset_history(struct device *dev,
 		reg = LTC2945_MAX_ADIN_H;
 		reg = LTC2945_MAX_ADIN_H;
 		break;
 		break;
 	default:
 	default:
-		BUG();
-		break;
+		WARN_ONCE(1, "Bad register: 0x%x\n", reg);
+		return -EINVAL;
 	}
 	}
 	/* Reset maximum */
 	/* Reset maximum */
 	ret = regmap_bulk_write(regmap, reg, buf_max, num_regs);
 	ret = regmap_bulk_write(regmap, reg, buf_max, num_regs);