Explorar o código

md: Skip cluster setup in case of error while reading bitmap

If the bitmap read fails, the error code set is -EINVAL. However,
we don't check for errors and go ahead with cluster_setup.
Skip the cluster setup in case of error.

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Goldwyn Rodrigues %!s(int64=10) %!d(string=hai) anos
pai
achega
f735727319
Modificáronse 1 ficheiros con 1 adicións e 1 borrados
  1. 1 1
      drivers/md/bitmap.c

+ 1 - 1
drivers/md/bitmap.c

@@ -680,7 +680,7 @@ static int bitmap_read_sb(struct bitmap *bitmap)
 	kunmap_atomic(sb);
 	/* Assiging chunksize is required for "re_read" */
 	bitmap->mddev->bitmap_info.chunksize = chunksize;
-	if (nodes && (bitmap->cluster_slot < 0)) {
+	if (err == 0 && nodes && (bitmap->cluster_slot < 0)) {
 		err = md_setup_cluster(bitmap->mddev, nodes);
 		if (err) {
 			pr_err("%s: Could not setup cluster service (%d)\n",