Ver código fonte

iommu/vt-d: Don't store SIRTP request

Don't store the SIRTP request bit in the register state. It will
otherwise become sticky and could request an Interrupt Remap Table
Pointer update on each command register write.

Found while starting to emulate IR in QEMU, not by observing problems on
real hardware.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Jan Kiszka 11 anos atrás
pai
commit
f63ef69028
1 arquivos alterados com 1 adições e 2 exclusões
  1. 1 2
      drivers/iommu/intel_irq_remapping.c

+ 1 - 2
drivers/iommu/intel_irq_remapping.c

@@ -438,8 +438,7 @@ static void iommu_set_irq_remapping(struct intel_iommu *iommu, int mode)
 		    (addr) | IR_X2APIC_MODE(mode) | INTR_REMAP_TABLE_REG_SIZE);
 		    (addr) | IR_X2APIC_MODE(mode) | INTR_REMAP_TABLE_REG_SIZE);
 
 
 	/* Set interrupt-remapping table pointer */
 	/* Set interrupt-remapping table pointer */
-	iommu->gcmd |= DMA_GCMD_SIRTP;
-	writel(iommu->gcmd, iommu->reg + DMAR_GCMD_REG);
+	writel(iommu->gcmd | DMA_GCMD_SIRTP, iommu->reg + DMAR_GCMD_REG);
 
 
 	IOMMU_WAIT_OP(iommu, DMAR_GSTS_REG,
 	IOMMU_WAIT_OP(iommu, DMAR_GSTS_REG,
 		      readl, (sts & DMA_GSTS_IRTPS), sts);
 		      readl, (sts & DMA_GSTS_IRTPS), sts);