Browse Source

drm/rockchip: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Markus Elfring 9 years ago
parent
commit
f5e193a16d
1 changed files with 2 additions and 6 deletions
  1. 2 6
      drivers/gpu/drm/rockchip/rockchip_drm_fb.c

+ 2 - 6
drivers/gpu/drm/rockchip/rockchip_drm_fb.c

@@ -44,14 +44,10 @@ struct drm_gem_object *rockchip_fb_get_gem_obj(struct drm_framebuffer *fb,
 static void rockchip_drm_fb_destroy(struct drm_framebuffer *fb)
 static void rockchip_drm_fb_destroy(struct drm_framebuffer *fb)
 {
 {
 	struct rockchip_drm_fb *rockchip_fb = to_rockchip_fb(fb);
 	struct rockchip_drm_fb *rockchip_fb = to_rockchip_fb(fb);
-	struct drm_gem_object *obj;
 	int i;
 	int i;
 
 
-	for (i = 0; i < ROCKCHIP_MAX_FB_BUFFER; i++) {
-		obj = rockchip_fb->obj[i];
-		if (obj)
-			drm_gem_object_unreference_unlocked(obj);
-	}
+	for (i = 0; i < ROCKCHIP_MAX_FB_BUFFER; i++)
+		drm_gem_object_unreference_unlocked(rockchip_fb->obj[i]);
 
 
 	drm_framebuffer_cleanup(fb);
 	drm_framebuffer_cleanup(fb);
 	kfree(rockchip_fb);
 	kfree(rockchip_fb);