Browse Source

media: stv0367: prevent division by zero

While there's a test at the SNR calculus to avoid division by
zero, it will still follow the path that would do the division.
So, add a missing break there.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Mauro Carvalho Chehab 8 years ago
parent
commit
f5a1ba833d
1 changed files with 3 additions and 1 deletions
  1. 3 1
      drivers/media/dvb-frontends/stv0367.c

+ 3 - 1
drivers/media/dvb-frontends/stv0367.c

@@ -3014,8 +3014,10 @@ static void stv0367ddb_read_snr(struct dvb_frontend *fe)
 		regval = stv0367cab_snr_readreg(fe, 0);
 
 		/* prevent division by zero */
-		if (!regval)
+		if (!regval) {
 			snrval = 0;
+			break;
+		}
 
 		tmpval = (cab_pwr * 320) / regval;
 		snrval = ((tmpval != 0) ? (intlog2(tmpval) / 5581) : 0);