Browse Source

printk: add __printf attributes to internal functions

When compiling with -Wsuggest-attribute=format, gcc complains that some
functions in kernel/printk/printk_safe.c transmit their argument to
printf-like functions without having a printf attribute. Silence these
warnings by adding relevant __printf attributes.

Link: http://lkml.kernel.org/r/20170524054950.6722-1-nicolas.iooss_linux@m4x.org
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Nicolas Iooss 8 years ago
parent
commit
f4e981cba2
1 changed files with 5 additions and 5 deletions
  1. 5 5
      kernel/printk/printk_safe.c

+ 5 - 5
kernel/printk/printk_safe.c

@@ -80,8 +80,8 @@ static void queue_flush_work(struct printk_safe_seq_buf *s)
  * happen, printk_safe_log_store() will notice the buffer->len mismatch
  * happen, printk_safe_log_store() will notice the buffer->len mismatch
  * and repeat the write.
  * and repeat the write.
  */
  */
-static int printk_safe_log_store(struct printk_safe_seq_buf *s,
-				 const char *fmt, va_list args)
+static __printf(2, 0) int printk_safe_log_store(struct printk_safe_seq_buf *s,
+						const char *fmt, va_list args)
 {
 {
 	int add;
 	int add;
 	size_t len;
 	size_t len;
@@ -299,7 +299,7 @@ void printk_safe_flush_on_panic(void)
  * one writer running. But the buffer might get flushed from another
  * one writer running. But the buffer might get flushed from another
  * CPU, so we need to be careful.
  * CPU, so we need to be careful.
  */
  */
-static int vprintk_nmi(const char *fmt, va_list args)
+static __printf(1, 0) int vprintk_nmi(const char *fmt, va_list args)
 {
 {
 	struct printk_safe_seq_buf *s = this_cpu_ptr(&nmi_print_seq);
 	struct printk_safe_seq_buf *s = this_cpu_ptr(&nmi_print_seq);
 
 
@@ -330,7 +330,7 @@ void printk_nmi_exit(void)
 
 
 #else
 #else
 
 
-static int vprintk_nmi(const char *fmt, va_list args)
+static __printf(1, 0) int vprintk_nmi(const char *fmt, va_list args)
 {
 {
 	return 0;
 	return 0;
 }
 }
@@ -342,7 +342,7 @@ static int vprintk_nmi(const char *fmt, va_list args)
  * into itself. It uses a per-CPU buffer to store the message, just like
  * into itself. It uses a per-CPU buffer to store the message, just like
  * NMI.
  * NMI.
  */
  */
-static int vprintk_safe(const char *fmt, va_list args)
+static __printf(1, 0) int vprintk_safe(const char *fmt, va_list args)
 {
 {
 	struct printk_safe_seq_buf *s = this_cpu_ptr(&safe_print_seq);
 	struct printk_safe_seq_buf *s = this_cpu_ptr(&safe_print_seq);