Browse Source

dm bufio: fix time comparison to use time_after_eq()

To be future-proof and for better readability the time comparison
is modified to use time_after_eq() instead of plain, error-prone math.

Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Asaf Vertz 10 years ago
parent
commit
f495339c44
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/md/dm-bufio.c

+ 2 - 1
drivers/md/dm-bufio.c

@@ -11,6 +11,7 @@
 #include <linux/device-mapper.h>
 #include <linux/device-mapper.h>
 #include <linux/dm-io.h>
 #include <linux/dm-io.h>
 #include <linux/slab.h>
 #include <linux/slab.h>
+#include <linux/jiffies.h>
 #include <linux/vmalloc.h>
 #include <linux/vmalloc.h>
 #include <linux/shrinker.h>
 #include <linux/shrinker.h>
 #include <linux/module.h>
 #include <linux/module.h>
@@ -1739,7 +1740,7 @@ static unsigned get_max_age_hz(void)
 
 
 static bool older_than(struct dm_buffer *b, unsigned long age_hz)
 static bool older_than(struct dm_buffer *b, unsigned long age_hz)
 {
 {
-	return (jiffies - b->last_accessed) >= age_hz;
+	return time_after_eq(jiffies, b->last_accessed + age_hz);
 }
 }
 
 
 static void __evict_old_buffers(struct dm_bufio_client *c, unsigned long age_hz)
 static void __evict_old_buffers(struct dm_bufio_client *c, unsigned long age_hz)