ソースを参照

[PATCH] shpchp: fix improper write to Command Completion Detect bit

Current SHPCHP driver writes a '0' to the Command Completion Detect
bit to clear the Command Complete Interrupt Pending. But according to
the SHPC spec (See 4.7.3.1 System Interrupts), SHPCHP driver must
write '1'. This patch fixes this bug.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Kenji Kaneshige 20 年 前
コミット
f467f6187f
1 ファイル変更2 行追加2 行削除
  1. 2 2
      drivers/pci/hotplug/shpchp_hpc.c

+ 2 - 2
drivers/pci/hotplug/shpchp_hpc.c

@@ -1058,11 +1058,11 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
 	if (intr_loc & 0x0001) {
 	if (intr_loc & 0x0001) {
 		/* 
 		/* 
 		 * Command Complete Interrupt Pending 
 		 * Command Complete Interrupt Pending 
-		 * RO only - clear by writing 0 to the Command Completion
+		 * RO only - clear by writing 1 to the Command Completion
 		 * Detect bit in Controller SERR-INT register
 		 * Detect bit in Controller SERR-INT register
 		 */
 		 */
 		temp_dword = readl(php_ctlr->creg + SERR_INTR_ENABLE);
 		temp_dword = readl(php_ctlr->creg + SERR_INTR_ENABLE);
-		temp_dword &= 0xfffeffff;
+		temp_dword &= 0xfffdffff;
 		writel(temp_dword, php_ctlr->creg + SERR_INTR_ENABLE);
 		writel(temp_dword, php_ctlr->creg + SERR_INTR_ENABLE);
 		wake_up_interruptible(&ctrl->queue);
 		wake_up_interruptible(&ctrl->queue);
 	}
 	}