فهرست منبع

powerpc/cell/oprofile: Avoid double vfree of profile buffer

If an error occurs on opcontrol start, the event and per cpu buffers
are released.  If later opcontrol shutdown is called then the free
function will be called again to free buffers that no longer
exist.  This results in a kernel oops.  The following changes
prevent the call to delete buffers that don't exist.

Signed-off-by: Carl Love <carll@us.ibm.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Richter <robert.richter@amd.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Carl Love 17 سال پیش
والد
کامیت
f4156d1cd1
2فایلهای تغییر یافته به همراه5 افزوده شده و 1 حذف شده
  1. 3 1
      drivers/oprofile/cpu_buffer.c
  2. 2 0
      drivers/oprofile/event_buffer.c

+ 3 - 1
drivers/oprofile/cpu_buffer.c

@@ -38,8 +38,10 @@ void free_cpu_buffers(void)
 {
 	int i;
  
-	for_each_online_cpu(i)
+	for_each_online_cpu(i) {
 		vfree(per_cpu(cpu_buffer, i).buffer);
+		per_cpu(cpu_buffer, i).buffer = NULL;
+	}
 }
 
 int alloc_cpu_buffers(void)

+ 2 - 0
drivers/oprofile/event_buffer.c

@@ -93,6 +93,8 @@ int alloc_event_buffer(void)
 void free_event_buffer(void)
 {
 	vfree(event_buffer);
+
+	event_buffer = NULL;
 }