瀏覽代碼

drivers/net/hamradio: Move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Julia Lawall 16 年之前
父節點
當前提交
f40e063823
共有 1 個文件被更改,包括 2 次插入1 次删除
  1. 2 1
      drivers/net/hamradio/mkiss.c

+ 2 - 1
drivers/net/hamradio/mkiss.c

@@ -846,12 +846,13 @@ static int mkiss_ioctl(struct tty_struct *tty, struct file *file,
 	unsigned int cmd, unsigned long arg)
 	unsigned int cmd, unsigned long arg)
 {
 {
 	struct mkiss *ax = mkiss_get(tty);
 	struct mkiss *ax = mkiss_get(tty);
-	struct net_device *dev = ax->dev;
+	struct net_device *dev;
 	unsigned int tmp, err;
 	unsigned int tmp, err;
 
 
 	/* First make sure we're connected. */
 	/* First make sure we're connected. */
 	if (ax == NULL)
 	if (ax == NULL)
 		return -ENXIO;
 		return -ENXIO;
+	dev = ax->dev;
 
 
 	switch (cmd) {
 	switch (cmd) {
  	case SIOCGIFNAME:
  	case SIOCGIFNAME: