Prechádzať zdrojové kódy

f2fs: freeze filesystem when fail to update meta page due to IO error

In get_meta_page, we guarantee no failure for the returned page,
but sometimes, IO error from device will incur returning an
non-updated page.

Then, we still use this page as updated one, exception could happen
when using this kind of page.

So in this condition, we'd better freeze fs by making fs readonly and
and stop doing checkpoint.

Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Chao Yu 10 rokov pred
rodič
commit
f3f338caad
1 zmenil súbory, kde vykonal 8 pridanie a 0 odobranie
  1. 8 0
      fs/f2fs/checkpoint.c

+ 8 - 0
fs/f2fs/checkpoint.c

@@ -79,6 +79,14 @@ repeat:
 		f2fs_put_page(page, 1);
 		f2fs_put_page(page, 1);
 		goto repeat;
 		goto repeat;
 	}
 	}
+
+	/*
+	 * if there is any IO error when accessing device, make our filesystem
+	 * readonly and make sure do not write checkpoint with non-uptodate
+	 * meta page.
+	 */
+	if (unlikely(!PageUptodate(page)))
+		f2fs_stop_checkpoint(sbi);
 out:
 out:
 	return page;
 	return page;
 }
 }